From: Jonathan Cameron <jic23@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] iio: adc: max11100: Constify struct iio_chan_spec
Date: Sun, 31 May 2020 14:07:56 +0100 [thread overview]
Message-ID: <20200531140756.090f6204@archlinux> (raw)
In-Reply-To: <20200526210223.1672-2-rikard.falkeborn@gmail.com>
On Tue, 26 May 2020 23:02:18 +0200
Rikard Falkeborn <rikard.falkeborn@gmail.com> wrote:
> max11100_channels is not modified and can therefore be made const to
> allow the compiler to put it in read-only memory.
>
> Before:
> text data bss dec hex filename
> 3776 1168 0 4944 1350 drivers/iio/adc/max11100.o
>
> After:
> text data bss dec hex filename
> 3968 976 0 4944 1350 drivers/iio/adc/max11100.o
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/max11100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/max11100.c b/drivers/iio/adc/max11100.c
> index 3440539cfdba..b121ca78f851 100644
> --- a/drivers/iio/adc/max11100.c
> +++ b/drivers/iio/adc/max11100.c
> @@ -37,7 +37,7 @@ struct max11100_state {
> u8 buffer[3] ____cacheline_aligned;
> };
>
> -static struct iio_chan_spec max11100_channels[] = {
> +static const struct iio_chan_spec max11100_channels[] = {
> { /* [0] */
> .type = IIO_VOLTAGE,
> .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
next prev parent reply other threads:[~2020-05-31 13:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 21:02 [PATCH 0/6] drivers/iio: Constify structs Rikard Falkeborn
2020-05-26 21:02 ` [PATCH 1/6] iio: adc: max11100: Constify struct iio_chan_spec Rikard Falkeborn
2020-05-31 13:07 ` Jonathan Cameron [this message]
2020-05-26 21:02 ` [PATCH 2/6] iio: dac: ad5380: Constify struct iio_chan_spec_ext_info Rikard Falkeborn
2020-05-27 4:22 ` Ardelean, Alexandru
2020-05-31 13:44 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 3/6] iio: dac: ad5592r-base: " Rikard Falkeborn
2020-05-27 4:22 ` Ardelean, Alexandru
2020-05-31 13:47 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 4/6] iio: dac: ad5686: Constify static struct iio_chan_spec Rikard Falkeborn
2020-05-27 4:50 ` Ardelean, Alexandru
2020-05-31 13:47 ` Jonathan Cameron
2020-08-18 19:30 ` Rikard Falkeborn
2020-08-22 10:31 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 5/6] iio: light: stk3310: Constify regmap_config Rikard Falkeborn
2020-05-31 13:47 ` Jonathan Cameron
2020-05-26 21:02 ` [PATCH 6/6] iio: magnetometer: mmc35240: Constify struct reg_default Rikard Falkeborn
2020-05-31 13:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200531140756.090f6204@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.