All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Jonathan Albrieux <jonathan.albrieux@gmail.com>,
	linux-kernel@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht, daniel.baluta@gmail.com,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v4 2/5] dt-bindings: iio: imu: bmi160: add regulators and mount-matrix
Date: Sun, 31 May 2020 15:05:01 +0100	[thread overview]
Message-ID: <20200531150501.55a6e4c8@archlinux> (raw)
In-Reply-To: <20200529170943.GA2578764@bogus>

On Fri, 29 May 2020 11:09:43 -0600
Rob Herring <robh@kernel.org> wrote:

> On Mon, May 25, 2020 at 06:46:01PM +0200, Jonathan Albrieux wrote:
> > Add vdd-supply and vddio-supply support.
> > Add mount-matrix support.
> > 
> > Signed-off-by: Jonathan Albrieux <jonathan.albrieux@gmail.com>
> > ---
> >  .../bindings/iio/imu/bosch,bmi160.yaml           | 16 ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> > index 0d0ef84e22b9..cfe40dbcd723 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> > @@ -37,6 +37,17 @@ properties:
> >        set if the specified interrupt pin should be configured as
> >        open drain. If not set, defaults to push-pull.
> >  
> > +  vdd-supply:
> > +    maxItems: 1  
> 
> Supplies are always a single item, so don't need this.

Given this (and case below) were it outstanding for this patch I
fixed them up whilst applying rather than getting Jonathan to
go around again.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan

> 
> > +    description: provide VDD power to the sensor.
> > +
> > +  vddio-supply:
> > +    maxItems: 1
> > +    description: provide VDD IO power to the sensor.
> > +
> > +  mount-matrix:
> > +    description: an optional 3x3 mounting rotation matrix
> > +
> >  required:
> >    - compatible
> >    - reg
> > @@ -52,9 +63,14 @@ examples:
> >          bmi160@68 {
> >                  compatible = "bosch,bmi160";
> >                  reg = <0x68>;
> > +                vdd-supply = <&pm8916_l17>;
> > +                vddio-supply = <&pm8916_l6>;
> >                  interrupt-parent = <&gpio4>;
> >                  interrupts = <12 IRQ_TYPE_EDGE_RISING>;
> >                  interrupt-names = "INT1";
> > +                mount-matrix = "0", "1", "0",
> > +                               "-1", "0", "0",
> > +                               "0", "0", "1";
> >          };
> >      };
> >    - |
> > -- 
> > 2.17.1
> >   


  reply	other threads:[~2020-05-31 14:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 16:45 [PATCH v4 0/5] iio: imu: bmi160: added regulator and mount-matrix support Jonathan Albrieux
2020-05-25 16:46 ` [PATCH v4 1/5] dt-bindings: iio: imu: bmi160: convert format to yaml, add maintainer Jonathan Albrieux
2020-05-29 17:08   ` Rob Herring
2020-05-31 14:02     ` Jonathan Cameron
2020-05-25 16:46 ` [PATCH v4 2/5] dt-bindings: iio: imu: bmi160: add regulators and mount-matrix Jonathan Albrieux
2020-05-29 17:09   ` Rob Herring
2020-05-31 14:05     ` Jonathan Cameron [this message]
2020-05-25 16:46 ` [PATCH v4 3/5] iio: imu: bmi160: fix typo Jonathan Albrieux
2020-05-31 14:27   ` Jonathan Cameron
2020-05-25 16:46 ` [PATCH v4 4/5] iio: imu: bmi160: added regulator support Jonathan Albrieux
2020-05-31 14:28   ` Jonathan Cameron
2020-05-25 16:46 ` [PATCH v4 5/5] iio: imu: bmi160: added mount-matrix support Jonathan Albrieux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200531150501.55a6e4c8@archlinux \
    --to=jic23@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jonathan.albrieux@gmail.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.