From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA169C433E0 for ; Sun, 31 May 2020 21:01:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 854BA2070A for ; Sun, 31 May 2020 21:01:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbgEaVBc (ORCPT ); Sun, 31 May 2020 17:01:32 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:36822 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbgEaVBb (ORCPT ); Sun, 31 May 2020 17:01:31 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id AFC83804BB; Sun, 31 May 2020 23:01:28 +0200 (CEST) Date: Sun, 31 May 2020 23:01:27 +0200 From: Sam Ravnborg To: Colin King Cc: Greg Kroah-Hartman , Oliver Graute , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string Message-ID: <20200531210127.GD138722@ravnborg.org> References: <20200521135038.345878-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200521135038.345878-1-colin.king@canonical.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=DfNHnWVPAAAA:8 a=e5mUnYsNAAAA:8 a=O1M_s53xj7QJbslopEUA:9 a=CjuIK1q_8ugA:10 a=rjTVMONInIDnV1a_A2c_:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Colin/Greg. On Thu, May 21, 2020 at 02:50:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently HSD20_IPS is defined as "true" and will always result in a > non-zero result even if it is defined as "false" because it is an array > and that will never be zero. Fix this by defining it as an integer 1 > rather than a literal string. > > Addessses-Coverity: ("Array compared against 0") > Fixes: f03c9b788472 ("staging: fbtft: fb_st7789v: Initialize the Display") > Signed-off-by: Colin Ian King > --- > drivers/staging/fbtft/fb_st7789v.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c > index ebc17e05ecd0..3a280cc1892c 100644 > --- a/drivers/staging/fbtft/fb_st7789v.c > +++ b/drivers/staging/fbtft/fb_st7789v.c > @@ -24,7 +24,7 @@ > "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ > "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" > > -#define HSD20_IPS "true" > +#define HSD20_IPS 1 > > /** > * enum st7789v_command - ST7789V display controller commands Patch does not apply to drm-misc-next, seems to be a staging thing. So do not expext the DRM people to pick it up. Sam > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Date: Sun, 31 May 2020 21:01:27 +0000 Subject: Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string Message-Id: <20200531210127.GD138722@ravnborg.org> List-Id: References: <20200521135038.345878-1-colin.king@canonical.com> In-Reply-To: <20200521135038.345878-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Oliver Graute , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Hi Colin/Greg. On Thu, May 21, 2020 at 02:50:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently HSD20_IPS is defined as "true" and will always result in a > non-zero result even if it is defined as "false" because it is an array > and that will never be zero. Fix this by defining it as an integer 1 > rather than a literal string. > > Addessses-Coverity: ("Array compared against 0") > Fixes: f03c9b788472 ("staging: fbtft: fb_st7789v: Initialize the Display") > Signed-off-by: Colin Ian King > --- > drivers/staging/fbtft/fb_st7789v.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c > index ebc17e05ecd0..3a280cc1892c 100644 > --- a/drivers/staging/fbtft/fb_st7789v.c > +++ b/drivers/staging/fbtft/fb_st7789v.c > @@ -24,7 +24,7 @@ > "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ > "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" > > -#define HSD20_IPS "true" > +#define HSD20_IPS 1 > > /** > * enum st7789v_command - ST7789V display controller commands Patch does not apply to drm-misc-next, seems to be a staging thing. So do not expext the DRM people to pick it up. Sam > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 956E7C433DF for ; Sun, 31 May 2020 21:01:38 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6166E206A1 for ; Sun, 31 May 2020 21:01:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6166E206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 2ABD687941; Sun, 31 May 2020 21:01:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a+peY4pTCs28; Sun, 31 May 2020 21:01:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id E58CD85E7C; Sun, 31 May 2020 21:01:36 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 104151BF3D6 for ; Sun, 31 May 2020 21:01:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id EE9B3856BF for ; Sun, 31 May 2020 21:01:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5Cy1yS-zV-2U for ; Sun, 31 May 2020 21:01:33 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 213728561D for ; Sun, 31 May 2020 21:01:32 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id AFC83804BB; Sun, 31 May 2020 23:01:28 +0200 (CEST) Date: Sun, 31 May 2020 23:01:27 +0200 From: Sam Ravnborg To: Colin King Subject: Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string Message-ID: <20200531210127.GD138722@ravnborg.org> References: <20200521135038.345878-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200521135038.345878-1-colin.king@canonical.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=DfNHnWVPAAAA:8 a=e5mUnYsNAAAA:8 a=O1M_s53xj7QJbslopEUA:9 a=CjuIK1q_8ugA:10 a=rjTVMONInIDnV1a_A2c_:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Oliver Graute , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Hi Colin/Greg. On Thu, May 21, 2020 at 02:50:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently HSD20_IPS is defined as "true" and will always result in a > non-zero result even if it is defined as "false" because it is an array > and that will never be zero. Fix this by defining it as an integer 1 > rather than a literal string. > > Addessses-Coverity: ("Array compared against 0") > Fixes: f03c9b788472 ("staging: fbtft: fb_st7789v: Initialize the Display") > Signed-off-by: Colin Ian King > --- > drivers/staging/fbtft/fb_st7789v.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c > index ebc17e05ecd0..3a280cc1892c 100644 > --- a/drivers/staging/fbtft/fb_st7789v.c > +++ b/drivers/staging/fbtft/fb_st7789v.c > @@ -24,7 +24,7 @@ > "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ > "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" > > -#define HSD20_IPS "true" > +#define HSD20_IPS 1 > > /** > * enum st7789v_command - ST7789V display controller commands Patch does not apply to drm-misc-next, seems to be a staging thing. So do not expext the DRM people to pick it up. Sam > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D549C433DF for ; Sun, 31 May 2020 21:01:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64DC6206A1 for ; Sun, 31 May 2020 21:01:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64DC6206A1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A406C89F27; Sun, 31 May 2020 21:01:32 +0000 (UTC) Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AD4289F27 for ; Sun, 31 May 2020 21:01:31 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id AFC83804BB; Sun, 31 May 2020 23:01:28 +0200 (CEST) Date: Sun, 31 May 2020 23:01:27 +0200 From: Sam Ravnborg To: Colin King Subject: Re: [PATCH] staging: fbtft: fb_st7789v: make HSD20_IPS numeric and not a string Message-ID: <20200531210127.GD138722@ravnborg.org> References: <20200521135038.345878-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200521135038.345878-1-colin.king@canonical.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=G88y7es5 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=DfNHnWVPAAAA:8 a=e5mUnYsNAAAA:8 a=O1M_s53xj7QJbslopEUA:9 a=CjuIK1q_8ugA:10 a=rjTVMONInIDnV1a_A2c_:22 a=Vxmtnl_E_bksehYqCbjh:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Oliver Graute , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Colin/Greg. On Thu, May 21, 2020 at 02:50:38PM +0100, Colin King wrote: > From: Colin Ian King > > Currently HSD20_IPS is defined as "true" and will always result in a > non-zero result even if it is defined as "false" because it is an array > and that will never be zero. Fix this by defining it as an integer 1 > rather than a literal string. > > Addessses-Coverity: ("Array compared against 0") > Fixes: f03c9b788472 ("staging: fbtft: fb_st7789v: Initialize the Display") > Signed-off-by: Colin Ian King > --- > drivers/staging/fbtft/fb_st7789v.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c > index ebc17e05ecd0..3a280cc1892c 100644 > --- a/drivers/staging/fbtft/fb_st7789v.c > +++ b/drivers/staging/fbtft/fb_st7789v.c > @@ -24,7 +24,7 @@ > "D0 05 0A 09 08 05 2E 44 45 0F 17 16 2B 33\n" \ > "D0 05 0A 09 08 05 2E 43 45 0F 16 16 2B 33" > > -#define HSD20_IPS "true" > +#define HSD20_IPS 1 > > /** > * enum st7789v_command - ST7789V display controller commands Patch does not apply to drm-misc-next, seems to be a staging thing. So do not expext the DRM people to pick it up. Sam > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel