From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C8FC433E0 for ; Mon, 1 Jun 2020 21:45:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0884D2076B for ; Mon, 1 Jun 2020 21:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728932AbgFAVph (ORCPT ); Mon, 1 Jun 2020 17:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728360AbgFAVph (ORCPT ); Mon, 1 Jun 2020 17:45:37 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4345C061A0E; Mon, 1 Jun 2020 14:45:36 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D0DC011F5F637; Mon, 1 Jun 2020 14:45:35 -0700 (PDT) Date: Mon, 01 Jun 2020 14:45:35 -0700 (PDT) Message-Id: <20200601.144535.203726078659236025.davem@davemloft.net> To: victor@inliniac.net Cc: netdev@vger.kernel.org, kuba@kernel.org, corbet@lwn.net, edumazet@google.com, willemb@google.com, maowenan@huawei.com, arnd@arndb.de, nhorman@tuxdriver.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] af-packet: new flag to indicate all csums are good From: David Miller In-Reply-To: <20200601204938.13302-1-victor@inliniac.net> References: <20200601204938.13302-1-victor@inliniac.net> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Jun 2020 14:45:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Victor Julien Date: Mon, 1 Jun 2020 22:49:37 +0200 > @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALID This flag indicates that at least the transport > validated on the kernel side. If the flag is not set > then we are free to check the checksum by ourselves > provided that TP_STATUS_CSUMNOTREADY is also not set. > +TP_STATUS_CSUM_UNNECESSARY This flag indicates that the driver validated all > + the packets csums. If it is not set it might be that > + the driver doesn't support this, or that one of the > + layers csums is bad. TP_STATUS_CSUM_VALID may still > + be set if the transport layer csum is correct or > + if the driver supports only this mode. > ====================== ======================================================= ^^^^^ I think you need to reformat these dividers.