From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF016C433DF for ; Mon, 1 Jun 2020 05:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB1A02074B for ; Mon, 1 Jun 2020 05:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590990506; bh=zbjGSKYrzzSB+sq/pQ8w3/Me0mvCvWVALBgOqEgSoOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=stZrZP1+NK6lgrQPSjCFxMi6xPUCPwXRxgidDtpb8sQjGBRWMHtiZpXgJeyDQUmAi cFDCZ8k77sAAAL/dLBFgYy6dBUJTREbG6ceWUCU/rXLLmsjXsKjQiUbuxjGkfkNo1r 1Y/vjSRhBqZGx0+oFHgDTcs0mJcnB4bo7F8LBnSY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbgFAFs0 (ORCPT ); Mon, 1 Jun 2020 01:48:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:41874 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727100AbgFAFsU (ORCPT ); Mon, 1 Jun 2020 01:48:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3779B20734; Mon, 1 Jun 2020 05:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590990498; bh=zbjGSKYrzzSB+sq/pQ8w3/Me0mvCvWVALBgOqEgSoOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n9+w3ogjHkAQbFyjqveufeMn6/PLEfDYCbfs68A4yz6Ds9G6eisfcf1VR9CB8V4nN KN2apX9IiRFl4RiuwGz5BswT0oHCeWex/7DrjU7QiA5UM8i0lKYG2LlwOTs2ta+k91 x9MsR+eqf72WHY5yFZBzxJxLbkReLzLmUCm/vV0c= Date: Mon, 1 Jun 2020 07:48:16 +0200 From: Greg KH To: Benjamin Herrenschmidt Cc: Andra Paraschiv , linux-kernel@vger.kernel.org, Anthony Liguori , Colm MacCarthaigh , Bjoern Doebel , David Woodhouse , Frank van der Linden , Alexander Graf , Martin Pohlack , Matt Wilson , Paolo Bonzini , Balbir Singh , Stefano Garzarella , Stefan Hajnoczi , Stewart Smith , Uwe Dannowski , kvm@vger.kernel.org, ne-devel-upstream@amazon.com Subject: Re: [PATCH v3 07/18] nitro_enclaves: Init misc device providing the ioctl interface Message-ID: <20200601054816.GB1444369@kroah.com> References: <20200525221334.62966-1-andraprs@amazon.com> <20200525221334.62966-8-andraprs@amazon.com> <20200526065133.GD2580530@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 12:47:12PM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2020-05-26 at 08:51 +0200, Greg KH wrote: > > > > And get them to sign off on it too, showing they agree with the design > > decisions here :) > > Isn't it generally frowned upon to publish a patch with internal sign- > off's on it already ? Not at all. > Or do you mean for us to publicly sign off once we have reviewed ? Either is fine, as long as you do the public one "quickly" and don't rely on others to do the review first :) thanks, greg k-h