All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error
@ 2020-06-01  6:16 ` Dinghao Liu
  0 siblings, 0 replies; 17+ messages in thread
From: Dinghao Liu @ 2020-06-01  6:16 UTC (permalink / raw)
  To: dinghao.liu, kjlu
  Cc: Markus Elfring, Dong Aisheng, Shawn Guo, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team,
	Wolfram Sang, Fugang Duan, linux-i2c, linux-arm-kernel,
	linux-kernel

pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a corresponding decrement is
needed on the error handling path to keep the counter balanced.

Fix this by adding the missed function call.

Fixes: 13d6eb20fc79a ("i2c: imx-lpi2c: add runtime pm support")
Co-developed-by: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---

Changelog:

v2: - Use pm_runtime_put_noidle() instead of
      pm_runtime_put_autosuspend().

v3: - Refine commit message.
---
 drivers/i2c/busses/i2c-imx-lpi2c.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index 94743ba581fe..bdee02dff284 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -260,8 +260,10 @@ static int lpi2c_imx_master_enable(struct lpi2c_imx_struct *lpi2c_imx)
 	int ret;
 
 	ret = pm_runtime_get_sync(lpi2c_imx->adapter.dev.parent);
-	if (ret < 0)
+	if (ret < 0) {
+		pm_runtime_put_noidle(lpi2c_imx->adapter.dev.parent);
 		return ret;
+	}
 
 	temp = MCR_RST;
 	writel(temp, lpi2c_imx->base + LPI2C_MCR);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2020-06-15  7:41 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01  6:16 [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Dinghao Liu
2020-06-01  6:16 ` Dinghao Liu
2020-06-01  6:24 ` [EXT] " Andy Duan
2020-06-01  6:24   ` Andy Duan
2020-06-01  6:42 ` [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable() Markus Elfring
2020-06-01  6:42   ` Markus Elfring
2020-06-01  6:42   ` Markus Elfring
2020-06-14  9:12 ` [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Wolfram Sang
2020-06-14  9:12   ` Wolfram Sang
2020-06-14 12:08   ` dinghao.liu
2020-06-14 12:08     ` dinghao.liu
2020-06-15  6:33   ` Aisheng Dong
2020-06-15  6:33     ` Aisheng Dong
2020-06-15  7:06     ` Wolfram Sang
2020-06-15  7:06       ` Wolfram Sang
2020-06-15  7:40       ` Markus Elfring
2020-06-15  7:40         ` Markus Elfring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.