From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_BTC_ID, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E11C433E0 for ; Mon, 1 Jun 2020 16:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24F5020760 for ; Mon, 1 Jun 2020 16:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591028874; bh=OhM//pjAEor/C16pejhNDh8yofsRrAyHbF7ad6M3Dlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=GzvMtXiFBfPRajA0j07yNOI8Q2qBkHw1MWhbmF10+/CyfTNK51tcVYHwn+ZltK1gH uAkffndkqk+vtDJDGpLugSUNNXkvEb0YVx6agbBT83d8XYrrFqjj8V/+cxW/d9LYst fBdRXyONuKcuR4Gp1UsaLruaLTBMTpupGGeBqk6c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbgFAQ1x (ORCPT ); Mon, 1 Jun 2020 12:27:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:34062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726067AbgFAQ1x (ORCPT ); Mon, 1 Jun 2020 12:27:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8304E2073B; Mon, 1 Jun 2020 16:27:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591028873; bh=OhM//pjAEor/C16pejhNDh8yofsRrAyHbF7ad6M3Dlk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D8CQGAa6qJcjKT6TxNkuYU3Jf1FR8J+Kz7UlsW4iLEiWLomRtHZChliV4znFV01S7 FtzE0+RJxYLLAh2nUAZyEqte3Xx0JoLOamTQsiZ/2QyiQrWDe66u+nRURQZGP0sTCi Hztdzov1Z2NodQ+o0dnEZCxk6XV6X+/wh/EefGpw= Date: Mon, 1 Jun 2020 18:27:50 +0200 From: Greg KH To: Dakshaja Uppalapati Cc: hch@lst.de, sagi@grimberg.me, stable@vger.kernel.org, nirranjan@chelsio.com, bharat@chelsio.com Subject: Re: nvme blk_update_request IO error is seen on stable kernel 5.4.41. Message-ID: <20200601162750.GA887723@kroah.com> References: <20200521140642.GA4724@chelsio.com> <20200526102542.GA2772976@kroah.com> <20200528074426.GA20353@chelsio.com> <20200528083403.GB2920930@kroah.com> <20200601162143.GA917@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200601162143.GA917@chelsio.com> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jun 01, 2020 at 09:51:44PM +0530, Dakshaja Uppalapati wrote: > On Thursday, May 05/28/20, 2020 at 10:34:03 +0200, Greg KH wrote: > > On Thu, May 28, 2020 at 01:14:31PM +0530, Dakshaja Uppalapati wrote: > > > On Tuesday, May 05/26/20, 2020 at 12:25:42 +0200, Greg KH wrote: > > > > On Thu, May 21, 2020 at 07:36:43PM +0530, Dakshaja Uppalapati wrote: > > > > > Hi all, > > > > > > > > > > Issue which is reported in https://lore.kernel.org/linux-nvme/CH2PR12MB40050ACF > > > > > 2C0DC7439355ED3FDD270@CH2PR12MB4005.namprd12.prod.outlook.com/T/#r8cfc80b26f0cd > > > > > 1cde41879a68fd6a71186e9594c is also seen on stable kernel 5.4.41. > > > > > > > > What issue is that? Your url is wrapped and can not work here :( > > > > > > Sorry for that, when I tried to format the disk discovered from target machine > > > the below error is seen in dmesg. > > > > > > dmesg: > > > [ 1844.868480] blk_update_request: I/O error, dev nvme0c0n1, sector 0 > > > op 0x3:(DISCARD) flags 0x4000800 phys_seg 1 prio class 0 > > > > > > The above issue is seen from kernel-5.5-rc1 onwards. > > > > > > > > > > > > In upstream issue is fixed with commit b716e6889c95f64b. > > > > > > > > Is this a regression or support for something new that has never worked > > > > before? > > > > > > > > > > This is a regression, bisects points to the commit 530436c4 and fixed with > > > commit b716e688 in upstream. > > > > > > Now same issue is seen with stable kernel-5.4.41, 530436c4 is part of it. > > > > So why don't we just revert 530436c45ef2 ("nvme: Discard workaround for > > non-conformant devices") from the stable trees? Will that fix the issue > > for you instead of the much-larger set of backports you are proposing? > > > > Also, is this an issue for you in the 4.19 releases? The above > > mentioned patch showed up in 4.19.92 and 5.4.7. > > > > Yes, on 4.19 stable kernel too issue is seen. By reverting 530436c45ef2 issue > is not seen on both 4.19 and 5.4 stable kernels. Do you want me to send the > reverted patch? Yes please. thanks, greg k-h