All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, hughd@google.com,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Zi Yan <ziy@nvidia.com>, John Hubbard <jhubbard@nvidia.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split
Date: Mon, 1 Jun 2020 12:57:36 -0400	[thread overview]
Message-ID: <20200601165736.qw5kwwknxltk7bv6@ca-dmjordan1.us.oracle.com> (raw)
In-Reply-To: <1590118444-21601-1-git-send-email-anshuman.khandual@arm.com>

Hi Anshuman,

On Fri, May 22, 2020 at 09:04:04AM +0530, Anshuman Khandual wrote:
> This adds the following two new VM events which will help in validating PMD
> based THP migration without split. Statistics reported through these events
> will help in performance debugging.
> 
> 1. THP_PMD_MIGRATION_SUCCESS
> 2. THP_PMD_MIGRATION_FAILURE

The names suggest a binary event similar to the existing
pgmigrate_success/fail, but FAILURE only tracks one kind of migration error,
and then only when the thp is successfully split, so shouldn't it be called
SPLIT instead?

  reply	other threads:[~2020-06-01 16:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  3:34 [PATCH] mm/vmstat: Add events for PMD based THP migration without split Anshuman Khandual
2020-06-01 16:57 ` Daniel Jordan [this message]
2020-06-02  3:20   ` John Hubbard
2020-06-02  4:20     ` Anshuman Khandual
2020-06-02  4:48       ` John Hubbard
2020-06-02  5:30         ` Anshuman Khandual
2020-06-02 14:52         ` Daniel Jordan
2020-06-03  4:36           ` Anshuman Khandual
2020-06-03 16:08             ` Daniel Jordan
2020-06-02 15:01 ` Matthew Wilcox
2020-06-03  1:26   ` Anshuman Khandual
2020-06-03  2:57     ` Matthew Wilcox
2020-06-03  4:58       ` Anshuman Khandual
2020-06-03 11:09         ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200601165736.qw5kwwknxltk7bv6@ca-dmjordan1.us.oracle.com \
    --to=daniel.m.jordan@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=hughd@google.com \
    --cc=jhubbard@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.