From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46581C433E1 for ; Mon, 1 Jun 2020 18:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 194EA20679 for ; Mon, 1 Jun 2020 18:57:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037859; bh=RHYFlKGmv3ZEU4RWy/4On0Pa7vSBAT0uv4j1Gh7M49Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1KACMNrhVg48iVKRMCxrObOEDixYzvvJAr+y3Q/x/Dy9RiqV3Pd3zvnzw17r1j6YJ 8n3wE3y8l+cXvX/1RtxcnzwNWYuEzZu4cMqLYPmd1gLW6LRSND0kLZGGIb+b/n69Gk EDwwzmmh/zhQWA9sR16lMfqPr7K1ni5gOJEBIvfw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730757AbgFAS5d (ORCPT ); Mon, 1 Jun 2020 14:57:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:42402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729555AbgFAR7w (ORCPT ); Mon, 1 Jun 2020 13:59:52 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73E46206E2; Mon, 1 Jun 2020 17:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034391; bh=RHYFlKGmv3ZEU4RWy/4On0Pa7vSBAT0uv4j1Gh7M49Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZMFCEthxgUwpLrI/RLaLZJkAE0lfStHCr+wvRhTEFtkAEEFuk1PASHliweIJCTm23 RjpDdqB5pWxVanSYkuzM4O+rWmUBj7tUgX08W1ME2li+cTZ2rUpqWrdpU54L0o6o1p lpCS3nzO9iKo9x0wmU+xCVcb/Ymrf34N6aciz5xo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , "David S. Miller" Subject: [PATCH 4.14 11/77] net/mlx4_core: fix a memory leak bug. Date: Mon, 1 Jun 2020 19:53:16 +0200 Message-Id: <20200601174018.557560240@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174016.396817032@linuxfoundation.org> References: <20200601174016.396817032@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu commit febfd9d3c7f74063e8e630b15413ca91b567f963 upstream. In function mlx4_opreq_action(), pointer "mailbox" is not released, when mlx4_cmd_box() return and error, causing a memory leak bug. Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can free this pointer. Fixes: fe6f700d6cbb ("net/mlx4_core: Respond to operation request by firmware") Signed-off-by: Qiushi Wu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2715,7 +2715,7 @@ void mlx4_opreq_action(struct work_struc if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - return; + goto out; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);