From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2EB2C433DF for ; Mon, 1 Jun 2020 18:02:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B96C3207DA for ; Mon, 1 Jun 2020 18:02:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034546; bh=34OV/T33rjUYauDRA5grfF8VnK8diJYzM6GiXKWCvOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=amChjDmjKgqVoifeWDgYQMJY5sRQPtCCDKJy/oq71hz6StPs4gURx19igtbZuJmjG 27yZE9iGqfykRYSNuikFDZnUaOj+fhmTJsLtF/NQXkLp/O9WzvhGj1V/p/eoWJl+np FoqanQajWkbA9y6mvToE8omrB7fx5TP62CNwKNTM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729925AbgFASCZ (ORCPT ); Mon, 1 Jun 2020 14:02:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729915AbgFASCT (ORCPT ); Mon, 1 Jun 2020 14:02:19 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E031E207DA; Mon, 1 Jun 2020 18:02:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034539; bh=34OV/T33rjUYauDRA5grfF8VnK8diJYzM6GiXKWCvOQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ttRv9EyUtWSoahMU1gdnRqQ7vs9Jw/Qaj9djfQgQmsNYlUTPTWk7FDbiExf1Rf1Dn DWEDjV6dKsjHPsEdKKQghppMWitquLB4MPYZkUwNQWzra+sBHtsSnKCQy7y8rIfpIG S9k1xBX8/BhTRvBSSE+xYqSjwUQfwdMaL/XiuSIQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, John Garry , Salil Mehta , "David S. Miller" Subject: [PATCH 4.14 77/77] net: hns: Fixes the missing put_device in positive leg for roce reset Date: Mon, 1 Jun 2020 19:54:22 +0200 Message-Id: <20200601174029.792461483@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174016.396817032@linuxfoundation.org> References: <20200601174016.396817032@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Salil Mehta commit 4d96e13ee9cd1f7f801e8c7f4b12f09d1da4a5d8 upstream. This patch fixes the missing device reference release-after-use in the positive leg of the roce reset API of the HNS DSAF. Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") Reported-by: John Garry Signed-off-by: Salil Mehta Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -3142,6 +3142,9 @@ int hns_dsaf_roce_reset(struct fwnode_ha dsaf_set_bit(credit, DSAF_SBM_ROCEE_CFG_CRD_EN_B, 1); dsaf_write_dev(dsaf_dev, DSAF_SBM_ROCEE_CFG_REG_REG, credit); } + + put_device(&pdev->dev); + return 0; } EXPORT_SYMBOL(hns_dsaf_roce_reset);