From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F3AC433DF for ; Mon, 1 Jun 2020 18:42:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EB3E2087D for ; Mon, 1 Jun 2020 18:42:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591036922; bh=Jzhk2Jep2Ej1UIoC9Bin7Re5JWpsfWDcmtSHejPa6JU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ShkdzeGPdKMILi3Mo8WpAHS/cOOP4Pj8grxtzZy9uEgkEA2ne6/y0DMvEQt2+D1dV lnHjgp22njOPL4VHcmxeRMpq5+xu0XPXuUGIxGtLmpEUnEyXR9cNX55GJS6fdjGeyv PGWqXCalEBWLLrXPIQKimNzhNdDDG0EMVbI0fiIU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730478AbgFASMK (ORCPT ); Mon, 1 Jun 2020 14:12:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:59286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730754AbgFASL7 (ORCPT ); Mon, 1 Jun 2020 14:11:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4163C20776; Mon, 1 Jun 2020 18:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591035118; bh=Jzhk2Jep2Ej1UIoC9Bin7Re5JWpsfWDcmtSHejPa6JU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ne2hxQ9+VyEFLGkKnZxxUGkB9MByKwLjW0czJxdPwRY6jxEK70sIaVNzlzjrkU9DT vToamBkZ+mvjl7JIzmyHaxtq+bPAkK2V1uSQIuH/a6+z9XWDkH7we+lYWhTycTEr3Q OazFUjxprdbWwLKWDpIU44FIFJUP17Xe/lldN9YQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, ASSOGBA Emery , David Ahern , "David S. Miller" Subject: [PATCH 5.6 018/177] nexthop: Fix attribute checking for groups Date: Mon, 1 Jun 2020 19:52:36 +0200 Message-Id: <20200601174050.204297493@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174048.468952319@linuxfoundation.org> References: <20200601174048.468952319@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Ahern [ Upstream commit 84be69b869a5a496a6cfde9b3c29509207a1f1fa ] For nexthop groups, attributes after NHA_GROUP_TYPE are invalid, but nh_check_attr_group starts checking at NHA_GROUP. The group type defaults to multipath and the NHA_GROUP_TYPE is currently optional so this has slipped through so far. Fix the attribute checking to handle support of new group types. Fixes: 430a049190de ("nexthop: Add support for nexthop groups") Signed-off-by: ASSOGBA Emery Signed-off-by: David Ahern Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/ipv4/nexthop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/net/ipv4/nexthop.c +++ b/net/ipv4/nexthop.c @@ -434,7 +434,7 @@ static int nh_check_attr_group(struct ne if (!valid_group_nh(nh, len, extack)) return -EINVAL; } - for (i = NHA_GROUP + 1; i < __NHA_MAX; ++i) { + for (i = NHA_GROUP_TYPE + 1; i < __NHA_MAX; ++i) { if (!tb[i]) continue;