From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0CEDC433DF for ; Mon, 1 Jun 2020 17:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82D32207DF for ; Mon, 1 Jun 2020 17:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="wS+C3T2s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727769AbgFARsJ (ORCPT ); Mon, 1 Jun 2020 13:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgFARsJ (ORCPT ); Mon, 1 Jun 2020 13:48:09 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95DDCC08C5C9 for ; Mon, 1 Jun 2020 10:48:07 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id r9so357585wmh.2 for ; Mon, 01 Jun 2020 10:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EF2MUXWe+0T7eyxkA8rRyjXJ0lsym9S82yVeKfIolyg=; b=wS+C3T2s8Q7602JUv3jWGhy8HPjzuOYzUPOpfSA5smX0EG3VwfTnAlZsoGasBnlyfg 4ERS3mJMRO2/G3pVMuJSD09lBkKa/NcDOuUqMb4g2CwqWQzMCBZvoQ41i3H50aDvU0Rx ERuHo8/KK/pjd5PZRwwIPJ7mKT7wV7tPAFfpZjYgZDp6jCA3KWWzxyjNE3+7HmbsVdEP /SpwYW0aUknx/oMKZE168CjaLYOdZj4+BaQ4/j7WddQdFJc3qUZtVYgRGgOE2Dgyfl6G HhzZGjddlkJ2txyX10rH5WJWrhyn7jSt+lSXuW5wTNQNHTeNVN9+BYBjjr/SvmVXYhlX Hg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EF2MUXWe+0T7eyxkA8rRyjXJ0lsym9S82yVeKfIolyg=; b=Fc/OCl9y8Y9ngYojx6Qivrg/hgCvP0V0F0uGzihNQVsJRBvT9SbB3IUWubDK9R3Eme 2GECsS3tSRgdA13/plNp/fxJa8ICwmZgTNG4qhkebyrpF7ibWhceXFRR59barKqvIbLL 3mVehGbS5Uckq/dJQwEPWAHTJW7AVzZdaJV2gYr1qydvtUiYX9zCIefvaVhO2coIx4pO Rut5P6npguu8/R8ikHuhGUm+3y9Rj8EvzOK5K0/cmZ6Sc0luIMJAwQC5UQp8ZXyznSpC Nrxpg3S7EULsVL9RZXQdeGgXZP5voZPE5squyGbenIhmvShT3vDrKkE9TJdz/ippnudB idUA== X-Gm-Message-State: AOAM532AhH8/OufY7VZUIL9dSBlQfRTjBexUU4TNso9sWaN9lafB1qeN JpREUqNO0k+De5L74irtPwZqOg== X-Google-Smtp-Source: ABdhPJwGZ7xVM43OkmrdbN8kKFpqKZnhsQ0DhmfJ55I00xz5ohrw+O7sia6vxKrkXQ2zK+FBQy25gA== X-Received: by 2002:a05:600c:2110:: with SMTP id u16mr426062wml.26.1591033686091; Mon, 01 Jun 2020 10:48:06 -0700 (PDT) Received: from x1 ([2001:16b8:5cbd:c001:98fe:8f8:cce1:59e]) by smtp.gmail.com with ESMTPSA id l1sm297821wrb.31.2020.06.01.10.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 10:48:05 -0700 (PDT) Date: Mon, 1 Jun 2020 19:48:03 +0200 From: Drew Fustini To: Tony Lindgren Cc: Haojian Zhuang , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Kridner , Robert Nelson Subject: Re: [PATCH] pinctrl-single: fix pcs_parse_pinconf() return val Message-ID: <20200601174803.GD1371046@x1> References: <20200531204147.GA664833@x1> <20200601161851.GC37466@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200601161851.GC37466@atomide.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 01, 2020 at 09:18:51AM -0700, Tony Lindgren wrote: > * Drew Fustini [200531 20:42]: > > This patch causes pcs_parse_pinconf() to return an error when no > > pinctrl_map is added. The current behavior is to return 0 when > > !PCS_HAS_PINCONF or !nconfs. Thus pcs_parse_one_pinctrl_entry() > > incorrectly assumes that a map was added and sets num_maps = 2. > > Looks OK to me, would be good to wait for Haojian to test this one. > > Regards, > > Tony Yes, I would like to get input as I don't have the other platforms using "pinconf,single": $ git grep 'compatible = "pinconf-single"' arch/ arch/arm/boot/dts/am33xx-l4.dtsi: compatible = "pinconf-single"; arch/arm/boot/dts/hi3620.dtsi: compatible = "pinconf-single"; arch/arm/boot/dts/pxa3xx.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi6220.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi6220.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; NOTE: the arch/arm/boot/dts/am33xx-l4.dtsi was patched by me from "pinctrl-single" to "pinconf-single. But, I think for upstream submission I would need to move that to one of the beaglebone specific dts files like am335x-bone-common.dtsi. I believe this pinctrl-single.c patch fixes a flaw in return logic and is useful regardless of whether beaglebone adopts "pinconf,single". However, I would very much like to get input from others in case my analysis is too narrow. Thanks, Drew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC82AC433E0 for ; Mon, 1 Jun 2020 17:48:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB1D5206A4 for ; Mon, 1 Jun 2020 17:48:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r3deP88S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.b="wS+C3T2s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB1D5206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=beagleboard.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YQblidR2UlYENNpkw61lDi/TdxepPOLKGo4vd9i2qw0=; b=r3deP88STTvPKd qLL7cYaQvk9laK/ekX0H+QxnNwTcBSf52xhyzIN6X9X/sy4sS6OB10K9nP7pHYLYksXEZroDEThzd 44mwg0n8RSsyF2zDGF4SBWU6GVxZPCa3iVobQijpyQv3U2HlLkxf64gctVp/4rSUWiOUY8wFSSXag i2C5cxja/M6T+h7MmLtOk6tsk6B58mBikT+tnufl1M4IXmPp5taWrBqmoL9NVqDyarKswnqwMl6sr K8xOgS08g3qdCfTZbOyXXx6vTaqZyzDEVbSsjbz5EVQ03SU9DDTjRmPAFyVMZm38o+9n6wrYizTPY 8eMz9PoSgX4EfleOAHwQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfoXn-0006i8-TY; Mon, 01 Jun 2020 17:48:15 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jfoXk-0006h9-88 for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2020 17:48:13 +0000 Received: by mail-wm1-x343.google.com with SMTP id q25so408109wmj.0 for ; Mon, 01 Jun 2020 10:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EF2MUXWe+0T7eyxkA8rRyjXJ0lsym9S82yVeKfIolyg=; b=wS+C3T2s8Q7602JUv3jWGhy8HPjzuOYzUPOpfSA5smX0EG3VwfTnAlZsoGasBnlyfg 4ERS3mJMRO2/G3pVMuJSD09lBkKa/NcDOuUqMb4g2CwqWQzMCBZvoQ41i3H50aDvU0Rx ERuHo8/KK/pjd5PZRwwIPJ7mKT7wV7tPAFfpZjYgZDp6jCA3KWWzxyjNE3+7HmbsVdEP /SpwYW0aUknx/oMKZE168CjaLYOdZj4+BaQ4/j7WddQdFJc3qUZtVYgRGgOE2Dgyfl6G HhzZGjddlkJ2txyX10rH5WJWrhyn7jSt+lSXuW5wTNQNHTeNVN9+BYBjjr/SvmVXYhlX Hg4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EF2MUXWe+0T7eyxkA8rRyjXJ0lsym9S82yVeKfIolyg=; b=Df3MYv9yhjbKrnxgz1s6izxbP3ZI7+eZR4XC9JQWafEGlUgHJ/rRv84geFh5lpnlst U7m++qmG0fgVA5JYSfbh8naj/UBu0FOXYnQwDNQoD0blBFMf0aIhcL/sxeAzYMVo5r4t WIl4zTCkislPNk9/f9uttDvOWCKVqRHfMK5fYi+cMBgGm/Zqu9gDX+4dSnD536UTpABc efV3NORLOoE9DM3qT1DtneeR5+wzjLmS1Gf7v8Kgyu2kB2XHrCcbb7MOY0PR7GHGh5Zx +Hdlo89JrTJF46KdjKZmdGqnRqX5YWL4xRdDgkAMhzaSE45Fye4aHT5q/hhrkwEXmwQM +6jw== X-Gm-Message-State: AOAM5337fKDPzXxojIxn8rGMqcchYTIbDA8PAD+myGx771u2aQ2Dx4JO VTb+jtlSVOj4S5e+Yqn/HjmLmA== X-Google-Smtp-Source: ABdhPJwGZ7xVM43OkmrdbN8kKFpqKZnhsQ0DhmfJ55I00xz5ohrw+O7sia6vxKrkXQ2zK+FBQy25gA== X-Received: by 2002:a05:600c:2110:: with SMTP id u16mr426062wml.26.1591033686091; Mon, 01 Jun 2020 10:48:06 -0700 (PDT) Received: from x1 ([2001:16b8:5cbd:c001:98fe:8f8:cce1:59e]) by smtp.gmail.com with ESMTPSA id l1sm297821wrb.31.2020.06.01.10.48.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 10:48:05 -0700 (PDT) Date: Mon, 1 Jun 2020 19:48:03 +0200 From: Drew Fustini To: Tony Lindgren Subject: Re: [PATCH] pinctrl-single: fix pcs_parse_pinconf() return val Message-ID: <20200601174803.GD1371046@x1> References: <20200531204147.GA664833@x1> <20200601161851.GC37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200601161851.GC37466@atomide.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200601_104812_288294_661ACA21 X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , linux-kernel@vger.kernel.org, Robert Nelson , linux-gpio@vger.kernel.org, Jason Kridner , Haojian Zhuang , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 01, 2020 at 09:18:51AM -0700, Tony Lindgren wrote: > * Drew Fustini [200531 20:42]: > > This patch causes pcs_parse_pinconf() to return an error when no > > pinctrl_map is added. The current behavior is to return 0 when > > !PCS_HAS_PINCONF or !nconfs. Thus pcs_parse_one_pinctrl_entry() > > incorrectly assumes that a map was added and sets num_maps = 2. > > Looks OK to me, would be good to wait for Haojian to test this one. > > Regards, > > Tony Yes, I would like to get input as I don't have the other platforms using "pinconf,single": $ git grep 'compatible = "pinconf-single"' arch/ arch/arm/boot/dts/am33xx-l4.dtsi: compatible = "pinconf-single"; arch/arm/boot/dts/hi3620.dtsi: compatible = "pinconf-single"; arch/arm/boot/dts/pxa3xx.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi6220.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hi6220.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey960-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; arch/arm64/boot/dts/hisilicon/hikey970-pinctrl.dtsi: compatible = "pinconf-single"; NOTE: the arch/arm/boot/dts/am33xx-l4.dtsi was patched by me from "pinctrl-single" to "pinconf-single. But, I think for upstream submission I would need to move that to one of the beaglebone specific dts files like am335x-bone-common.dtsi. I believe this pinctrl-single.c patch fixes a flaw in return logic and is useful regardless of whether beaglebone adopts "pinconf,single". However, I would very much like to get input from others in case my analysis is too narrow. Thanks, Drew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel