From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0627C433E1 for ; Mon, 1 Jun 2020 21:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B838D206E2 for ; Mon, 1 Jun 2020 21:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728843AbgFAVk0 (ORCPT ); Mon, 1 Jun 2020 17:40:26 -0400 Received: from mga04.intel.com ([192.55.52.120]:12253 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728182AbgFAVkZ (ORCPT ); Mon, 1 Jun 2020 17:40:25 -0400 IronPort-SDR: z8IuNLHPZvVL2m2yFgJmg+7Tb20prJHrfDUjA4gki/VpZD37kzpwu0i3Y4PT3V8e/kQNPpWD72 bhmGDnUmtr3A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 14:40:24 -0700 IronPort-SDR: VgXfb6U2XTqaiIxQec+3VLJOmXxCfX10MydJvZqZJ9Uc2tFJYHQfaOqxLazuZEf+hWo2qcN/jG TvV6jUr8NK/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,462,1583222400"; d="scan'208";a="257389245" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.25]) by orsmga007.jf.intel.com with ESMTP; 01 Jun 2020 14:40:23 -0700 Date: Mon, 1 Jun 2020 14:40:23 -0700 From: "Raj, Ashok" To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Bjorn Helgaas , Joerg Roedel , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Lu Baolu , Alex Williamson , Darrel Goeddel , Mark Scott , Romil Sharma , Ashok Raj Subject: Re: [PATCH] PCI: Relax ACS requirement for Intel RCiEP devices. Message-ID: <20200601214023.GA15310@otc-nc-03> References: <1590699462-7131-1-git-send-email-ashok.raj@intel.com> <20200601212519.GA758937@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200601212519.GA758937@bjorn-Precision-5520> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 04:25:19PM -0500, Bjorn Helgaas wrote: > On Thu, May 28, 2020 at 01:57:42PM -0700, Ashok Raj wrote: > > All Intel platforms guarantee that all root complex implementations > > must send transactions up to IOMMU for address translations. Hence for > > RCiEP devices that are Vendor ID Intel, can claim exception for lack of > > ACS support. > > > > > > 3.16 Root-Complex Peer to Peer Considerations > > When DMA remapping is enabled, peer-to-peer requests through the > > Root-Complex must be handled > > as follows: > > • The input address in the request is translated (through first-level, > > second-level or nested translation) to a host physical address (HPA). > > The address decoding for peer addresses must be done only on the > > translated HPA. Hardware implementations are free to further limit > > peer-to-peer accesses to specific host physical address regions > > (or to completely disallow peer-forwarding of translated requests). > > • Since address translation changes the contents (address field) of > > the PCI Express Transaction Layer Packet (TLP), for PCI Express > > peer-to-peer requests with ECRC, the Root-Complex hardware must use > > the new ECRC (re-computed with the translated address) if it > > decides to forward the TLP as a peer request. > > • Root-ports, and multi-function root-complex integrated endpoints, may > > support additional peerto-peer control features by supporting PCI Express > > Access Control Services (ACS) capability. Refer to ACS capability in > > PCI Express specifications for details. > > > > Since Linux didn't give special treatment to allow this exception, certain > > RCiEP MFD devices are getting grouped in a single iommu group. This > > doesn't permit a single device to be assigned to a guest for instance. > > > > In one vendor system: Device 14.x were grouped in a single IOMMU group. > > > > /sys/kernel/iommu_groups/5/devices/0000:00:14.0 > > /sys/kernel/iommu_groups/5/devices/0000:00:14.2 > > /sys/kernel/iommu_groups/5/devices/0000:00:14.3 > > > > After the patch: > > /sys/kernel/iommu_groups/5/devices/0000:00:14.0 > > /sys/kernel/iommu_groups/5/devices/0000:00:14.2 > > /sys/kernel/iommu_groups/6/devices/0000:00:14.3 <<< new group > > > > 14.0 and 14.2 are integrated devices, but legacy end points. > > Whereas 14.3 was a PCIe compliant RCiEP. > > > > 00:14.3 Network controller: Intel Corporation Device 9df0 (rev 30) > > Capabilities: [40] Express (v2) Root Complex Integrated Endpoint, MSI 00 > > > > This permits assigning this device to a guest VM. > > > > Fixes: f096c061f552 ("iommu: Rework iommu_group_get_for_pci_dev()") > > Signed-off-by: Ashok Raj > > To: Joerg Roedel > > To: Bjorn Helgaas > > Cc: linux-kernel@vger.kernel.org > > Cc: iommu@lists.linux-foundation.org > > Cc: Lu Baolu > > Cc: Alex Williamson > > Cc: Darrel Goeddel > > Cc: Mark Scott , > > Cc: Romil Sharma > > Cc: Ashok Raj > > Tentatively applied to pci/virtualization for v5.8, thanks! > > The spec says this handling must apply "when DMA remapping is > enabled". The patch does not check whether DMA remapping is enabled. > > Is there any case where DMA remapping is *not* enabled, and we rely on > this patch to tell us whether the device is isolated? It sounds like > it may give the wrong answer in such a case? > > Can you confirm that I don't need to worry about this? I think all of this makes sense only when DMA remapping is enabled. Otherwise there is no enforcement for isolation. Cheers, Ashok From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22DDEC433E0 for ; Mon, 1 Jun 2020 21:40:31 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C61EF206E2 for ; Mon, 1 Jun 2020 21:40:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C61EF206E2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id B9839859D9; Mon, 1 Jun 2020 21:40:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BycnRw85foFf; Mon, 1 Jun 2020 21:40:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 7B32B859D5; Mon, 1 Jun 2020 21:40:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 51068C088C; Mon, 1 Jun 2020 21:40:28 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 10F3CC0176 for ; Mon, 1 Jun 2020 21:40:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F10FF203BB for ; Mon, 1 Jun 2020 21:40:25 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oODtMvi8Sq6U for ; Mon, 1 Jun 2020 21:40:24 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by silver.osuosl.org (Postfix) with ESMTPS id A6F1E20134 for ; Mon, 1 Jun 2020 21:40:24 +0000 (UTC) IronPort-SDR: oNJY0JEG6NUm+OUw8L7xijgJtkL+M3U2ZzPIbAgukqrsPDs+kX77CXLKCgQ/8qDo5tXsDQ4xth fe7nGm1JT9og== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2020 14:40:24 -0700 IronPort-SDR: VgXfb6U2XTqaiIxQec+3VLJOmXxCfX10MydJvZqZJ9Uc2tFJYHQfaOqxLazuZEf+hWo2qcN/jG TvV6jUr8NK/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,462,1583222400"; d="scan'208";a="257389245" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.25]) by orsmga007.jf.intel.com with ESMTP; 01 Jun 2020 14:40:23 -0700 Date: Mon, 1 Jun 2020 14:40:23 -0700 From: "Raj, Ashok" To: Bjorn Helgaas Subject: Re: [PATCH] PCI: Relax ACS requirement for Intel RCiEP devices. Message-ID: <20200601214023.GA15310@otc-nc-03> References: <1590699462-7131-1-git-send-email-ashok.raj@intel.com> <20200601212519.GA758937@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200601212519.GA758937@bjorn-Precision-5520> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Alex Williamson , Ashok Raj , Darrel Goeddel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Mark Scott , Romil Sharma , Bjorn Helgaas X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gTW9uLCBKdW4gMDEsIDIwMjAgYXQgMDQ6MjU6MTlQTSAtMDUwMCwgQmpvcm4gSGVsZ2FhcyB3 cm90ZToKPiBPbiBUaHUsIE1heSAyOCwgMjAyMCBhdCAwMTo1Nzo0MlBNIC0wNzAwLCBBc2hvayBS YWogd3JvdGU6Cj4gPiBBbGwgSW50ZWwgcGxhdGZvcm1zIGd1YXJhbnRlZSB0aGF0IGFsbCByb290 IGNvbXBsZXggaW1wbGVtZW50YXRpb25zCj4gPiBtdXN0IHNlbmQgdHJhbnNhY3Rpb25zIHVwIHRv IElPTU1VIGZvciBhZGRyZXNzIHRyYW5zbGF0aW9ucy4gSGVuY2UgZm9yCj4gPiBSQ2lFUCBkZXZp Y2VzIHRoYXQgYXJlIFZlbmRvciBJRCBJbnRlbCwgY2FuIGNsYWltIGV4Y2VwdGlvbiBmb3IgbGFj ayBvZgo+ID4gQUNTIHN1cHBvcnQuCj4gPiAKPiA+IAo+ID4gMy4xNiBSb290LUNvbXBsZXggUGVl ciB0byBQZWVyIENvbnNpZGVyYXRpb25zCj4gPiBXaGVuIERNQSByZW1hcHBpbmcgaXMgZW5hYmxl ZCwgcGVlci10by1wZWVyIHJlcXVlc3RzIHRocm91Z2ggdGhlCj4gPiBSb290LUNvbXBsZXggbXVz dCBiZSBoYW5kbGVkCj4gPiBhcyBmb2xsb3dzOgo+ID4g4oCiIFRoZSBpbnB1dCBhZGRyZXNzIGlu IHRoZSByZXF1ZXN0IGlzIHRyYW5zbGF0ZWQgKHRocm91Z2ggZmlyc3QtbGV2ZWwsCj4gPiAgIHNl Y29uZC1sZXZlbCBvciBuZXN0ZWQgdHJhbnNsYXRpb24pIHRvIGEgaG9zdCBwaHlzaWNhbCBhZGRy ZXNzIChIUEEpLgo+ID4gICBUaGUgYWRkcmVzcyBkZWNvZGluZyBmb3IgcGVlciBhZGRyZXNzZXMg bXVzdCBiZSBkb25lIG9ubHkgb24gdGhlCj4gPiAgIHRyYW5zbGF0ZWQgSFBBLiBIYXJkd2FyZSBp bXBsZW1lbnRhdGlvbnMgYXJlIGZyZWUgdG8gZnVydGhlciBsaW1pdAo+ID4gICBwZWVyLXRvLXBl ZXIgYWNjZXNzZXMgdG8gc3BlY2lmaWMgaG9zdCBwaHlzaWNhbCBhZGRyZXNzIHJlZ2lvbnMKPiA+ ICAgKG9yIHRvIGNvbXBsZXRlbHkgZGlzYWxsb3cgcGVlci1mb3J3YXJkaW5nIG9mIHRyYW5zbGF0 ZWQgcmVxdWVzdHMpLgo+ID4g4oCiIFNpbmNlIGFkZHJlc3MgdHJhbnNsYXRpb24gY2hhbmdlcyB0 aGUgY29udGVudHMgKGFkZHJlc3MgZmllbGQpIG9mCj4gPiAgIHRoZSBQQ0kgRXhwcmVzcyBUcmFu c2FjdGlvbiBMYXllciBQYWNrZXQgKFRMUCksIGZvciBQQ0kgRXhwcmVzcwo+ID4gICBwZWVyLXRv LXBlZXIgcmVxdWVzdHMgd2l0aCBFQ1JDLCB0aGUgUm9vdC1Db21wbGV4IGhhcmR3YXJlIG11c3Qg dXNlCj4gPiAgIHRoZSBuZXcgRUNSQyAocmUtY29tcHV0ZWQgd2l0aCB0aGUgdHJhbnNsYXRlZCBh ZGRyZXNzKSBpZiBpdAo+ID4gICBkZWNpZGVzIHRvIGZvcndhcmQgdGhlIFRMUCBhcyBhIHBlZXIg cmVxdWVzdC4KPiA+IOKAoiBSb290LXBvcnRzLCBhbmQgbXVsdGktZnVuY3Rpb24gcm9vdC1jb21w bGV4IGludGVncmF0ZWQgZW5kcG9pbnRzLCBtYXkKPiA+ICAgc3VwcG9ydCBhZGRpdGlvbmFsIHBl ZXJ0by1wZWVyIGNvbnRyb2wgZmVhdHVyZXMgYnkgc3VwcG9ydGluZyBQQ0kgRXhwcmVzcwo+ID4g ICBBY2Nlc3MgQ29udHJvbCBTZXJ2aWNlcyAoQUNTKSBjYXBhYmlsaXR5LiBSZWZlciB0byBBQ1Mg Y2FwYWJpbGl0eSBpbgo+ID4gICBQQ0kgRXhwcmVzcyBzcGVjaWZpY2F0aW9ucyBmb3IgZGV0YWls cy4KPiA+IAo+ID4gU2luY2UgTGludXggZGlkbid0IGdpdmUgc3BlY2lhbCB0cmVhdG1lbnQgdG8g YWxsb3cgdGhpcyBleGNlcHRpb24sIGNlcnRhaW4KPiA+IFJDaUVQIE1GRCBkZXZpY2VzIGFyZSBn ZXR0aW5nIGdyb3VwZWQgaW4gYSBzaW5nbGUgaW9tbXUgZ3JvdXAuIFRoaXMKPiA+IGRvZXNuJ3Qg cGVybWl0IGEgc2luZ2xlIGRldmljZSB0byBiZSBhc3NpZ25lZCB0byBhIGd1ZXN0IGZvciBpbnN0 YW5jZS4KPiA+IAo+ID4gSW4gb25lIHZlbmRvciBzeXN0ZW06IERldmljZSAxNC54IHdlcmUgZ3Jv dXBlZCBpbiBhIHNpbmdsZSBJT01NVSBncm91cC4KPiA+IAo+ID4gL3N5cy9rZXJuZWwvaW9tbXVf Z3JvdXBzLzUvZGV2aWNlcy8wMDAwOjAwOjE0LjAKPiA+IC9zeXMva2VybmVsL2lvbW11X2dyb3Vw cy81L2RldmljZXMvMDAwMDowMDoxNC4yCj4gPiAvc3lzL2tlcm5lbC9pb21tdV9ncm91cHMvNS9k ZXZpY2VzLzAwMDA6MDA6MTQuMwo+ID4gCj4gPiBBZnRlciB0aGUgcGF0Y2g6Cj4gPiAvc3lzL2tl cm5lbC9pb21tdV9ncm91cHMvNS9kZXZpY2VzLzAwMDA6MDA6MTQuMAo+ID4gL3N5cy9rZXJuZWwv aW9tbXVfZ3JvdXBzLzUvZGV2aWNlcy8wMDAwOjAwOjE0LjIKPiA+IC9zeXMva2VybmVsL2lvbW11 X2dyb3Vwcy82L2RldmljZXMvMDAwMDowMDoxNC4zIDw8PCBuZXcgZ3JvdXAKPiA+IAo+ID4gMTQu MCBhbmQgMTQuMiBhcmUgaW50ZWdyYXRlZCBkZXZpY2VzLCBidXQgbGVnYWN5IGVuZCBwb2ludHMu Cj4gPiBXaGVyZWFzIDE0LjMgd2FzIGEgUENJZSBjb21wbGlhbnQgUkNpRVAuCj4gPiAKPiA+IDAw OjE0LjMgTmV0d29yayBjb250cm9sbGVyOiBJbnRlbCBDb3Jwb3JhdGlvbiBEZXZpY2UgOWRmMCAo cmV2IDMwKQo+ID4gQ2FwYWJpbGl0aWVzOiBbNDBdIEV4cHJlc3MgKHYyKSBSb290IENvbXBsZXgg SW50ZWdyYXRlZCBFbmRwb2ludCwgTVNJIDAwCj4gPiAKPiA+IFRoaXMgcGVybWl0cyBhc3NpZ25p bmcgdGhpcyBkZXZpY2UgdG8gYSBndWVzdCBWTS4KPiA+IAo+ID4gRml4ZXM6IGYwOTZjMDYxZjU1 MiAoImlvbW11OiBSZXdvcmsgaW9tbXVfZ3JvdXBfZ2V0X2Zvcl9wY2lfZGV2KCkiKQo+ID4gU2ln bmVkLW9mZi1ieTogQXNob2sgUmFqIDxhc2hvay5yYWpAaW50ZWwuY29tPgo+ID4gVG86IEpvZXJn IFJvZWRlbCA8am9yb0A4Ynl0ZXMub3JnPgo+ID4gVG86IEJqb3JuIEhlbGdhYXMgPGJoZWxnYWFz QGdvb2dsZS5jb20+Cj4gPiBDYzogbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZwo+ID4gQ2M6 IGlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCj4gPiBDYzogTHUgQmFvbHUgPGJhb2x1 Lmx1QGxpbnV4LmludGVsLmNvbT4KPiA+IENjOiBBbGV4IFdpbGxpYW1zb24gPGFsZXgud2lsbGlh bXNvbkByZWRoYXQuY29tPgo+ID4gQ2M6IERhcnJlbCBHb2VkZGVsIDxER29lZGRlbEBmb3JjZXBv aW50LmNvbT4KPiA+IENjOiBNYXJrIFNjb3R0IDxtc2NvdHRAZm9yY2Vwb2ludC5jb20+LAo+ID4g Q2M6IFJvbWlsIFNoYXJtYSA8cnNoYXJtYUBmb3JjZXBvaW50LmNvbT4KPiA+IENjOiBBc2hvayBS YWogPGFzaG9rLnJhakBpbnRlbC5jb20+Cj4gCj4gVGVudGF0aXZlbHkgYXBwbGllZCB0byBwY2kv dmlydHVhbGl6YXRpb24gZm9yIHY1LjgsIHRoYW5rcyEKPiAKPiBUaGUgc3BlYyBzYXlzIHRoaXMg aGFuZGxpbmcgbXVzdCBhcHBseSAid2hlbiBETUEgcmVtYXBwaW5nIGlzCj4gZW5hYmxlZCIuICBU aGUgcGF0Y2ggZG9lcyBub3QgY2hlY2sgd2hldGhlciBETUEgcmVtYXBwaW5nIGlzIGVuYWJsZWQu Cj4gCj4gSXMgdGhlcmUgYW55IGNhc2Ugd2hlcmUgRE1BIHJlbWFwcGluZyBpcyAqbm90KiBlbmFi bGVkLCBhbmQgd2UgcmVseSBvbgo+IHRoaXMgcGF0Y2ggdG8gdGVsbCB1cyB3aGV0aGVyIHRoZSBk ZXZpY2UgaXMgaXNvbGF0ZWQ/ICBJdCBzb3VuZHMgbGlrZQo+IGl0IG1heSBnaXZlIHRoZSB3cm9u ZyBhbnN3ZXIgaW4gc3VjaCBhIGNhc2U/Cj4gCj4gQ2FuIHlvdSBjb25maXJtIHRoYXQgSSBkb24n dCBuZWVkIHRvIHdvcnJ5IGFib3V0IHRoaXM/ICAKCkkgdGhpbmsgYWxsIG9mIHRoaXMgbWFrZXMg c2Vuc2Ugb25seSB3aGVuIERNQSByZW1hcHBpbmcgaXMgZW5hYmxlZC4KT3RoZXJ3aXNlIHRoZXJl IGlzIG5vIGVuZm9yY2VtZW50IGZvciBpc29sYXRpb24uIAoKQ2hlZXJzLApBc2hvawpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxp c3QKaW9tbXVAbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZv dW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU=