From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DBA7C433E0 for ; Tue, 2 Jun 2020 04:57:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C08C206C3 for ; Tue, 2 Jun 2020 04:57:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QNomdIK4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbgFBE5R (ORCPT ); Tue, 2 Jun 2020 00:57:17 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:34186 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725787AbgFBE5R (ORCPT ); Tue, 2 Jun 2020 00:57:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591073835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gchTFiwviKMDwZXWqMwug6HrHP15DUCH03zQ9j5rpHE=; b=QNomdIK4edcmvOp88JGarOW+guDXk1bgiB/uYsS3NDVmvReZQj+5P+ba+9+Pl/3Q6VVfnq /nMGrlR3bT70cClkPFpFtnHNLmbpUykh/2nM7CdFYAe/I1fOupxMOYfAqEpKb/4QSgZ7wa 7gFP6fqnfe9zp1I+T5FzQYuC/pLxxjg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-upBZ4SuAPCqwaM0RKp4-zA-1; Tue, 02 Jun 2020 00:56:59 -0400 X-MC-Unique: upBZ4SuAPCqwaM0RKp4-zA-1 Received: by mail-wr1-f70.google.com with SMTP id h6so882836wrx.4 for ; Mon, 01 Jun 2020 21:56:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gchTFiwviKMDwZXWqMwug6HrHP15DUCH03zQ9j5rpHE=; b=SsIPFs1EPT7g5oHw3dD7y1puASpuzplfQu/uj1V2lVFMNgsngM42W9GcYfkj6BTKjI xk92zsok7D/vwTgf2q7y45qQytmyOGsEpOcyssL50NotpWiVDCZ9ziahdTV7vw9fFfgt DF7sX5oPUo8MsiYMHqEru9rMeYvHX/RGtAmHGQepDBBK369PxbvwLqWX6oWVxF5NCwaK II+8DZagBe3iMO/83evCzSkRjpfKEBiXGt8jcp6qA9lOdkp6GFWovpON6g07B3ZU/w8U eW2Az6BxQM9kVk1bponp7OT661JCPph/pxqX41TAJcfPBcNUSFpMH0Gq6iOJDDymARXD lKJw== X-Gm-Message-State: AOAM530demljD709FDXlUQuVKxEMecowU+7nPE/Njrl/AutNRS5q0oV1 RPwh/1SMe6Hq/xM2TlPKZKRtN3pevnmG33ttcHeW8yTR5UXG0ylAQiWvgI+77671KiqVpuBNq7k 5bCppha8qUb4m1xkDplVwW4Sw X-Received: by 2002:a1c:ed0e:: with SMTP id l14mr2320507wmh.8.1591073818233; Mon, 01 Jun 2020 21:56:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwezYypzZbKEY1d6YwmBv/8PZj3UfnzO1aXl2q6kGlCaJNGq8F3H+NRcEoRO1KXyF9lWjuqqA== X-Received: by 2002:a1c:ed0e:: with SMTP id l14mr2320484wmh.8.1591073818026; Mon, 01 Jun 2020 21:56:58 -0700 (PDT) Received: from redhat.com (bzq-109-64-41-91.red.bezeqint.net. [109.64.41.91]) by smtp.gmail.com with ESMTPSA id x205sm1900586wmx.21.2020.06.01.21.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 21:56:57 -0700 (PDT) Date: Tue, 2 Jun 2020 00:56:54 -0400 From: "Michael S. Tsirkin" To: kbuild test robot Cc: Jason Wang , kbuild-all@lists.01.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rob.miller@broadcom.com, lingshan.zhu@intel.com, eperezma@redhat.com, lulu@redhat.com Subject: Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap Message-ID: <20200602005007-mutt-send-email-mst@kernel.org> References: <20200529080303.15449-5-jasowang@redhat.com> <202006020308.kLXTHt4n%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202006020308.kLXTHt4n%lkp@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wrote: > Hi Jason, > > I love your patch! Yet something to improve: > > [auto build test ERROR on vhost/linux-next] > [also build test ERROR on linus/master v5.7 next-20200529] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system. BTW, we also suggest to use '--base' option to specify the > base tree in git format-patch, please see https://stackoverflow.com/a/37406982] > > url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-doorbell-mapping/20200531-070834 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next > config: m68k-randconfig-r011-20200601 (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > > All errors (new ones prefixed by >>, old ones prefixed by <<): > > drivers/vhost/vdpa.c: In function 'vhost_vdpa_fault': > >> drivers/vhost/vdpa.c:754:22: error: implicit declaration of function 'pgprot_noncached' [-Werror=implicit-function-declaration] > 754 | vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > | ^~~~~~~~~~~~~~~~ > >> drivers/vhost/vdpa.c:754:22: error: incompatible types when assigning to type 'pgprot_t' {aka 'struct '} from type 'int' > cc1: some warnings being treated as errors > > vim +/pgprot_noncached +754 drivers/vhost/vdpa.c > > 742 > 743 static vm_fault_t vhost_vdpa_fault(struct vm_fault *vmf) > 744 { > 745 struct vhost_vdpa *v = vmf->vma->vm_file->private_data; > 746 struct vdpa_device *vdpa = v->vdpa; > 747 const struct vdpa_config_ops *ops = vdpa->config; > 748 struct vdpa_notification_area notify; > 749 struct vm_area_struct *vma = vmf->vma; > 750 u16 index = vma->vm_pgoff; > 751 > 752 notify = ops->get_vq_notification(vdpa, index); > 753 > > 754 vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > 755 if (remap_pfn_range(vma, vmf->address & PAGE_MASK, > 756 notify.addr >> PAGE_SHIFT, PAGE_SIZE, > 757 vma->vm_page_prot)) > 758 return VM_FAULT_SIGBUS; > 759 > 760 return VM_FAULT_NOPAGE; > 761 } > 762 Yes well, all this remapping clearly has no chance to work on systems without CONFIG_MMU. > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4652880575178898324==" MIME-Version: 1.0 From: Michael S. Tsirkin To: kbuild-all@lists.01.org Subject: Re: [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap Date: Tue, 02 Jun 2020 00:56:54 -0400 Message-ID: <20200602005007-mutt-send-email-mst@kernel.org> In-Reply-To: <202006020308.kLXTHt4n%lkp@intel.com> List-Id: --===============4652880575178898324== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Jun 02, 2020 at 03:22:49AM +0800, kbuild test robot wrote: > Hi Jason, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on vhost/linux-next] > [also build test ERROR on linus/master v5.7 next-20200529] > [if your patch is applied to the wrong git tree, please drop us a note to= help > improve the system. BTW, we also suggest to use '--base' option to specif= y the > base tree in git format-patch, please see https://stackoverflow.com/a/374= 06982] > = > url: https://github.com/0day-ci/linux/commits/Jason-Wang/vDPA-doorbell= -mapping/20200531-070834 > base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git lin= ux-next > config: m68k-randconfig-r011-20200601 (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros= s ARCH=3Dm68k = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kbuild test robot > = > All errors (new ones prefixed by >>, old ones prefixed by <<): > = > drivers/vhost/vdpa.c: In function 'vhost_vdpa_fault': > >> drivers/vhost/vdpa.c:754:22: error: implicit declaration of function '= pgprot_noncached' [-Werror=3Dimplicit-function-declaration] > 754 | vma->vm_page_prot =3D pgprot_noncached(vma->vm_page_prot); > | ^~~~~~~~~~~~~~~~ > >> drivers/vhost/vdpa.c:754:22: error: incompatible types when assigning = to type 'pgprot_t' {aka 'struct '} from type 'int' > cc1: some warnings being treated as errors > = > vim +/pgprot_noncached +754 drivers/vhost/vdpa.c > = > 742 = > 743 static vm_fault_t vhost_vdpa_fault(struct vm_fault *vmf) > 744 { > 745 struct vhost_vdpa *v =3D vmf->vma->vm_file->private_data; > 746 struct vdpa_device *vdpa =3D v->vdpa; > 747 const struct vdpa_config_ops *ops =3D vdpa->config; > 748 struct vdpa_notification_area notify; > 749 struct vm_area_struct *vma =3D vmf->vma; > 750 u16 index =3D vma->vm_pgoff; > 751 = > 752 notify =3D ops->get_vq_notification(vdpa, index); > 753 = > > 754 vma->vm_page_prot =3D pgprot_noncached(vma->vm_page_prot); > 755 if (remap_pfn_range(vma, vmf->address & PAGE_MASK, > 756 notify.addr >> PAGE_SHIFT, PAGE_SIZE, > 757 vma->vm_page_prot)) > 758 return VM_FAULT_SIGBUS; > 759 = > 760 return VM_FAULT_NOPAGE; > 761 } > 762 = Yes well, all this remapping clearly has no chance to work on systems without CONFIG_MMU. > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============4652880575178898324==--