From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Tue, 02 Jun 2020 07:14:07 +0000 Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Message-Id: <20200602071407.GB16602@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit List-Id: References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> In-Reply-To: To: Sumit Garg Cc: "tee-dev @ lists . linaro . org" , Daniel Thompson , op-tee@lists.trustedfirmware.org, Jonathan Corbet , James Bottomley , Janne Karhunen , Linux Doc Mailing List , James Morris , Mimi Zohar , Linux Kernel Mailing List , dhowells@redhat.com, linux-security-module@vger.kernel.org, "open list:ASYMMETRIC KEYS" , Markus Wamser , Casey Schaufler , linux-integrity@vger.kernel.org, Jens Wiklander , linux-arm-kernel , "Serge E. Hallyn" On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > The whole idea to have it dynamic was to have a common trusted keys > module which could support both TPM and TEE implementation depending > on hardware. I guess it may be useful in scenarios where a particular > hardware supports a TPM chip while other doesn't but both need to run > a common kernel image. For now it should only scale to what is needed. No problems refining it later when there is something to enable. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49E77C433E1 for ; Tue, 2 Jun 2020 07:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32F8C20734 for ; Tue, 2 Jun 2020 07:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726404AbgFBHOO (ORCPT ); Tue, 2 Jun 2020 03:14:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:36684 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgFBHOO (ORCPT ); Tue, 2 Jun 2020 03:14:14 -0400 IronPort-SDR: prdJ3G2od+mYzF60Lp5gmCmarEdKcogx96PiHq0jbVeni4hWpV+2h87N3tog9yWCRndsKld6pA j/7vmeGmr06Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 00:14:13 -0700 IronPort-SDR: coLgcfUzY1r0gMPZ3I7pF0lKRrgzpKRDvFxeMYNrhrx/osJaKh2dTYlvhflgsEOUyu4HtKmEfI lFu58/twi4ZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,463,1583222400"; d="scan'208";a="286546847" Received: from unknown (HELO localhost) ([10.252.59.102]) by orsmga002.jf.intel.com with ESMTP; 02 Jun 2020 00:14:08 -0700 Date: Tue, 2 Jun 2020 10:14:07 +0300 From: Jarkko Sakkinen To: Sumit Garg Cc: Mimi Zohar , James Bottomley , dhowells@redhat.com, Jens Wiklander , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Casey Schaufler , Janne Karhunen , Daniel Thompson , Markus Wamser , "open list:ASYMMETRIC KEYS" , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux Doc Mailing List , Linux Kernel Mailing List , linux-arm-kernel , op-tee@lists.trustedfirmware.org, "tee-dev @ lists . linaro . org" Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Message-ID: <20200602071407.GB16602@linux.intel.com> References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > The whole idea to have it dynamic was to have a common trusted keys > module which could support both TPM and TEE implementation depending > on hardware. I guess it may be useful in scenarios where a particular > hardware supports a TPM chip while other doesn't but both need to run > a common kernel image. For now it should only scale to what is needed. No problems refining it later when there is something to enable. /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559C2C433E0 for ; Tue, 2 Jun 2020 07:14:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29AE620734 for ; Tue, 2 Jun 2020 07:14:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ts5XzDfq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29AE620734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o6s3Uf5fK+4coMHuMOLDB3MAJDQiDsSrmH5CUWSQBYg=; b=ts5XzDfqvndZvE A2pcxCUAblTTjIyrhGD7RscYm515h7DYdlvEWDqvvf6AaTvMOACVrkWTRNoxJGRhElVAqJVLmb5az /AkciXJJw0uIOWJqegdPD46l6WtpOFy/0yjiIPWS6VVRZI/iIYF71CLrqT9mllDyLJCjp4yme35vS iqu17WSUHo8+V2HxqfmSvafomqWP9AG6gwYfer5weWCR02RhBQ3L6NAJ3d3wGo9QgoWU08NiAyphv /PjBT55I08ruydBvx5401PmddnxciFvf9HGXMzNS+juyFgXf+GoO6b35Sd0o+59LzJ+DsvBVzme14 4AwLBFCrdLxp07oJ3HEA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg17q-0006Gz-OU; Tue, 02 Jun 2020 07:14:18 +0000 Received: from mga03.intel.com ([134.134.136.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg17o-0006G0-9f for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2020 07:14:17 +0000 IronPort-SDR: 2CTkDNvC+DofruVm6OtA+QN6KPpl7ohJmF60IDTMESai2TlGtxj5hiEdQ352RXvo9NHHnJ2xcQ jQaCAP+T2SAg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 00:14:13 -0700 IronPort-SDR: coLgcfUzY1r0gMPZ3I7pF0lKRrgzpKRDvFxeMYNrhrx/osJaKh2dTYlvhflgsEOUyu4HtKmEfI lFu58/twi4ZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,463,1583222400"; d="scan'208";a="286546847" Received: from unknown (HELO localhost) ([10.252.59.102]) by orsmga002.jf.intel.com with ESMTP; 02 Jun 2020 00:14:08 -0700 Date: Tue, 2 Jun 2020 10:14:07 +0300 From: Jarkko Sakkinen To: Sumit Garg Subject: Re: [PATCH v4 1/4] KEYS: trusted: Add generic trusted keys framework Message-ID: <20200602071407.GB16602@linux.intel.com> References: <1588758017-30426-1-git-send-email-sumit.garg@linaro.org> <1588758017-30426-2-git-send-email-sumit.garg@linaro.org> <20200601021132.GA796225@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_001416_399394_76545BEB X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "tee-dev @ lists . linaro . org" , Daniel Thompson , op-tee@lists.trustedfirmware.org, Jonathan Corbet , James Bottomley , Janne Karhunen , Linux Doc Mailing List , James Morris , Mimi Zohar , Linux Kernel Mailing List , dhowells@redhat.com, linux-security-module@vger.kernel.org, "open list:ASYMMETRIC KEYS" , Markus Wamser , Casey Schaufler , linux-integrity@vger.kernel.org, Jens Wiklander , linux-arm-kernel , "Serge E. Hallyn" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 01, 2020 at 02:41:55PM +0530, Sumit Garg wrote: > > This, I think is wrong. You should have a compile time flag for TPM e.g. > > CONFIG_TRUSTED_TPM, not this dynamic mess. > > > > The whole idea to have it dynamic was to have a common trusted keys > module which could support both TPM and TEE implementation depending > on hardware. I guess it may be useful in scenarios where a particular > hardware supports a TPM chip while other doesn't but both need to run > a common kernel image. For now it should only scale to what is needed. No problems refining it later when there is something to enable. /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel