Re: [meta-arm] [PATCH v2] arm-toolchain: merge binary toolchain recipes

["Jon Mason" <jdmason@kudzu.us>]

On Mon, Jun 01, 2020 at 11:57:39PM -0700, Diego Sueiro wrote:
> 
> > diff --git
> > a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> > b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> > new file mode 100644
> > index 0000000..332ffab
> > --- /dev/null
> > +++
> > b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-x86host.inc
> > @@ -0,0 +1,26 @@
> > +S = "${WORKDIR}/${BPN}-${PV}"
> 
> As @Ross mentioned, this is already the default value for the S variable.

I still saw it in the Poky tree.  So, I thought it okay to keep in.
See meta/recipes-extended/logrotate/logrotate_3.16.0.bb:S = "${WORKDIR}/${BPN}-${PV}"

I'll remove it and do a v3.

Thanks,
Jon

> 
> > +
> > +COMPATIBLE_HOST = "x86_64.*-linux"
> > +
> > +FILES_${PN} = "${datadir} ${bindir}"
> > +
> > +BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
> > +
> > +do_install() {
> > +    install -d ${D}${datadir}/${BINNAME}/
> > +    cp -r ${S}/. ${D}${datadir}/
> > +
> > +    install -d ${D}${bindir}
> > +    # Symlink all executables into bindir
> > +    for f in ${D}${datadir}/${BINNAME}/bin/${BINNAME}-*; do
> > +        lnr $f ${D}${bindir}/$(basename $f)
> > +    done
> > +}
> > +
> > +INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
> > +
> > +INHIBIT_SYSROOT_STRIP = "1"
> > +INHIBIT_PACKAGE_STRIP = "1"
> > +INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> > +
> > +BBCLASSEXTEND = "native nativesdk"
> > -- 
> > 2.20.1
> > 
> >

>