From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44460C433E0 for ; Tue, 2 Jun 2020 19:16:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC18E20734 for ; Tue, 2 Jun 2020 19:16:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bFgEHrh4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC18E20734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A7A980007; Tue, 2 Jun 2020 15:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358338E0006; Tue, 2 Jun 2020 15:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26D0680007; Tue, 2 Jun 2020 15:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 0E4BC8E0006 for ; Tue, 2 Jun 2020 15:16:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B7CC5181AEF10 for ; Tue, 2 Jun 2020 19:16:22 +0000 (UTC) X-FDA: 76885227804.07.burst14_379dd2a64565a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 7E9A61803F9AE for ; Tue, 2 Jun 2020 19:16:22 +0000 (UTC) X-HE-Tag: burst14_379dd2a64565a X-Filterd-Recvd-Size: 2354 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 19:16:22 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E84AA206E2; Tue, 2 Jun 2020 19:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591125381; bh=rSpyzAIY1EeQ0Wb/pF/MqYcrF+iIM/+fhneT4tmjRh8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bFgEHrh494Isxe5qOQqa5MaEknsSdcfYWqwp3RP5jn3qw8KV2CpStVKWB1RZVCfXm u17Eecjtmr+cAXqBR9CylbHosoORyB/6APQd7HoPphG5ToP9pkLwMjLS4hOlXUFFz5 HCVqr3qAKiqgXIPHzZv9eJR00CKB1DcpIPpklF80= Date: Tue, 2 Jun 2020 12:16:20 -0700 From: Andrew Morton To: Daniel Axtens Cc: kbuild test robot , kbuild-all@lists.01.org, Johannes Weiner , Dmitry Vyukov , Linux Memory Management List Subject: Re: [hnaz-linux-mm:master 169/698] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy' Message-Id: <20200602121620.257a40752a9ce475d8a2c6c8@linux-foundation.org> In-Reply-To: <87r1uyyptc.fsf@dja-thinkpad.axtens.net> References: <202005301819.G4uARaFJ%lkp@intel.com> <20200601180455.1a2f38368da33c7a0bb8d6fb@linux-foundation.org> <87wo4qywp4.fsf@dja-thinkpad.axtens.net> <87tuzuyvgt.fsf@dja-thinkpad.axtens.net> <87r1uyyptc.fsf@dja-thinkpad.axtens.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 7E9A61803F9AE X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 02 Jun 2020 15:55:27 +1000 Daniel Axtens wrote: > Huh, turns out that we do actually see a similar set of warnings before > and after this patch, they're just different warnings as a consequence > of my patch. Ah. > Given that these warnings only show up at W=1, is there any point in > further supressing them? I guess not. So what should we do? Go over the various sites and use memcpy(), each with a suitably apologetic code comment explaining the reason? From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1602259096650280678==" MIME-Version: 1.0 From: Andrew Morton To: kbuild-all@lists.01.org Subject: Re: [hnaz-linux-mm:master 169/698] include/linux/string.h:307:9: note: in expansion of macro '__underlying_strncpy' Date: Tue, 02 Jun 2020 12:16:20 -0700 Message-ID: <20200602121620.257a40752a9ce475d8a2c6c8@linux-foundation.org> In-Reply-To: <87r1uyyptc.fsf@dja-thinkpad.axtens.net> List-Id: --===============1602259096650280678== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, 02 Jun 2020 15:55:27 +1000 Daniel Axtens wrote: > Huh, turns out that we do actually see a similar set of warnings before > and after this patch, they're just different warnings as a consequence > of my patch. Ah. = > Given that these warnings only show up at W=3D1, is there any point in > further supressing them? I guess not. So what should we do? Go over the various sites and use memcpy(), each with a suitably apologetic code comment explaining the reason? --===============1602259096650280678==--