From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C04C433DF for ; Tue, 2 Jun 2020 12:52:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E124206A4 for ; Tue, 2 Jun 2020 12:52:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="f45OZi6d"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BV685FeE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726853AbgFBMwc (ORCPT ); Tue, 2 Jun 2020 08:52:32 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49817 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725940AbgFBMwb (ORCPT ); Tue, 2 Jun 2020 08:52:31 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 333E85C0060; Tue, 2 Jun 2020 08:52:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 02 Jun 2020 08:52:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=WDq+umCpTeMy9k3W0/Wp/zsjIGB wGG2fZVoUDuvc/6I=; b=f45OZi6d+1yiR3+fuUjVx/OffyBQzXpKlPQbYfJ2G3K JbM0gya4DR68naiFqT2uxODNVG5DStLzdE0iZ0Hnzxalrq2wgoa/aOXT4CymRy1o wmlS4dGmwPT3KP/RICQd1ql2qMZepWk1XPNZ3QnD7p3P5wzq618XIg9N+hZsTfNA /Pr3d6A/XzFKIFLxaADMbIIVVCjUC1SV0wuzNUvMN40DDoDN1UIfl07lvtYIpqbC m9WK5McK+v9DLGrh7eQaiL4t8K0EVgAUPABhuctzK69htNR4z3RvbvlyQrKNenkX sshBlFSNkun213PiCHeWnXf9bfPEEPiexjX5dOiOeng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=WDq+um CpTeMy9k3W0/Wp/zsjIGBwGG2fZVoUDuvc/6I=; b=BV685FeEEZTDO3F+XTXwxI 2oE5GEcg0f7mM0Xy3W9x6iJ4YgMAPeOCwXEhZ/oAKIBLr7G5KoT9O8zlYS/+IX/C njwsrJSZ1aofL9UDyXcM7T69/UBQRoRRoHvgqDD/ZX4m1YMiYQZl8J+97TvvNgXE Wcb5s8xAA3VM25x17aAKG6VCjAKSefFKXAFpdSYYRjFJ7pR8CHGDlz/wlIij4kVP q0nF2WqzdaUFSgDw6+li7l1wnI4tsCwQ34Z3bZ8eCI7d7VaumCmJWJvVZqB5TY0I y31iE0eqEk6RLDbCFQucAqdpR0agta7mzml3QMtrfToY9xQ7uoR8rS9yzzl/YSRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefjedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 027DA3060FE7; Tue, 2 Jun 2020 08:52:29 -0400 (EDT) Date: Tue, 2 Jun 2020 14:52:27 +0200 From: Maxime Ripard To: Eric Anholt Cc: Nicolas Saenz Julienne , DRI Development , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset Message-ID: <20200602125227.fe3mt5jnqd6u4pft@gilmour> References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ne6yctwhuf4mmo4i" Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ne6yctwhuf4mmo4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Eric, On Wed, May 27, 2020 at 09:33:44AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > > > In order to prevent timeouts and stalls in the pipeline, the core clock > > needs to be maxed at 500MHz during a modeset on the BCM2711. >=20 > Like, the whole system's core clock? Yep, unfortunately... > How is it reasonable for some device driver to crank the system's core > clock up and back down to some fixed-in-the-driver frequency? Sounds > like you need some sort of opp thing here. That frequency is the minimum rate of that clock. However, since other devices have similar requirements (unicam in particular) with different minimum requirements, we will switch to setting a minimum rate instead of enforcing a particular rate, so that patch would be essentially s/clk_set_rate/clk_set_min_rate/. Would that work for you? >=20 > Patch 13,14 r-b. Thanks! Maxime --ne6yctwhuf4mmo4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXtZLiwAKCRDj7w1vZxhR xVPmAP45n0n/bXaKZ1yE75klsmfyLSQrkPVnggB8TOLcoVWvXgEAoQBVPj7GmkAB XoSEMSgX4zgK/n0fW6bptMqt4QaM1gc= =P3EF -----END PGP SIGNATURE----- --ne6yctwhuf4mmo4i-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26609C433DF for ; Tue, 2 Jun 2020 12:52:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D625C20663 for ; Tue, 2 Jun 2020 12:52:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="auq1PLkz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="f45OZi6d"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BV685FeE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D625C20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hVvuHP9wG8+Y1dgeHxL38+BxiHhE6DZe7cwAaejyEdc=; b=auq1PLkzBjg7tLyrQNvbu0qaV jChaUD2JOyJzB6scxDNoC91GQt5uBtJbAMZ6qQ1JRjbItnleXpGEfljyUWdZyqIRctnk/gkLbqWof HVkJenYY4F2N99bhyCsFvBv2b1w+Uhs8didtTXY5jCrGGXnF9Lry3X+j59IeLUq/Y0/8wsh5BIEXA JoqWnpNHhKiwuQYEtqxRwAuBV4mrdmiRVKerg9fA0OXnGe0PVeJrAfof89rcFtVrhaIvpgH3dWuqe aZMog9VYhZfwDucjPcKcuIfHVCgJH85LDyiQrML/K3CiB4WuH64AgIhKTOWljFatzsiQ0ojRIbWVy q8aqNC0Kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg6PK-0003t1-A2; Tue, 02 Jun 2020 12:52:42 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg6PG-0003rx-Ae; Tue, 02 Jun 2020 12:52:39 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 333E85C0060; Tue, 2 Jun 2020 08:52:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 02 Jun 2020 08:52:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=WDq+umCpTeMy9k3W0/Wp/zsjIGB wGG2fZVoUDuvc/6I=; b=f45OZi6d+1yiR3+fuUjVx/OffyBQzXpKlPQbYfJ2G3K JbM0gya4DR68naiFqT2uxODNVG5DStLzdE0iZ0Hnzxalrq2wgoa/aOXT4CymRy1o wmlS4dGmwPT3KP/RICQd1ql2qMZepWk1XPNZ3QnD7p3P5wzq618XIg9N+hZsTfNA /Pr3d6A/XzFKIFLxaADMbIIVVCjUC1SV0wuzNUvMN40DDoDN1UIfl07lvtYIpqbC m9WK5McK+v9DLGrh7eQaiL4t8K0EVgAUPABhuctzK69htNR4z3RvbvlyQrKNenkX sshBlFSNkun213PiCHeWnXf9bfPEEPiexjX5dOiOeng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=WDq+um CpTeMy9k3W0/Wp/zsjIGBwGG2fZVoUDuvc/6I=; b=BV685FeEEZTDO3F+XTXwxI 2oE5GEcg0f7mM0Xy3W9x6iJ4YgMAPeOCwXEhZ/oAKIBLr7G5KoT9O8zlYS/+IX/C njwsrJSZ1aofL9UDyXcM7T69/UBQRoRRoHvgqDD/ZX4m1YMiYQZl8J+97TvvNgXE Wcb5s8xAA3VM25x17aAKG6VCjAKSefFKXAFpdSYYRjFJ7pR8CHGDlz/wlIij4kVP q0nF2WqzdaUFSgDw6+li7l1wnI4tsCwQ34Z3bZ8eCI7d7VaumCmJWJvVZqB5TY0I y31iE0eqEk6RLDbCFQucAqdpR0agta7mzml3QMtrfToY9xQ7uoR8rS9yzzl/YSRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefjedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 027DA3060FE7; Tue, 2 Jun 2020 08:52:29 -0400 (EDT) Date: Tue, 2 Jun 2020 14:52:27 +0200 From: Maxime Ripard To: Eric Anholt Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset Message-ID: <20200602125227.fe3mt5jnqd6u4pft@gilmour> References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_055238_503618_125EA222 X-CRM114-Status: UNSURE ( 9.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0443497554330074745==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0443497554330074745== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ne6yctwhuf4mmo4i" Content-Disposition: inline --ne6yctwhuf4mmo4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Eric, On Wed, May 27, 2020 at 09:33:44AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > > > In order to prevent timeouts and stalls in the pipeline, the core clock > > needs to be maxed at 500MHz during a modeset on the BCM2711. >=20 > Like, the whole system's core clock? Yep, unfortunately... > How is it reasonable for some device driver to crank the system's core > clock up and back down to some fixed-in-the-driver frequency? Sounds > like you need some sort of opp thing here. That frequency is the minimum rate of that clock. However, since other devices have similar requirements (unicam in particular) with different minimum requirements, we will switch to setting a minimum rate instead of enforcing a particular rate, so that patch would be essentially s/clk_set_rate/clk_set_min_rate/. Would that work for you? >=20 > Patch 13,14 r-b. Thanks! Maxime --ne6yctwhuf4mmo4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXtZLiwAKCRDj7w1vZxhR xVPmAP45n0n/bXaKZ1yE75klsmfyLSQrkPVnggB8TOLcoVWvXgEAoQBVPj7GmkAB XoSEMSgX4zgK/n0fW6bptMqt4QaM1gc= =P3EF -----END PGP SIGNATURE----- --ne6yctwhuf4mmo4i-- --===============0443497554330074745== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0443497554330074745==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EC3C433DF for ; Wed, 3 Jun 2020 07:04:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99AFB20674 for ; Wed, 3 Jun 2020 07:04:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="f45OZi6d"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="BV685FeE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99AFB20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05FF16E4D4; Wed, 3 Jun 2020 07:04:36 +0000 (UTC) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by gabe.freedesktop.org (Postfix) with ESMTPS id D4D386E145 for ; Tue, 2 Jun 2020 12:52:32 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 333E85C0060; Tue, 2 Jun 2020 08:52:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 02 Jun 2020 08:52:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=WDq+umCpTeMy9k3W0/Wp/zsjIGB wGG2fZVoUDuvc/6I=; b=f45OZi6d+1yiR3+fuUjVx/OffyBQzXpKlPQbYfJ2G3K JbM0gya4DR68naiFqT2uxODNVG5DStLzdE0iZ0Hnzxalrq2wgoa/aOXT4CymRy1o wmlS4dGmwPT3KP/RICQd1ql2qMZepWk1XPNZ3QnD7p3P5wzq618XIg9N+hZsTfNA /Pr3d6A/XzFKIFLxaADMbIIVVCjUC1SV0wuzNUvMN40DDoDN1UIfl07lvtYIpqbC m9WK5McK+v9DLGrh7eQaiL4t8K0EVgAUPABhuctzK69htNR4z3RvbvlyQrKNenkX sshBlFSNkun213PiCHeWnXf9bfPEEPiexjX5dOiOeng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=WDq+um CpTeMy9k3W0/Wp/zsjIGBwGG2fZVoUDuvc/6I=; b=BV685FeEEZTDO3F+XTXwxI 2oE5GEcg0f7mM0Xy3W9x6iJ4YgMAPeOCwXEhZ/oAKIBLr7G5KoT9O8zlYS/+IX/C njwsrJSZ1aofL9UDyXcM7T69/UBQRoRRoHvgqDD/ZX4m1YMiYQZl8J+97TvvNgXE Wcb5s8xAA3VM25x17aAKG6VCjAKSefFKXAFpdSYYRjFJ7pR8CHGDlz/wlIij4kVP q0nF2WqzdaUFSgDw6+li7l1wnI4tsCwQ34Z3bZ8eCI7d7VaumCmJWJvVZqB5TY0I y31iE0eqEk6RLDbCFQucAqdpR0agta7mzml3QMtrfToY9xQ7uoR8rS9yzzl/YSRA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudefjedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecukfhppeeltddrkeelrdeikedrjeeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 027DA3060FE7; Tue, 2 Jun 2020 08:52:29 -0400 (EDT) Date: Tue, 2 Jun 2020 14:52:27 +0200 From: Maxime Ripard To: Eric Anholt Subject: Re: [PATCH v3 015/105] drm/vc4: hvs: Boost the core clock during modeset Message-ID: <20200602125227.fe3mt5jnqd6u4pft@gilmour> References: <1aaadf9a5176591c891622cb00b0c50f42e569dc.1590594512.git-series.maxime@cerno.tech> MIME-Version: 1.0 In-Reply-To: X-Mailman-Approved-At: Wed, 03 Jun 2020 07:04:29 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============0005774741==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0005774741== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ne6yctwhuf4mmo4i" Content-Disposition: inline --ne6yctwhuf4mmo4i Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Eric, On Wed, May 27, 2020 at 09:33:44AM -0700, Eric Anholt wrote: > On Wed, May 27, 2020 at 8:49 AM Maxime Ripard wrote: > > > > In order to prevent timeouts and stalls in the pipeline, the core clock > > needs to be maxed at 500MHz during a modeset on the BCM2711. >=20 > Like, the whole system's core clock? Yep, unfortunately... > How is it reasonable for some device driver to crank the system's core > clock up and back down to some fixed-in-the-driver frequency? Sounds > like you need some sort of opp thing here. That frequency is the minimum rate of that clock. However, since other devices have similar requirements (unicam in particular) with different minimum requirements, we will switch to setting a minimum rate instead of enforcing a particular rate, so that patch would be essentially s/clk_set_rate/clk_set_min_rate/. Would that work for you? >=20 > Patch 13,14 r-b. Thanks! Maxime --ne6yctwhuf4mmo4i Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXtZLiwAKCRDj7w1vZxhR xVPmAP45n0n/bXaKZ1yE75klsmfyLSQrkPVnggB8TOLcoVWvXgEAoQBVPj7GmkAB XoSEMSgX4zgK/n0fW6bptMqt4QaM1gc= =P3EF -----END PGP SIGNATURE----- --ne6yctwhuf4mmo4i-- --===============0005774741== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0005774741==--