From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FD3C433E0 for ; Wed, 3 Jun 2020 13:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9868C20772 for ; Wed, 3 Jun 2020 13:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725973AbgFCNHy (ORCPT ); Wed, 3 Jun 2020 09:07:54 -0400 Received: from verein.lst.de ([213.95.11.211]:50731 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgFCNHy (ORCPT ); Wed, 3 Jun 2020 09:07:54 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id DC1ED68BEB; Wed, 3 Jun 2020 15:07:50 +0200 (CEST) Date: Wed, 3 Jun 2020 15:07:50 +0200 From: Christoph Hellwig To: Dakshaja Uppalapati Cc: eduard@hasenleithner.at, kbusch@kernel.org, sagi@grimberg.me, hch@lst.de, gregkh@linuxfoundation.org, nirranjan@chelsio.com, bharat@chelsio.com, stable Subject: Re: [PATCH nvme] nvme: Revert "nvme: Discard workaround for non-conformant devices" Message-ID: <20200603130750.GA13511@lst.de> References: <20200603091851.16957-1-dakshaja@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200603091851.16957-1-dakshaja@chelsio.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jun 03, 2020 at 02:48:51PM +0530, Dakshaja Uppalapati wrote: > This reverts upstream 'commit 530436c45ef2 > ("nvme: Discard workaround for non-conformant devices")' > > Since commit `530436c45ef2` introduced a regression due to which > blk_update_request IO error is observed on formatting device, reverting it. Err, why? Please send an actual bug report with details of your setup.