All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Rob Clark <robdclark@gmail.com>,
	linux-arm-msm@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge
Date: Thu, 4 Jun 2020 12:55:48 +0530	[thread overview]
Message-ID: <20200604072548.GE3521@vkoul-mobl> (raw)
In-Reply-To: <20200528015205.GE4670@pendragon.ideasonboard.com>

Hi Laurent,

On 28-05-20, 04:52, Laurent Pinchart wrote:

> > +static int lt9611_bridge_attach(struct drm_bridge *bridge,
> > +				enum drm_bridge_attach_flags flags)
> > +{
> > +	struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
> > +	int ret;
> > +
> > +	dev_dbg(lt9611->dev, "bridge attach\n");
> 
> 
> Connector creation in bridge drivers is deprecated. Please at least add

Okay what is the right way for connector creation? I can add support for
that.

> support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, to make connector
> creation optional. Ideally the !DRM_BRIDGE_ATTACH_NO_CONNECTOR case

will add that

> should not be implemented at all. This will require the display
> controller driver to use DRM_BRIDGE_ATTACH_NO_CONNECTOR. Which display
> controller(s) do you use this driver with ?

I am using with msm display driver, this was tested on dragon-board
db845c board.

Thanks
-- 
~Vinod

WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org,
	Jernej Skrabec <jernej.skrabec@siol.net>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge
Date: Thu, 4 Jun 2020 12:55:48 +0530	[thread overview]
Message-ID: <20200604072548.GE3521@vkoul-mobl> (raw)
In-Reply-To: <20200528015205.GE4670@pendragon.ideasonboard.com>

Hi Laurent,

On 28-05-20, 04:52, Laurent Pinchart wrote:

> > +static int lt9611_bridge_attach(struct drm_bridge *bridge,
> > +				enum drm_bridge_attach_flags flags)
> > +{
> > +	struct lt9611 *lt9611 = bridge_to_lt9611(bridge);
> > +	int ret;
> > +
> > +	dev_dbg(lt9611->dev, "bridge attach\n");
> 
> 
> Connector creation in bridge drivers is deprecated. Please at least add

Okay what is the right way for connector creation? I can add support for
that.

> support for the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, to make connector
> creation optional. Ideally the !DRM_BRIDGE_ATTACH_NO_CONNECTOR case

will add that

> should not be implemented at all. This will require the display
> controller driver to use DRM_BRIDGE_ATTACH_NO_CONNECTOR. Which display
> controller(s) do you use this driver with ?

I am using with msm display driver, this was tested on dragon-board
db845c board.

Thanks
-- 
~Vinod
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-04  7:25 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 10:05 [PATCH 0/3] Add LT9611 DSI to HDMI bridge Vinod Koul
2020-05-13 10:05 ` Vinod Koul
2020-05-13 10:05 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Lontium vendor prefix Vinod Koul
2020-05-13 10:05   ` Vinod Koul
2020-05-28  1:34   ` Rob Herring
2020-05-28  1:34     ` Rob Herring
2020-05-13 10:05 ` [PATCH 2/3] dt-bindings: display: bridge: Add documentation for LT9611 Vinod Koul
2020-05-13 10:05   ` Vinod Koul
2020-05-28  1:37   ` Rob Herring
2020-05-28  1:37     ` Rob Herring
2020-05-28  1:48   ` Laurent Pinchart
2020-05-28  1:48     ` Laurent Pinchart
2020-06-04  7:18     ` Vinod Koul
2020-06-04  7:18       ` Vinod Koul
2020-06-04  7:29       ` Laurent Pinchart
2020-06-04  7:29         ` Laurent Pinchart
2020-05-13 10:05 ` [PATCH 3/3] drm/bridge: Introduce LT9611 DSI to HDMI bridge Vinod Koul
2020-05-13 10:05   ` Vinod Koul
2020-05-13 16:14   ` kbuild test robot
2020-05-13 16:14     ` kbuild test robot
2020-05-13 16:14     ` kbuild test robot
2020-05-13 16:46   ` kbuild test robot
2020-05-13 16:46     ` kbuild test robot
2020-05-13 16:46     ` kbuild test robot
2020-05-13 19:20   ` Emil Velikov
2020-05-13 19:20     ` Emil Velikov
2020-05-14  7:06     ` Vinod Koul
2020-05-14  7:06       ` Vinod Koul
2020-05-28  1:52   ` Laurent Pinchart
2020-05-28  1:52     ` Laurent Pinchart
2020-06-04  7:25     ` Vinod Koul [this message]
2020-06-04  7:25       ` Vinod Koul
2020-06-04  7:38       ` Laurent Pinchart
2020-06-04  7:38         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604072548.GE3521@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@siol.net \
    --cc=jonas@kwiboo.se \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.