From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDEA7C433E0 for ; Thu, 4 Jun 2020 08:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93A4920738 for ; Thu, 4 Jun 2020 08:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UO/LN4Bz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726907AbgFDIbu (ORCPT ); Thu, 4 Jun 2020 04:31:50 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:34318 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgFDIbt (ORCPT ); Thu, 4 Jun 2020 04:31:49 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0548S7eE162710; Thu, 4 Jun 2020 08:31:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2020-01-29; bh=+U9pBSfXjXliRGgKHYuTmpAMur9djQ6OelvtEfxEzig=; b=UO/LN4Bzs6xjnoWtETZZ9tUKZi4IMXwj8kxT3lDrze66+DSq4UYaQiVpuocgZ06E6dPw zTdJ6CqCbO/4qG+IQcpHUA9vL5TruB9frU7HjIxssuyCJDZuFlcEEqZX1PB8Oy5VRzD3 3HLknCF6aeDGKs8Pyb+uO2rudpgM85OgLzpEac/Vn/kuwNWYNcpUGqKKpIiturlJQkSn loymQNZZIz/wVm+kZBlNzDnJlKDBB1OiqGKWgNuJlBS8tZtpSWOlJohD4LYzTd+wZOsV msAF445HU/jAKAVI9QqBklUp4yzhv7ynQSdBSjiGWzVf2B+3F6qba7kEj3ciKfUKcCZj QQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 31evvn06hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 04 Jun 2020 08:31:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0548TMjT116781; Thu, 4 Jun 2020 08:31:37 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 31c1e1dqyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Jun 2020 08:31:37 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0548VVjI025648; Thu, 4 Jun 2020 08:31:31 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 04 Jun 2020 01:31:30 -0700 Date: Thu, 4 Jun 2020 11:31:20 +0300 From: Dan Carpenter To: Linus Walleij Cc: Christophe JAILLET , Robert Jarzmik , Daniel Mack , Haojian Zhuang , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-ID: <20200604083120.GF22511@kadam> References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040058 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 cotscore=-2147483648 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 mlxscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040058 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter wrote: > > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > > Le 01/06/2020 à 10:58, Robert Jarzmik a écrit : > > > > Christophe JAILLET writes: > > > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > > > > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' in > > > > > 'pxa2xx_pinctrl_init()'. > > > > > However, the corresponding 'pinctrl_unregister()' call in > > > > > 'pxa2xx_pinctrl_exit()' has not been removed. > > > > > > > > > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > > > > > Remove it now to avoid some wondering in the future and save a few LoC. > > > > > > > > > > Signed-off-by: Christophe JAILLET > > > > Acked-by: Robert Jarzmik > > > > > > > > Would be even a better patch with a : > > > > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for pinctrl registration") > > > > > > I was wondering it was was needed in this case. > > > The patch does not really fix anything, as the function is unused. Or it > > > fixes things on a theoretical point of view. > > > > There is no concensus... We should call a vote on this at Kernel > > Summit. :P > > Fixes means it fixes something that was wrong in that commit. > That's all. Whether syntactic or semantic or regression or > serious or not does not matter. It is also not compulsory to > add it is just helpful. Fixes tag should be compulsory for actual bug fixes. We had a the Bad Binder exploit last year because commit f5cb779ba163 ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes tag and wasn't backported to Android kernels. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 04 Jun 2020 08:31:20 +0000 Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-Id: <20200604083120.GF22511@kadam> List-Id: References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Linus Walleij Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter w= rote: > > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > > Le 01/06/2020 =E0 10:58, Robert Jarzmik a =E9crit : > > > > Christophe JAILLET writes: > > > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() f= or pinctrl registration") > > > > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' = in > > > > > 'pxa2xx_pinctrl_init()'. > > > > > However, the corresponding 'pinctrl_unregister()' call in > > > > > 'pxa2xx_pinctrl_exit()' has not been removed. > > > > > > > > > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > > > > > Remove it now to avoid some wondering in the future and save a fe= w LoC. > > > > > > > > > > Signed-off-by: Christophe JAILLET > > > > Acked-by: Robert Jarzmik > > > > > > > > Would be even a better patch with a : > > > > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for= pinctrl registration") > > > > > > I was wondering it was was needed in this case. > > > The patch does not really fix anything, as the function is unused. Or= it > > > fixes things on a theoretical point of view. > > > > There is no concensus... We should call a vote on this at Kernel > > Summit. :P >=20 > Fixes means it fixes something that was wrong in that commit. > That's all. Whether syntactic or semantic or regression or > serious or not does not matter. It is also not compulsory to > add it is just helpful. Fixes tag should be compulsory for actual bug fixes. We had a the Bad Binder exploit last year because commit f5cb779ba163 ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes tag and wasn't backported to Android kernels. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AAFC433E0 for ; Thu, 4 Jun 2020 08:32:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21562205CB for ; Thu, 4 Jun 2020 08:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BjPdjVxo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UO/LN4Bz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21562205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=onPi405O44O7qGoYzsVJsOzss/N8X1AKbqQCsEDYh+k=; b=BjPdjVxo1is+zE Rtml7cIlCcpwZN86OyqE/+fo8UpgupPyxHg+zuGk21JaNYO6FLaQPwJMfcBpGilp8+fZX7pxHW+I4 KMaVJ45YRmDFhECYp+uu6WVruJUUp+ley5jGUybdtbX9uQttKPP+1Gio9yHA4yN5OtBpARS/E/3Oy 85cirV2UikNjKQms3EOegC0ALKEjqWhUB9exTigMZoYCFfDyv+VXFzHRnJCIUsJtYtv+QUqavAXhU dfdvYv51XOCQxHhsf5qf/KFBVN49P5Eyr5oJlZhXZYNin6SIz6b89iVGMlXvZca5VTjiTeAe74VO8 nvn7wcAf2rKtD04eDwRQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jglHy-0000rW-NN; Thu, 04 Jun 2020 08:31:50 +0000 Received: from userp2130.oracle.com ([156.151.31.86]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jglHv-0000r4-68 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 08:31:48 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0548S7eE162710; Thu, 4 Jun 2020 08:31:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : content-transfer-encoding : in-reply-to; s=corp-2020-01-29; bh=+U9pBSfXjXliRGgKHYuTmpAMur9djQ6OelvtEfxEzig=; b=UO/LN4Bzs6xjnoWtETZZ9tUKZi4IMXwj8kxT3lDrze66+DSq4UYaQiVpuocgZ06E6dPw zTdJ6CqCbO/4qG+IQcpHUA9vL5TruB9frU7HjIxssuyCJDZuFlcEEqZX1PB8Oy5VRzD3 3HLknCF6aeDGKs8Pyb+uO2rudpgM85OgLzpEac/Vn/kuwNWYNcpUGqKKpIiturlJQkSn loymQNZZIz/wVm+kZBlNzDnJlKDBB1OiqGKWgNuJlBS8tZtpSWOlJohD4LYzTd+wZOsV msAF445HU/jAKAVI9QqBklUp4yzhv7ynQSdBSjiGWzVf2B+3F6qba7kEj3ciKfUKcCZj QQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 31evvn06hp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 04 Jun 2020 08:31:38 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0548TMjT116781; Thu, 4 Jun 2020 08:31:37 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 31c1e1dqyu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Jun 2020 08:31:37 +0000 Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0548VVjI025648; Thu, 4 Jun 2020 08:31:31 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 04 Jun 2020 01:31:30 -0700 Date: Thu, 4 Jun 2020 11:31:20 +0300 From: Dan Carpenter To: Linus Walleij Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-ID: <20200604083120.GF22511@kadam> References: <20200531073716.593343-1-christophe.jaillet@wanadoo.fr> <87h7vvb1s3.fsf@belgarion.home> <20200601183102.GS30374@kadam> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040058 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 cotscore=-2147483648 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 mlxscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040058 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_013147_314868_0823A5AE X-CRM114-Status: GOOD ( 23.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Daniel Mack , Robert Jarzmik , Linux ARM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 04, 2020 at 12:08:49AM +0200, Linus Walleij wrote: > On Mon, Jun 1, 2020 at 8:31 PM Dan Carpenter w= rote: > > On Mon, Jun 01, 2020 at 01:31:23PM +0200, Christophe JAILLET wrote: > > > Le 01/06/2020 =E0 10:58, Robert Jarzmik a =E9crit : > > > > Christophe JAILLET writes: > > > > > > > > > Commit 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() f= or pinctrl registration") > > > > > has turned a 'pinctrl_register()' into 'devm_pinctrl_register()' = in > > > > > 'pxa2xx_pinctrl_init()'. > > > > > However, the corresponding 'pinctrl_unregister()' call in > > > > > 'pxa2xx_pinctrl_exit()' has not been removed. > > > > > > > > > > This is not an issue, because 'pxa2xx_pinctrl_exit()' is unused. > > > > > Remove it now to avoid some wondering in the future and save a fe= w LoC. > > > > > > > > > > Signed-off-by: Christophe JAILLET > > > > Acked-by: Robert Jarzmik > > > > > > > > Would be even a better patch with a : > > > > Fixes: 6d33ee7a0534 ("pinctrl: pxa: Use devm_pinctrl_register() for= pinctrl registration") > > > > > > I was wondering it was was needed in this case. > > > The patch does not really fix anything, as the function is unused. Or= it > > > fixes things on a theoretical point of view. > > > > There is no concensus... We should call a vote on this at Kernel > > Summit. :P > = > Fixes means it fixes something that was wrong in that commit. > That's all. Whether syntactic or semantic or regression or > serious or not does not matter. It is also not compulsory to > add it is just helpful. Fixes tag should be compulsory for actual bug fixes. We had a the Bad Binder exploit last year because commit f5cb779ba163 ("ANDROID: binder: remove waitqueue when thread exits.") had no Fixes tag and wasn't backported to Android kernels. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel