All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Namhyung Kim <namhyung@kernel.org>,
	linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config
Date: Thu, 4 Jun 2020 10:34:16 +0200	[thread overview]
Message-ID: <20200604083416.GA1283757@krava> (raw)
In-Reply-To: <35e55bec-1f8a-0e8f-798b-bab51ad30797@loongson.cn>

On Wed, Jun 03, 2020 at 10:01:27AM +0800, Tiezhu Yang wrote:

SNIP

> > > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > > index 12a8204..b699d21 100644
> > > --- a/tools/perf/Makefile.config
> > > +++ b/tools/perf/Makefile.config
> > > @@ -387,6 +387,12 @@ else
> > >         NO_LIBBPF := 1
> > >         NO_JVMTI := 1
> > >       else
> > > +      ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0)
> > > +        msg := $(error No libasan found, please install libasan);
> > > +      endif
> > > +      ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0)
> > > +        msg := $(error No libubsan found, please install libubsan);
> > > +      endif
> > hum, would it be better to have check for this in tools/build/features?
> 
> Hi Jiri,
> 
> Thanks for your suggestion.
> 
> Do you mean that it is better to add this check at the end of file
> tools/build/Makefile.feature?

we usualy detect installed libraries via tools/build/features framework,
this looks like it could fit in there

jirka

> 
> > 
> > jirka
> > 
> > >         ifneq ($(filter s% -static%,$(LDFLAGS),),)
> > >           msg := $(error No static glibc found, please install glibc-static);
> > >         else
> > > -- 
> > > 2.1.0
> > > 
> 


      reply	other threads:[~2020-06-04  8:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-02  4:15 [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Tiezhu Yang
2020-06-02  4:15 ` [PATCH 2/2] perf tools: Remove some duplicated includes Tiezhu Yang
2020-06-02 14:10   ` Arnaldo Carvalho de Melo
2020-06-02 14:11 ` [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Arnaldo Carvalho de Melo
2020-06-02 14:15 ` Jiri Olsa
2020-06-03  2:01   ` Tiezhu Yang
2020-06-04  8:34     ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200604083416.GA1283757@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixuefeng@loongson.cn \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.