From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D793C433DF for ; Thu, 4 Jun 2020 20:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE4532075B for ; Thu, 4 Jun 2020 20:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591302985; bh=6tdvI6hVT12tR559Y0x/YhFiPVzayDyW2O1N/hc9g6c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=OL5WP9CYDy7uOtI5DgaR2rVk3kKsrqIx9P0JRYkr//RudOXYjgAmecwmpH9s0SI44 E5TSi6QMeEJGnvDSDjC+rVSTbtDPPpl6/fx1Q5YnydWOs8xgOab8A7poZNZF1zMe4p FexPemgC8kB4PmGAUDH0fW+cbl7YiiygDGMe8rYc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729944AbgFDUgY (ORCPT ); Thu, 4 Jun 2020 16:36:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:37110 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728721AbgFDUgY (ORCPT ); Thu, 4 Jun 2020 16:36:24 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6040206E6; Thu, 4 Jun 2020 20:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591302983; bh=6tdvI6hVT12tR559Y0x/YhFiPVzayDyW2O1N/hc9g6c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qq+Vitsm0LE8dgUTqTQ0PJt10JogRLNno17Te9gJX7oxFW7ATDBP35tpCOhVoRSDf ZLU6bXMm6yBmbq5o/AWzp33kWB8jss/xeVh6VQgYho6GvCdUNO06ShJ+VY6nDm9gw3 UwiCaH4RqhPdb2XgCFpWNw4rgGS2KH5U7jjAZFbI= Date: Thu, 4 Jun 2020 13:36:22 -0700 From: Andrew Morton To: Mike Rapoport Cc: Joerg Roedel , peterz@infradead.org, jroedel@suse.de, Andy Lutomirski , Abdul Haleem , Satheesh Rajendran , Stephen Rothwell , manvanth@linux.vnet.ibm.com, linux-next@vger.kernel.org, Steven Rostedt , linuxppc-dev@lists.ozlabs.org, hch@lst.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Fix pud_alloc_track() Message-Id: <20200604133622.c23b365066af0b14a9f04961@linux-foundation.org> In-Reply-To: <20200604164814.GA7600@kernel.org> References: <20200604074446.23944-1-joro@8bytes.org> <20200604164814.GA7600@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Jun 2020 19:48:14 +0300 Mike Rapoport wrote: > On Thu, Jun 04, 2020 at 09:44:46AM +0200, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The pud_alloc_track() needs to do different checks based on whether > > __ARCH_HAS_5LEVEL_HACK is defined, like it already does in > > pud_alloc(). Otherwise it causes boot failures on PowerPC. > > > > Provide the correct implementations for both possible settings of > > __ARCH_HAS_5LEVEL_HACK to fix the boot problems. > > There is a patch in mmotm [1] that completely removes > __ARCH_HAS_5LEVEL_HACK which is a part of the series [2] that updates > p4d folding accross architectures. This should fix boot on PowerPC and > the addition of pXd_alloc_track() for __ARCH_HAS_5LEVEL_HACK wouldn't be > necessary. > > > [1] https://github.com/hnaz/linux-mm/commit/cfae68792af3731ac902ea6ba5ed8df5a0f6bd2f > [2] https://lore.kernel.org/kvmarm/20200414153455.21744-1-rppt@kernel.org/ That patchset is stacked up behind many other patches, including all the powerpc stuff in linux-next :( As it's a big bug fix, I'll pull those patches forward, hopefully send it all Linuswards later today... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81854C433DF for ; Thu, 4 Jun 2020 20:38:40 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAFC1206E6 for ; Thu, 4 Jun 2020 20:38:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qq+Vitsm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFC1206E6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49dHg14FGzzDqth for ; Fri, 5 Jun 2020 06:38:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux-foundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=akpm@linux-foundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=Qq+Vitsm; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49dHcV379qzDqfL for ; Fri, 5 Jun 2020 06:36:26 +1000 (AEST) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6040206E6; Thu, 4 Jun 2020 20:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591302983; bh=6tdvI6hVT12tR559Y0x/YhFiPVzayDyW2O1N/hc9g6c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qq+Vitsm0LE8dgUTqTQ0PJt10JogRLNno17Te9gJX7oxFW7ATDBP35tpCOhVoRSDf ZLU6bXMm6yBmbq5o/AWzp33kWB8jss/xeVh6VQgYho6GvCdUNO06ShJ+VY6nDm9gw3 UwiCaH4RqhPdb2XgCFpWNw4rgGS2KH5U7jjAZFbI= Date: Thu, 4 Jun 2020 13:36:22 -0700 From: Andrew Morton To: Mike Rapoport Subject: Re: [PATCH] mm: Fix pud_alloc_track() Message-Id: <20200604133622.c23b365066af0b14a9f04961@linux-foundation.org> In-Reply-To: <20200604164814.GA7600@kernel.org> References: <20200604074446.23944-1-joro@8bytes.org> <20200604164814.GA7600@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Stephen Rothwell , jroedel@suse.de, linux-mm@kvack.org, peterz@infradead.org, linuxppc-dev@lists.ozlabs.org, Joerg Roedel , linux-kernel@vger.kernel.org, Steven Rostedt , Abdul Haleem , linux-next@vger.kernel.org, Satheesh Rajendran , Andy Lutomirski , manvanth@linux.vnet.ibm.com, hch@lst.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, 4 Jun 2020 19:48:14 +0300 Mike Rapoport wrote: > On Thu, Jun 04, 2020 at 09:44:46AM +0200, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The pud_alloc_track() needs to do different checks based on whether > > __ARCH_HAS_5LEVEL_HACK is defined, like it already does in > > pud_alloc(). Otherwise it causes boot failures on PowerPC. > > > > Provide the correct implementations for both possible settings of > > __ARCH_HAS_5LEVEL_HACK to fix the boot problems. > > There is a patch in mmotm [1] that completely removes > __ARCH_HAS_5LEVEL_HACK which is a part of the series [2] that updates > p4d folding accross architectures. This should fix boot on PowerPC and > the addition of pXd_alloc_track() for __ARCH_HAS_5LEVEL_HACK wouldn't be > necessary. > > > [1] https://github.com/hnaz/linux-mm/commit/cfae68792af3731ac902ea6ba5ed8df5a0f6bd2f > [2] https://lore.kernel.org/kvmarm/20200414153455.21744-1-rppt@kernel.org/ That patchset is stacked up behind many other patches, including all the powerpc stuff in linux-next :( As it's a big bug fix, I'll pull those patches forward, hopefully send it all Linuswards later today...