From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F9AC433E1 for ; Thu, 4 Jun 2020 15:24:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21D0C207D8 for ; Thu, 4 Jun 2020 15:24:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="WWJ64XPs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729528AbgFDPYn (ORCPT ); Thu, 4 Jun 2020 11:24:43 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:11303 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729389AbgFDPYn (ORCPT ); Thu, 4 Jun 2020 11:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1591284282; x=1622820282; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=85ZI8AvQy4iaEYwlmUIBJHVkn6uRn1cMnoNcm2qnEJs=; b=WWJ64XPsP8oOTVB/csL7d65S3iub5Ko1sFL8RiLsYsWllbNJNjSg9ubv VDCs2/8vMGu31z8DN/eaYKLBoLx5w+5cNIsZ7UWjbQzMevlVNmIWzWJB8 D4QaY70YiHAjYfbdJStHmJ/f3rp2Cm//y6sfh7x6TVwZ21JyamAGHlugA 8=; IronPort-SDR: +qPmIamr4P3EzJWJc5geCeaqAOpGROdK3K6WRwkx/VvmToKzVx8Y5/WKNsLj3Ap74wjy36mDCM Hz0rXPTCbgcQ== X-IronPort-AV: E=Sophos;i="5.73,472,1583193600"; d="scan'208";a="35810828" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-1e-c7c08562.us-east-1.amazon.com) ([10.43.8.6]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 04 Jun 2020 15:24:20 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1e-c7c08562.us-east-1.amazon.com (Postfix) with ESMTPS id A4A19241C4A; Thu, 4 Jun 2020 15:24:08 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Jun 2020 15:24:08 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.162.140) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 4 Jun 2020 15:23:51 +0000 From: SeongJae Park To: David Hildenbrand CC: SeongJae Park , , "SeongJae Park" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: Re: [RFC v2 7/9] mm/damon: Implement callbacks for physical memory monitoring Date: Thu, 4 Jun 2020 17:23:36 +0200 Message-ID: <20200604152336.4826-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <4b5814d8-9626-e71c-9e5d-a4a61fcd12e8@redhat.com> (raw) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.162.140] X-ClientProxiedBy: EX13D34UWA004.ant.amazon.com (10.43.160.177) To EX13D31EUA001.ant.amazon.com (10.43.165.15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 4 Jun 2020 16:58:13 +0200 David Hildenbrand wrote: > On 04.06.20 09:26, SeongJae Park wrote: > > On Wed, 3 Jun 2020 18:09:21 +0200 David Hildenbrand wrote: > > > >> On 03.06.20 16:11, SeongJae Park wrote: > >>> From: SeongJae Park > >>> > >>> This commit implements the four callbacks (->init_target_regions, > >>> ->update_target_regions, ->prepare_access_check, and ->check_accesses) > >>> for the basic access monitoring of the physical memory address space. > >>> By setting the callback pointers to point those, users can easily > >>> monitor the accesses to the physical memory. > >>> > >>> Internally, it uses the PTE Accessed bit, as similar to that of the > >>> virtual memory support. Also, it supports only page frames that > >>> supported by idle page tracking. Acutally, most of the code is stollen > >>> from idle page tracking. Users who want to use other access check > >>> primitives and monitor the frames that not supported with this > >>> implementation could implement their own callbacks on their own. > >>> > >>> Signed-off-by: SeongJae Park > >>> --- > >>> include/linux/damon.h | 5 ++ > >>> mm/damon.c | 184 ++++++++++++++++++++++++++++++++++++++++++ > >>> 2 files changed, 189 insertions(+) > >>> > >>> diff --git a/include/linux/damon.h b/include/linux/damon.h > >>> index 1a788bfd1b4e..f96503a532ea 100644 > >>> --- a/include/linux/damon.h > >>> +++ b/include/linux/damon.h > >>> @@ -216,6 +216,11 @@ void kdamond_update_vm_regions(struct damon_ctx *ctx); > >>> void kdamond_prepare_vm_access_checks(struct damon_ctx *ctx); > >>> unsigned int kdamond_check_vm_accesses(struct damon_ctx *ctx); > >>> > >>> +void kdamond_init_phys_regions(struct damon_ctx *ctx); > >>> +void kdamond_update_phys_regions(struct damon_ctx *ctx); > >>> +void kdamond_prepare_phys_access_checks(struct damon_ctx *ctx); > >>> +unsigned int kdamond_check_phys_accesses(struct damon_ctx *ctx); > >>> + > >>> int damon_set_pids(struct damon_ctx *ctx, int *pids, ssize_t nr_pids); > >>> int damon_set_attrs(struct damon_ctx *ctx, unsigned long sample_int, > >>> unsigned long aggr_int, unsigned long regions_update_int, > >>> diff --git a/mm/damon.c b/mm/damon.c > >>> index f5cbc97a3bbc..6a5c6d540580 100644 > >>> --- a/mm/damon.c > >>> +++ b/mm/damon.c > >>> @@ -19,7 +19,9 @@ > >>> #include > >>> #include > >>> #include > >>> +#include > >>> #include > >>> +#include > >>> #include > >>> #include > >>> #include > >>> @@ -480,6 +482,11 @@ void kdamond_init_vm_regions(struct damon_ctx *ctx) > >>> } > >>> } > >>> > >>> +/* Do nothing. Users should set the initial regions by themselves */ > >>> +void kdamond_init_phys_regions(struct damon_ctx *ctx) > >>> +{ > >>> +} > >>> + > >>> static void damon_mkold(struct mm_struct *mm, unsigned long addr) > >>> { > >>> pte_t *pte = NULL; > >>> @@ -611,6 +618,178 @@ unsigned int kdamond_check_vm_accesses(struct damon_ctx *ctx) > >>> return max_nr_accesses; > >>> } > >>> > >>> +/* access check functions for physical address based regions */ > >>> + > >>> +/* This code is stollen from page_idle.c */ > >>> +static struct page *damon_phys_get_page(unsigned long pfn) > >>> +{ > >>> + struct page *page; > >>> + pg_data_t *pgdat; > >>> + > >>> + if (!pfn_valid(pfn)) > >>> + return NULL; > >>> + > >> > >> Who provides these pfns? Can these be random pfns, supplied unchecked by > >> user space? Or are they at least mapped into some user space process? > > > > Your guess is right, users can give random physical address and that will be > > translated into pfn. > > > > Note the difference to idle tracking: "Idle page tracking only considers > user memory pages", this is very different to your use case. Note that > this is why there is no pfn_to_online_page() check in page idle code. My use case is same to that of idle page. I also ignore non-user pages. Actually, this function is for filtering of the non-user pages, which is simply stollen from the page_idle. > > >> > >> IOW, do we need a pfn_to_online_page() to make sure the memmap even was > >> initialized? > > > > Thank you for pointing out this! I will use it in the next spin. Also, this > > code is stollen from page_idle_get_page(). Seems like it should also be > > modified to use it. I will send the patch for it, either. > > pfn_to_online_page() will only succeed for system RAM pages, not > dax/pmem (ZONE_DEVICE). dax/pmem needs special care. > > I can spot that you are taking references to random struct pages. This > looks dangerous to me and might mess in complicated ways with page > migration/isolation/onlining/offlining etc. I am not sure if we want that. AFAIU, page_idle users can also pass random pfns by randomly accessing the bitmap file. Am I missing something? Thanks, SeongJae Park > > -- > Thanks, > > David / dhildenb