From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9849C433DF for ; Thu, 4 Jun 2020 16:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A207320738 for ; Thu, 4 Jun 2020 16:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="aGaT6JoG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729993AbgFDQ5S (ORCPT ); Thu, 4 Jun 2020 12:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729115AbgFDQ5S (ORCPT ); Thu, 4 Jun 2020 12:57:18 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340F4C08C5C0; Thu, 4 Jun 2020 09:57:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WNuoe0aJej6Twt/hptn1Tc9VMEiTloei55h4/xsUoEc=; b=aGaT6JoG6JwGGaQaEogYAqTBJ9 xuLUj1OC3CAgpdlWoVQvRYe3kK7pD1+Y7UiKVCazCpq104knW9A+PRMr5JSOj9xSYbfLIqp7uHpJZ bKeuIqvGnBXvoDTgDE6rn0ulpPv1XB0E+4Ds/kcenR5J+DohAB/M/KEV83k/F+fYlMFvbrwWJo6c8 g7oiJEQ4cp8VH3cGFRxCl5Eit0VdyK09s4QIghJc/fNrS+UIQJZJbx/wraFeJ4Gnr/hsFzztcyLGR TpS9SjQZBkL77Esd/S8Swvsw4QJaziyO8Q91L1SramyEnqQGTBQu1rLGuVV5x9dHXABr4mnhUL7We Ut1HXWLw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgtAx-0001Kw-1v; Thu, 04 Jun 2020 16:57:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 04D45301ABC; Thu, 4 Jun 2020 18:57:03 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B172E20E061B2; Thu, 4 Jun 2020 18:57:03 +0200 (CEST) Date: Thu, 4 Jun 2020 18:57:03 +0200 From: Peter Zijlstra To: David Miller Cc: mingo@kernel.org, will@kernel.org, tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org, a.darwish@linutronix.de, rostedt@goodmis.org, bigeasy@linutronix.de, sparclinux@vger.kernel.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org Subject: Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error Message-ID: <20200604165703.GG3976@hirez.programming.kicks-ass.net> References: <20200529213550.683440625@infradead.org> <20200529214203.673108357@infradead.org> <20200529.162917.1970892823680223252.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529.162917.1970892823680223252.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 29, 2020 at 04:29:17PM -0700, David Miller wrote: > From: Peter Zijlstra > Date: Fri, 29 May 2020 23:35:51 +0200 > > > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register used for global register variable > > register unsigned long __local_per_cpu_offset asm("g5"); > > The "-ffixed-g5" option on the command line tells gcc that we are > using 'g5' as a fixed register, so some part of your build isn't using > the: > > KBUILD_CFLAGS += -ffixed-g4 -ffixed-g5 -fcall-used-g7 -Wno-sign-compare > > from arch/sparc/Makefile for some reason. Thanks, that was the clue I needed. I think I see, what happens is that these headers end up in the VDSO build, and that doesn't have these CFLAGS, because userspace. Let me see what to do about that. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Date: Thu, 04 Jun 2020 16:57:03 +0000 Subject: Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error Message-Id: <20200604165703.GG3976@hirez.programming.kicks-ass.net> List-Id: References: <20200529213550.683440625@infradead.org> <20200529214203.673108357@infradead.org> <20200529.162917.1970892823680223252.davem@davemloft.net> In-Reply-To: <20200529.162917.1970892823680223252.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Miller Cc: mingo@kernel.org, will@kernel.org, tglx@linutronix.de, x86@kernel.org, linux-kernel@vger.kernel.org, a.darwish@linutronix.de, rostedt@goodmis.org, bigeasy@linutronix.de, sparclinux@vger.kernel.org, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, heiko.carstens@de.ibm.com, linux-s390@vger.kernel.org On Fri, May 29, 2020 at 04:29:17PM -0700, David Miller wrote: > From: Peter Zijlstra > Date: Fri, 29 May 2020 23:35:51 +0200 > > > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register used for global register variable > > register unsigned long __local_per_cpu_offset asm("g5"); > > The "-ffixed-g5" option on the command line tells gcc that we are > using 'g5' as a fixed register, so some part of your build isn't using > the: > > KBUILD_CFLAGS += -ffixed-g4 -ffixed-g5 -fcall-used-g7 -Wno-sign-compare > > from arch/sparc/Makefile for some reason. Thanks, that was the clue I needed. I think I see, what happens is that these headers end up in the VDSO build, and that doesn't have these CFLAGS, because userspace. Let me see what to do about that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB59C433DF for ; Thu, 4 Jun 2020 16:59:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 749DA20738 for ; Thu, 4 Jun 2020 16:59:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="aGaT6JoG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 749DA20738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49dBpM2v7HzDqsX for ; Fri, 5 Jun 2020 02:59:39 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=peterz@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=aGaT6JoG; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49dBlc5FyRzDqkc for ; Fri, 5 Jun 2020 02:57:16 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WNuoe0aJej6Twt/hptn1Tc9VMEiTloei55h4/xsUoEc=; b=aGaT6JoG6JwGGaQaEogYAqTBJ9 xuLUj1OC3CAgpdlWoVQvRYe3kK7pD1+Y7UiKVCazCpq104knW9A+PRMr5JSOj9xSYbfLIqp7uHpJZ bKeuIqvGnBXvoDTgDE6rn0ulpPv1XB0E+4Ds/kcenR5J+DohAB/M/KEV83k/F+fYlMFvbrwWJo6c8 g7oiJEQ4cp8VH3cGFRxCl5Eit0VdyK09s4QIghJc/fNrS+UIQJZJbx/wraFeJ4Gnr/hsFzztcyLGR TpS9SjQZBkL77Esd/S8Swvsw4QJaziyO8Q91L1SramyEnqQGTBQu1rLGuVV5x9dHXABr4mnhUL7We Ut1HXWLw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgtAx-0001Kw-1v; Thu, 04 Jun 2020 16:57:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 04D45301ABC; Thu, 4 Jun 2020 18:57:03 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id B172E20E061B2; Thu, 4 Jun 2020 18:57:03 +0200 (CEST) Date: Thu, 4 Jun 2020 18:57:03 +0200 From: Peter Zijlstra To: David Miller Subject: Re: [RFC][PATCH v3 1/5] sparc64: Fix asm/percpu.h build error Message-ID: <20200604165703.GG3976@hirez.programming.kicks-ass.net> References: <20200529213550.683440625@infradead.org> <20200529214203.673108357@infradead.org> <20200529.162917.1970892823680223252.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200529.162917.1970892823680223252.davem@davemloft.net> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, bigeasy@linutronix.de, x86@kernel.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, rostedt@goodmis.org, a.darwish@linutronix.de, sparclinux@vger.kernel.org, tglx@linutronix.de, will@kernel.org, mingo@kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 29, 2020 at 04:29:17PM -0700, David Miller wrote: > From: Peter Zijlstra > Date: Fri, 29 May 2020 23:35:51 +0200 > > > ../arch/sparc/include/asm/percpu_64.h:7:24: warning: call-clobbered register used for global register variable > > register unsigned long __local_per_cpu_offset asm("g5"); > > The "-ffixed-g5" option on the command line tells gcc that we are > using 'g5' as a fixed register, so some part of your build isn't using > the: > > KBUILD_CFLAGS += -ffixed-g4 -ffixed-g5 -fcall-used-g7 -Wno-sign-compare > > from arch/sparc/Makefile for some reason. Thanks, that was the clue I needed. I think I see, what happens is that these headers end up in the VDSO build, and that doesn't have these CFLAGS, because userspace. Let me see what to do about that.