All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: drivers/media/cec/usb/pulse8/pulse8-cec.c:348 pulse8_irq_work_handler() error: double unlocked 'pulse8->msg_lock' (orig line 335)
Date: Fri, 05 Jun 2020 00:51:39 +0800	[thread overview]
Message-ID: <202006050034.P96qZN0u%lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5965 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Mauro Carvalho Chehab <mchehab@kernel.org>
CC: linux-media(a)vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   6929f71e46bdddbf1c4d67c2728648176c67c555
commit: a81068181aad78a5f6980408a4b6115d22bb8aed media: move CEC USB drivers to a separate directory
date:   7 weeks ago
:::::: branch date: 12 hours ago
:::::: commit date: 7 weeks ago
config: i386-randconfig-m021-20200604 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/media/cec/usb/pulse8/pulse8-cec.c:348 pulse8_irq_work_handler() error: double unlocked 'pulse8->msg_lock' (orig line 335)

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a81068181aad78a5f6980408a4b6115d22bb8aed
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git remote update linus
git checkout a81068181aad78a5f6980408a4b6115d22bb8aed
vim +348 drivers/media/cec/usb/pulse8/pulse8-cec.c

b36910e078428aa drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  325  
9d01315d132469f drivers/staging/media/pulse8-cec/pulse8-cec.c Mauro Carvalho Chehab 2016-07-12  326  static void pulse8_irq_work_handler(struct work_struct *work)
3dff3106fd7992a drivers/staging/media/pulse8-cec/pulse8-cec.c Hans Verkuil          2016-07-10  327  {
3dff3106fd7992a drivers/staging/media/pulse8-cec/pulse8-cec.c Hans Verkuil          2016-07-10  328  	struct pulse8 *pulse8 =
b36910e078428aa drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  329  		container_of(work, struct pulse8, irq_work);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  330  	unsigned long flags;
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  331  	u32 status;
3dff3106fd7992a drivers/staging/media/pulse8-cec/pulse8-cec.c Hans Verkuil          2016-07-10  332  
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  333  	spin_lock_irqsave(&pulse8->msg_lock, flags);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  334  	while (pulse8->rx_msg_num) {
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11 @335  		spin_unlock_irqrestore(&pulse8->msg_lock, flags);
a67524c8bf7509f drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  336  		if (debug)
a67524c8bf7509f drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  337  			dev_info(pulse8->dev, "adap received %*ph\n",
a67524c8bf7509f drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  338  				 pulse8->rx_msg[pulse8->rx_msg_cur_idx].len,
a67524c8bf7509f drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  339  				 pulse8->rx_msg[pulse8->rx_msg_cur_idx].msg);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  340  		cec_received_msg(pulse8->adap,
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  341  				 &pulse8->rx_msg[pulse8->rx_msg_cur_idx]);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  342  		spin_lock_irqsave(&pulse8->msg_lock, flags);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  343  		if (pulse8->rx_msg_num)
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  344  			pulse8->rx_msg_num--;
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  345  		pulse8->rx_msg_cur_idx =
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  346  			(pulse8->rx_msg_cur_idx + 1) % NUM_MSGS;
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  347  	}
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11 @348  	spin_unlock_irqrestore(&pulse8->msg_lock, flags);
906870770431cbe drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  349  
a6706447f31916c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  350  	mutex_lock(&pulse8->lock);
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  351  	status = pulse8->tx_done_status;
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  352  	pulse8->tx_done_status = 0;
a6706447f31916c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  353  	mutex_unlock(&pulse8->lock);
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  354  	if (status)
b7d0567f552a46c drivers/media/usb/pulse8-cec/pulse8-cec.c     Hans Verkuil          2019-12-11  355  		cec_transmit_attempt_done(pulse8->adap, status);
3dff3106fd7992a drivers/staging/media/pulse8-cec/pulse8-cec.c Hans Verkuil          2016-07-10  356  }
3dff3106fd7992a drivers/staging/media/pulse8-cec/pulse8-cec.c Hans Verkuil          2016-07-10  357  

:::::: The code at line 348 was first introduced by commit
:::::: 906870770431cbeb64e73da2111a4636d227f1e0 media: pulse8-cec: queue received messages in an array

:::::: TO: Hans Verkuil <hverkuil-cisco@xs4all.nl>
:::::: CC: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41431 bytes --]

             reply	other threads:[~2020-06-04 16:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 16:51 kernel test robot [this message]
2020-09-01  0:50 drivers/media/cec/usb/pulse8/pulse8-cec.c:348 pulse8_irq_work_handler() error: double unlocked 'pulse8->msg_lock' (orig line 335) kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006050034.P96qZN0u%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.