All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Eric Farman <farman@linux.ibm.com>,
	qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	qemu-devel@nongnu.org, Jared Rossi <jrossi@linux.ibm.com>
Subject: [PULL 05/10] vfio-ccw: allow non-prefetch ORBs
Date: Fri,  5 Jun 2020 17:37:51 +0200	[thread overview]
Message-ID: <20200605153756.392825-6-cohuck@redhat.com> (raw)
In-Reply-To: <20200605153756.392825-1-cohuck@redhat.com>

From: Jared Rossi <jrossi@linux.ibm.com>

Remove the explicit prefetch check when using vfio-ccw devices.
This check does not trigger in practice as all Linux channel programs
are intended to use prefetch.

Newer Linux kernel versions do not require to force the PFCH flag with
vfio-ccw devices anymore.

Signed-off-by: Jared Rossi <jrossi@linux.ibm.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Message-Id: <20200512181535.18630-2-jrossi@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/vfio/ccw.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index c8624943c177..63406184d226 100644
--- a/hw/vfio/ccw.c
+++ b/hw/vfio/ccw.c
@@ -74,16 +74,9 @@ static IOInstEnding vfio_ccw_handle_request(SubchDev *sch)
     struct ccw_io_region *region = vcdev->io_region;
     int ret;
 
-    if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH)) {
-        if (!(vcdev->force_orb_pfch)) {
-            warn_once_pfch(vcdev, sch, "requires PFCH flag set");
-            sch_gen_unit_exception(sch);
-            css_inject_io_interrupt(sch);
-            return IOINST_CC_EXPECTED;
-        } else {
-            sch->orb.ctrl0 |= ORB_CTRL0_MASK_PFCH;
-            warn_once_pfch(vcdev, sch, "PFCH flag forced");
-        }
+    if (!(sch->orb.ctrl0 & ORB_CTRL0_MASK_PFCH) && vcdev->force_orb_pfch) {
+        sch->orb.ctrl0 |= ORB_CTRL0_MASK_PFCH;
+        warn_once_pfch(vcdev, sch, "PFCH flag forced");
     }
 
     QEMU_BUILD_BUG_ON(sizeof(region->orb_area) != sizeof(ORB));
-- 
2.25.4



  parent reply	other threads:[~2020-06-05 15:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 15:37 [PULL 00/10] s390x update Cornelia Huck
2020-06-05 15:37 ` [PULL 01/10] s390x/kvm: help valgrind in several places Cornelia Huck
2020-06-05 15:37 ` [PULL 02/10] s390x: pv: Fix KVM_PV_PREP_RESET command wrapper name Cornelia Huck
2020-06-05 15:37 ` [PULL 03/10] docs/s390x: document the virtual css Cornelia Huck
2020-06-05 15:37 ` [PULL 04/10] docs/s390x: document 3270 Cornelia Huck
2020-06-05 15:37 ` Cornelia Huck [this message]
2020-06-05 15:37 ` [PULL 06/10] docs/s390x: document vfio-ccw Cornelia Huck
2020-06-05 15:37 ` [PULL 07/10] MAINTAINERS: add Thomas as additional s390x maintainer Cornelia Huck
2020-06-05 15:37 ` [PULL 08/10] target/s390x: Only compile decode_basedisp() on system-mode Cornelia Huck
2020-06-05 15:37 ` [PULL 09/10] target/s390x/helper: Clean ifdef'ry Cornelia Huck
2020-06-05 15:37 ` [PULL 10/10] target/s390x: Restrict system-mode declarations Cornelia Huck
2020-06-05 22:31 ` [PULL 00/10] s390x update Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200605153756.392825-6-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=jrossi@linux.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.