From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639E2C433E0 for ; Fri, 5 Jun 2020 16:51:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D73F206DB for ; Fri, 5 Jun 2020 16:51:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X7Z7bGQR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D73F206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhFZD-00044Q-EL for qemu-devel@archiver.kernel.org; Fri, 05 Jun 2020 12:51:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40448) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhFXq-000198-NE for qemu-devel@nongnu.org; Fri, 05 Jun 2020 12:50:14 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]:44068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhFXp-0001de-UF for qemu-devel@nongnu.org; Fri, 05 Jun 2020 12:50:14 -0400 Received: by mail-wr1-x42b.google.com with SMTP id y17so10420935wrn.11 for ; Fri, 05 Jun 2020 09:50:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=JbPgHS0uFT5SU5bLrmRMVkoZQ1aduSbm+LPDO/fRmyE=; b=X7Z7bGQRLiYsJrsNMGg5FXaYMpITJ8ghGTKZySGnluDH2St8rgPbbHqcy4SO3J2Eto 5ByIL8nhmUBpVlQevFi2G4u0kSk6jjJHvRoNz3RDTCNoWAhFcVsJpDzIfTY4suzPzMtc yYQSGmQtMq8LLtUQPJg8hv7BJlx3i4hFdTGG1lOmvSydtFdjUpa118x4qPFqp5TbINX3 nvYvlxhORYS6pZ4EE5BiaP+3eG8fBjsv8z13j3IVM7MhwImrNPHoxcIn9T+qAKNRe2DC 2TgFKB5U3DVpmsAEMNK32zRwxOMogxXdUHUf4lfkPxb66ZX/rtbyT6Ou0TuwueMe9c4O Fjdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JbPgHS0uFT5SU5bLrmRMVkoZQ1aduSbm+LPDO/fRmyE=; b=L8xvUTHbu00bSlDilX1QD4Yw7NSE7j9k+sW6WBrsJuv0ynuuJd3O/UlfERP0eyNQjA WvH6/1ci43h2fVr5uhOdL1CvtGuhXK8jx+laffuX9qJS76DnKeii9UsPObU9O0GeqD3X hD2MyIl9EaXAaKXiuaKXqyjYV8XsV0tTjRRTorv1tXLNnlIJMx8aN41tKlbFkQ7jBeFw y+jZa/PSBeZHRpTpoAVjvITRzMk09q3ZkroczRCYvdm82UJihVvHv7NAaVZhedHdrRLM zXAiwDySPlWQtU9LuF7sBOOHd/x/M8sBBFTrLawCAjlodgA22hlg5cvb58OAog1++ZbT c/Cg== X-Gm-Message-State: AOAM532/3gsCtZtEQOYC1KAAhOqLNVgHHbYdXbCwjxNxZDk0BFDEGu1n aw2nn97OmyNXnPEyHgQBVWJ1WPO4m09a5w== X-Google-Smtp-Source: ABdhPJzm3IfFarDNCI1BIxi1WH2LWP50FdJmlFu4yfZtWW3v2zbcKgUVjmyhnm2aGtb341SMTgXCjg== X-Received: by 2002:adf:e590:: with SMTP id l16mr10081659wrm.383.1591375812080; Fri, 05 Jun 2020 09:50:12 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id c140sm12272724wmd.18.2020.06.05.09.50.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 09:50:11 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 02/29] hw/ssi/imx_spi: Removed unnecessary cast of rx data received from slave Date: Fri, 5 Jun 2020 17:49:40 +0100 Message-Id: <20200605165007.12095-3-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200605165007.12095-1-peter.maydell@linaro.org> References: <20200605165007.12095-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42b.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" From: Eden Mikitas When inserting the value retrieved (rx) from the spi slave, rx is pushed to rx_fifo after being cast to uint8_t. rx_fifo is a fifo32, and the rx register the driver uses is also 32 bit. This zeroes the 24 most significant bits of rx. This proved problematic with devices that expect to use the whole 32 bits of the rx register. Signed-off-by: Eden Mikitas Reviewed-by: Alistair Francis Signed-off-by: Peter Maydell --- hw/ssi/imx_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ssi/imx_spi.c b/hw/ssi/imx_spi.c index 6fef5c79588..43b2f14dd28 100644 --- a/hw/ssi/imx_spi.c +++ b/hw/ssi/imx_spi.c @@ -206,7 +206,7 @@ static void imx_spi_flush_txfifo(IMXSPIState *s) if (fifo32_is_full(&s->rx_fifo)) { s->regs[ECSPI_STATREG] |= ECSPI_STATREG_RO; } else { - fifo32_push(&s->rx_fifo, (uint8_t)rx); + fifo32_push(&s->rx_fifo, rx); } if (s->burst_length <= 0) { -- 2.20.1