From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61EE5C433E0 for ; Fri, 5 Jun 2020 18:45:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B1452074B for ; Fri, 5 Jun 2020 18:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726926AbgFESpk (ORCPT ); Fri, 5 Jun 2020 14:45:40 -0400 Received: from mga18.intel.com ([134.134.136.126]:32603 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726077AbgFESpk (ORCPT ); Fri, 5 Jun 2020 14:45:40 -0400 IronPort-SDR: ZY00p+HTqIiocQ9SQZjocLDKNE4akfyZwU0IkouQ9umJ+NclvzN3Jh8vJ8/+fHXDqsySu2ZoBw WLlBUCAu52lg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 11:45:40 -0700 IronPort-SDR: Em2SwIApaOChD8ivBSlj6BODCCRiddGWah0O4ySqgGsb0gCpqtOSQm38t0f2Hd2aZIN7CrVwp3 Hr5AkR6fJpOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,477,1583222400"; d="scan'208";a="273556712" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 05 Jun 2020 11:45:38 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jhHLZ-00B5tA-GI; Fri, 05 Jun 2020 21:45:41 +0300 Date: Fri, 5 Jun 2020 21:45:41 +0300 From: Andy Shevchenko To: Hans de Goede Cc: Mika Westerberg , Linus Walleij , intel-gfx , linux-gpio@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH) Message-ID: <20200605184541.GU2428291@smile.fi.intel.com> References: <20200602122130.45630-1-hdegoede@redhat.com> <20200602152317.GI2428291@smile.fi.intel.com> <20200605170931.GR2428291@smile.fi.intel.com> <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jun 05, 2020 at 07:31:35PM +0200, Hans de Goede wrote: > On 6/5/20 7:09 PM, Andy Shevchenko wrote: > > On Fri, Jun 05, 2020 at 04:33:47PM +0200, Hans de Goede wrote: > > > On 6/2/20 5:23 PM, Andy Shevchenko wrote: > > > > On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote: ... > > > Sure, not sure if that is worth respinning the patch for though, > > > either way let me know. > > > > I think makes sense to respin. We still have time. > > I wasn't talking about timing, more just that it creates extra > work (for me) and if that was just for the capital 'B' thingie it > would not be worth the extra work IMHO, but since we need a v2 for > the fixes tag anyways I'll fix this as well. I got your point, no problem, I would fix myself, if it is only the comment to address. ... > > Btw, can we for sake of consistency update direction_input() as well? > > Sure, the change for that will be quite small, so shall I out it > in this patch, or do you want a second patch for that? I think we can do in one. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1190FC433DF for ; Fri, 5 Jun 2020 18:45:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E52E4206FA for ; Fri, 5 Jun 2020 18:45:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E52E4206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B3666E966; Fri, 5 Jun 2020 18:45:42 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 016B26E966 for ; Fri, 5 Jun 2020 18:45:40 +0000 (UTC) IronPort-SDR: yR2sFipVMJ3bqIuNtJg4PgMGK4Hoyca29O5U7RdjbUGMGdvOn5EHgQ9x96snU1S4n5cvaFbiXm WEqgga0WOyNA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 11:45:40 -0700 IronPort-SDR: Em2SwIApaOChD8ivBSlj6BODCCRiddGWah0O4ySqgGsb0gCpqtOSQm38t0f2Hd2aZIN7CrVwp3 Hr5AkR6fJpOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,477,1583222400"; d="scan'208";a="273556712" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 05 Jun 2020 11:45:38 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jhHLZ-00B5tA-GI; Fri, 05 Jun 2020 21:45:41 +0300 Date: Fri, 5 Jun 2020 21:45:41 +0300 From: Andy Shevchenko To: Hans de Goede Message-ID: <20200605184541.GU2428291@smile.fi.intel.com> References: <20200602122130.45630-1-hdegoede@redhat.com> <20200602152317.GI2428291@smile.fi.intel.com> <20200605170931.GR2428291@smile.fi.intel.com> <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1cf9b188-1e59-b321-6909-bf6afa93685d@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Subject: Re: [Intel-gfx] [PATCH] pinctrl: baytrail: Fix pin being driven low for a while on gpiod_get(..., GPIOD_OUT_HIGH) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, Linus Walleij , Mika Westerberg , intel-gfx , stable@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jun 05, 2020 at 07:31:35PM +0200, Hans de Goede wrote: > On 6/5/20 7:09 PM, Andy Shevchenko wrote: > > On Fri, Jun 05, 2020 at 04:33:47PM +0200, Hans de Goede wrote: > > > On 6/2/20 5:23 PM, Andy Shevchenko wrote: > > > > On Tue, Jun 02, 2020 at 02:21:30PM +0200, Hans de Goede wrote: ... > > > Sure, not sure if that is worth respinning the patch for though, > > > either way let me know. > > > > I think makes sense to respin. We still have time. > > I wasn't talking about timing, more just that it creates extra > work (for me) and if that was just for the capital 'B' thingie it > would not be worth the extra work IMHO, but since we need a v2 for > the fixes tag anyways I'll fix this as well. I got your point, no problem, I would fix myself, if it is only the comment to address. ... > > Btw, can we for sake of consistency update direction_input() as well? > > Sure, the change for that will be quite small, so shall I out it > in this patch, or do you want a second patch for that? I think we can do in one. -- With Best Regards, Andy Shevchenko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx