From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ED45C433E0 for ; Fri, 5 Jun 2020 23:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E748B207DF for ; Fri, 5 Jun 2020 23:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591399154; bh=pxsClvnIPBaS8ODkk62CMx4DJx6gcP1jIo9ANMgure4=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=G9CM7jcxSFc/FtQPw2UClnIbsID+W5A3bJ82Di4JhAwFPRgIDVuJ1UFahjMVZGO1v DDQpaxLLemcD7/dSzRNKKYZTpFzNSXF0sihQ6i0ESQbjOXGCIv2MNaLHEdYSCoJfWz XV7NPggW18Oo9EH/ezn78KqVydBBJ+fF5alXxT44= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728316AbgFEXTN (ORCPT ); Fri, 5 Jun 2020 19:19:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:47740 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbgFEXTN (ORCPT ); Fri, 5 Jun 2020 19:19:13 -0400 Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1CC7207D0; Fri, 5 Jun 2020 23:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591399152; bh=pxsClvnIPBaS8ODkk62CMx4DJx6gcP1jIo9ANMgure4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=cWVCuuhZEXopJ/fy8/HaCu7gj+qdiUHK7yyWdnF7I+g00606Q27D/lHhs2F+KUUbI qPalWOJ7gwNYAzD0Zb2lhQotEE4HBkdYrzhA669gi2oRrAkyKg2JRbaRxC86n+xjd9 CZzarVVqj34lwCRUNnhR0Wkc6VA4FmF+zD+p5VbA= Date: Fri, 5 Jun 2020 18:19:09 -0500 From: Bjorn Helgaas To: Zhangfei Gao Cc: Joerg Roedel , Bjorn Helgaas , Arnd Bergmann , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , jean-philippe , Greg Kroah-Hartman , Herbert Xu , kenneth-lee-2012@foxmail.com, Wangzhou , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200605231909.GA1155454@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <779f4044-cf6a-b0d3-916f-0274450c07d3@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 04, 2020 at 09:33:07PM +0800, Zhangfei Gao wrote: > On 2020/6/2 上午1:41, Bjorn Helgaas wrote: > > On Thu, May 28, 2020 at 09:33:44AM +0200, Joerg Roedel wrote: > > > On Wed, May 27, 2020 at 01:18:42PM -0500, Bjorn Helgaas wrote: > > > > Is this slowdown significant? We already iterate over every device > > > > when applying PCI_FIXUP_FINAL quirks, so if we used the existing > > > > PCI_FIXUP_FINAL, we wouldn't be adding a new loop. We would only be > > > > adding two more iterations to the loop in pci_do_fixups() that tries > > > > to match quirks against the current device. I doubt that would be a > > > > measurable slowdown. > > > I don't know how significant it is, but I remember people complaining > > > about adding new PCI quirks because it takes too long for them to run > > > them all. That was in the discussion about the quirk disabling ATS on > > > AMD Stoney systems. > > > > > > So it probably depends on how many PCI devices are in the system whether > > > it causes any measureable slowdown. > > I found this [1] from Paul Menzel, which was a slowdown caused by > > quirk_usb_early_handoff(). I think the real problem is individual > > quirks that take a long time. > > > > The PCI_FIXUP_IOMMU things we're talking about should be fast, and of > > course, they're only run for matching devices anyway. So I'd rather > > keep them as PCI_FIXUP_FINAL than add a whole new phase. > > > Thanks Bjorn for taking time for this. > If so, it would be much simpler. > > +++ b/drivers/iommu/iommu.c > @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct > fwnode_handle *iommu_fwnode, >         fwspec->iommu_fwnode = iommu_fwnode; >         fwspec->ops = ops; >         dev_iommu_fwspec_set(dev, fwspec); > + > +       if (dev_is_pci(dev)) > +               pci_fixup_device(pci_fixup_final, to_pci_dev(dev)); > + > > Then pci_fixup_final will be called twice, the first in pci_bus_add_device. > Here in iommu_fwspec_init is the second time, specifically for iommu_fwspec. > Will send this when 5.8-rc1 is open. Wait, this whole fixup approach seems wrong to me. No matter how you do the fixup, it's still a fixup, which means it requires ongoing maintenance. Surely we don't want to have to add the Vendor/Device ID for every new AMBA device that comes along, do we? Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 537ACC433DF for ; Fri, 5 Jun 2020 23:19:17 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 240B1207D5 for ; Fri, 5 Jun 2020 23:19:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cWVCuuhZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 240B1207D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id EFCF386D81; Fri, 5 Jun 2020 23:19:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m+vdD6jF4SXK; Fri, 5 Jun 2020 23:19:15 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 456738683A; Fri, 5 Jun 2020 23:19:15 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 2A59AC0888; Fri, 5 Jun 2020 23:19:15 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E1D07C016E for ; Fri, 5 Jun 2020 23:19:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id AC65525AB8 for ; Fri, 5 Jun 2020 23:19:13 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ur5IizjfeQwH for ; Fri, 5 Jun 2020 23:19:12 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id A8ADF258C4 for ; Fri, 5 Jun 2020 23:19:12 +0000 (UTC) Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1CC7207D0; Fri, 5 Jun 2020 23:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591399152; bh=pxsClvnIPBaS8ODkk62CMx4DJx6gcP1jIo9ANMgure4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=cWVCuuhZEXopJ/fy8/HaCu7gj+qdiUHK7yyWdnF7I+g00606Q27D/lHhs2F+KUUbI qPalWOJ7gwNYAzD0Zb2lhQotEE4HBkdYrzhA669gi2oRrAkyKg2JRbaRxC86n+xjd9 CZzarVVqj34lwCRUNnhR0Wkc6VA4FmF+zD+p5VbA= Date: Fri, 5 Jun 2020 18:19:09 -0500 From: Bjorn Helgaas To: Zhangfei Gao Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200605231909.GA1155454@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <779f4044-cf6a-b0d3-916f-0274450c07d3@linaro.org> Cc: jean-philippe , Herbert Xu , Arnd Bergmann , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Hanjun Guo , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, linux-crypto@vger.kernel.org, Sudeep Holla , Bjorn Helgaas , kenneth-lee-2012@foxmail.com, linux-arm-kernel@lists.infradead.org, Len Brown X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVGh1LCBKdW4gMDQsIDIwMjAgYXQgMDk6MzM6MDdQTSArMDgwMCwgWmhhbmdmZWkgR2FvIHdy b3RlOgo+IE9uIDIwMjAvNi8yIOS4iuWNiDE6NDEsIEJqb3JuIEhlbGdhYXMgd3JvdGU6Cj4gPiBP biBUaHUsIE1heSAyOCwgMjAyMCBhdCAwOTozMzo0NEFNICswMjAwLCBKb2VyZyBSb2VkZWwgd3Jv dGU6Cj4gPiA+IE9uIFdlZCwgTWF5IDI3LCAyMDIwIGF0IDAxOjE4OjQyUE0gLTA1MDAsIEJqb3Ju IEhlbGdhYXMgd3JvdGU6Cj4gPiA+ID4gSXMgdGhpcyBzbG93ZG93biBzaWduaWZpY2FudD8gIFdl IGFscmVhZHkgaXRlcmF0ZSBvdmVyIGV2ZXJ5IGRldmljZQo+ID4gPiA+IHdoZW4gYXBwbHlpbmcg UENJX0ZJWFVQX0ZJTkFMIHF1aXJrcywgc28gaWYgd2UgdXNlZCB0aGUgZXhpc3RpbmcKPiA+ID4g PiBQQ0lfRklYVVBfRklOQUwsIHdlIHdvdWxkbid0IGJlIGFkZGluZyBhIG5ldyBsb29wLiAgV2Ug d291bGQgb25seSBiZQo+ID4gPiA+IGFkZGluZyB0d28gbW9yZSBpdGVyYXRpb25zIHRvIHRoZSBs b29wIGluIHBjaV9kb19maXh1cHMoKSB0aGF0IHRyaWVzCj4gPiA+ID4gdG8gbWF0Y2ggcXVpcmtz IGFnYWluc3QgdGhlIGN1cnJlbnQgZGV2aWNlLiAgSSBkb3VidCB0aGF0IHdvdWxkIGJlIGEKPiA+ ID4gPiBtZWFzdXJhYmxlIHNsb3dkb3duLgo+ID4gPiBJIGRvbid0IGtub3cgaG93IHNpZ25pZmlj YW50IGl0IGlzLCBidXQgSSByZW1lbWJlciBwZW9wbGUgY29tcGxhaW5pbmcKPiA+ID4gYWJvdXQg YWRkaW5nIG5ldyBQQ0kgcXVpcmtzIGJlY2F1c2UgaXQgdGFrZXMgdG9vIGxvbmcgZm9yIHRoZW0g dG8gcnVuCj4gPiA+IHRoZW0gYWxsLiBUaGF0IHdhcyBpbiB0aGUgZGlzY3Vzc2lvbiBhYm91dCB0 aGUgcXVpcmsgZGlzYWJsaW5nIEFUUyBvbgo+ID4gPiBBTUQgU3RvbmV5IHN5c3RlbXMuCj4gPiA+ IAo+ID4gPiBTbyBpdCBwcm9iYWJseSBkZXBlbmRzIG9uIGhvdyBtYW55IFBDSSBkZXZpY2VzIGFy ZSBpbiB0aGUgc3lzdGVtIHdoZXRoZXIKPiA+ID4gaXQgY2F1c2VzIGFueSBtZWFzdXJlYWJsZSBz bG93ZG93bi4KPiA+IEkgZm91bmQgdGhpcyBbMV0gZnJvbSBQYXVsIE1lbnplbCwgd2hpY2ggd2Fz IGEgc2xvd2Rvd24gY2F1c2VkIGJ5Cj4gPiBxdWlya191c2JfZWFybHlfaGFuZG9mZigpLiAgSSB0 aGluayB0aGUgcmVhbCBwcm9ibGVtIGlzIGluZGl2aWR1YWwKPiA+IHF1aXJrcyB0aGF0IHRha2Ug YSBsb25nIHRpbWUuCj4gPiAKPiA+IFRoZSBQQ0lfRklYVVBfSU9NTVUgdGhpbmdzIHdlJ3JlIHRh bGtpbmcgYWJvdXQgc2hvdWxkIGJlIGZhc3QsIGFuZCBvZgo+ID4gY291cnNlLCB0aGV5J3JlIG9u bHkgcnVuIGZvciBtYXRjaGluZyBkZXZpY2VzIGFueXdheS4gIFNvIEknZCByYXRoZXIKPiA+IGtl ZXAgdGhlbSBhcyBQQ0lfRklYVVBfRklOQUwgdGhhbiBhZGQgYSB3aG9sZSBuZXcgcGhhc2UuCj4g PiAKPiBUaGFua3MgQmpvcm4gZm9yIHRha2luZyB0aW1lIGZvciB0aGlzLgo+IElmIHNvLCBpdCB3 b3VsZCBiZSBtdWNoIHNpbXBsZXIuCj4gCj4gKysrIGIvZHJpdmVycy9pb21tdS9pb21tdS5jCj4g QEAgLTI0MTgsNiArMjQxOCwxMCBAQCBpbnQgaW9tbXVfZndzcGVjX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QKPiBmd25vZGVfaGFuZGxlICppb21tdV9md25vZGUsCj4gwqDCoMKgwqDC oMKgwqAgZndzcGVjLT5pb21tdV9md25vZGUgPSBpb21tdV9md25vZGU7Cj4gwqDCoMKgwqDCoMKg wqAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gwqDCoMKgwqDCoMKgwqAgZGV2X2lvbW11X2Z3c3BlY19z ZXQoZGV2LCBmd3NwZWMpOwo+ICsKPiArwqDCoMKgwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikp Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGNpX2ZpeHVwX2RldmljZShwY2lfZml4 dXBfZmluYWwsIHRvX3BjaV9kZXYoZGV2KSk7Cj4gKwo+IAo+IFRoZW4gcGNpX2ZpeHVwX2ZpbmFs IHdpbGwgYmUgY2FsbGVkIHR3aWNlLCB0aGUgZmlyc3QgaW4gcGNpX2J1c19hZGRfZGV2aWNlLgo+ IEhlcmUgaW4gaW9tbXVfZndzcGVjX2luaXQgaXMgdGhlIHNlY29uZCB0aW1lLCBzcGVjaWZpY2Fs bHkgZm9yIGlvbW11X2Z3c3BlYy4KPiBXaWxsIHNlbmQgdGhpcyB3aGVuIDUuOC1yYzEgaXMgb3Bl bi4KCldhaXQsIHRoaXMgd2hvbGUgZml4dXAgYXBwcm9hY2ggc2VlbXMgd3JvbmcgdG8gbWUuICBO byBtYXR0ZXIgaG93IHlvdQpkbyB0aGUgZml4dXAsIGl0J3Mgc3RpbGwgYSBmaXh1cCwgd2hpY2gg bWVhbnMgaXQgcmVxdWlyZXMgb25nb2luZwptYWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3 YW50IHRvIGhhdmUgdG8gYWRkIHRoZSBWZW5kb3IvRGV2aWNlIElECmZvciBldmVyeSBuZXcgQU1C QSBkZXZpY2UgdGhhdCBjb21lcyBhbG9uZywgZG8gd2U/CgpCam9ybgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppb21tdSBtYWlsaW5nIGxpc3QKaW9tbXVA bGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24u b3JnL21haWxtYW4vbGlzdGluZm8vaW9tbXU= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D98DC433E0 for ; Fri, 5 Jun 2020 23:19:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E422E207D0 for ; Fri, 5 Jun 2020 23:19:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SYC+32Dz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cWVCuuhZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E422E207D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=xIbj9330DMsfriIhP5R+m/nVrBvHsDmHD/LQTyed3B0=; b=SYC+32Dz68OWzO Iy6PzsEddaLtaXHwzd/6vLH4oamG6ir3Qn/3ubLO2MoURZBh0FWilWQktjgGFNbhULzqhDnKRGEJy hTZY9im0E/YGgYShCxflVgEbAud9LWxQkdwEUhTbslzn4uCYn1a7SnPyjDoE/y6FS1+6AFBSl+PMD CT2/MVYhiMpVT7dzZskk3s6wK/czPa88NKR/UnJRmNh7PSJ962fOhtYIefHGWQvgZirDozibRTmzL y+tXuUwFPUz1K6i/gpoKy7rkLU25tHIOz7gUVc69Vy7xVZx6DyvNmS0kI7PJ2XJJgJNCDHhFSrQHu 4MiEuVpFHiercDc4nVBA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhLcM-000425-Dr; Fri, 05 Jun 2020 23:19:18 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhLcJ-00041X-62 for linux-arm-kernel@lists.infradead.org; Fri, 05 Jun 2020 23:19:16 +0000 Received: from localhost (mobile-166-175-190-200.mycingular.net [166.175.190.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1CC7207D0; Fri, 5 Jun 2020 23:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591399152; bh=pxsClvnIPBaS8ODkk62CMx4DJx6gcP1jIo9ANMgure4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=cWVCuuhZEXopJ/fy8/HaCu7gj+qdiUHK7yyWdnF7I+g00606Q27D/lHhs2F+KUUbI qPalWOJ7gwNYAzD0Zb2lhQotEE4HBkdYrzhA669gi2oRrAkyKg2JRbaRxC86n+xjd9 CZzarVVqj34lwCRUNnhR0Wkc6VA4FmF+zD+p5VbA= Date: Fri, 5 Jun 2020 18:19:09 -0500 From: Bjorn Helgaas To: Zhangfei Gao Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200605231909.GA1155454@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <779f4044-cf6a-b0d3-916f-0274450c07d3@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_161915_263845_F2ABE487 X-CRM114-Status: GOOD ( 23.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe , Lorenzo Pieralisi , Herbert Xu , Arnd Bergmann , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Joerg Roedel , Hanjun Guo , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, linux-acpi@vger.kernel.org, Wangzhou , linux-crypto@vger.kernel.org, Sudeep Holla , Bjorn Helgaas , kenneth-lee-2012@foxmail.com, linux-arm-kernel@lists.infradead.org, Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKdW4gMDQsIDIwMjAgYXQgMDk6MzM6MDdQTSArMDgwMCwgWmhhbmdmZWkgR2FvIHdy b3RlOgo+IE9uIDIwMjAvNi8yIOS4iuWNiDE6NDEsIEJqb3JuIEhlbGdhYXMgd3JvdGU6Cj4gPiBP biBUaHUsIE1heSAyOCwgMjAyMCBhdCAwOTozMzo0NEFNICswMjAwLCBKb2VyZyBSb2VkZWwgd3Jv dGU6Cj4gPiA+IE9uIFdlZCwgTWF5IDI3LCAyMDIwIGF0IDAxOjE4OjQyUE0gLTA1MDAsIEJqb3Ju IEhlbGdhYXMgd3JvdGU6Cj4gPiA+ID4gSXMgdGhpcyBzbG93ZG93biBzaWduaWZpY2FudD8gIFdl IGFscmVhZHkgaXRlcmF0ZSBvdmVyIGV2ZXJ5IGRldmljZQo+ID4gPiA+IHdoZW4gYXBwbHlpbmcg UENJX0ZJWFVQX0ZJTkFMIHF1aXJrcywgc28gaWYgd2UgdXNlZCB0aGUgZXhpc3RpbmcKPiA+ID4g PiBQQ0lfRklYVVBfRklOQUwsIHdlIHdvdWxkbid0IGJlIGFkZGluZyBhIG5ldyBsb29wLiAgV2Ug d291bGQgb25seSBiZQo+ID4gPiA+IGFkZGluZyB0d28gbW9yZSBpdGVyYXRpb25zIHRvIHRoZSBs b29wIGluIHBjaV9kb19maXh1cHMoKSB0aGF0IHRyaWVzCj4gPiA+ID4gdG8gbWF0Y2ggcXVpcmtz IGFnYWluc3QgdGhlIGN1cnJlbnQgZGV2aWNlLiAgSSBkb3VidCB0aGF0IHdvdWxkIGJlIGEKPiA+ ID4gPiBtZWFzdXJhYmxlIHNsb3dkb3duLgo+ID4gPiBJIGRvbid0IGtub3cgaG93IHNpZ25pZmlj YW50IGl0IGlzLCBidXQgSSByZW1lbWJlciBwZW9wbGUgY29tcGxhaW5pbmcKPiA+ID4gYWJvdXQg YWRkaW5nIG5ldyBQQ0kgcXVpcmtzIGJlY2F1c2UgaXQgdGFrZXMgdG9vIGxvbmcgZm9yIHRoZW0g dG8gcnVuCj4gPiA+IHRoZW0gYWxsLiBUaGF0IHdhcyBpbiB0aGUgZGlzY3Vzc2lvbiBhYm91dCB0 aGUgcXVpcmsgZGlzYWJsaW5nIEFUUyBvbgo+ID4gPiBBTUQgU3RvbmV5IHN5c3RlbXMuCj4gPiA+ IAo+ID4gPiBTbyBpdCBwcm9iYWJseSBkZXBlbmRzIG9uIGhvdyBtYW55IFBDSSBkZXZpY2VzIGFy ZSBpbiB0aGUgc3lzdGVtIHdoZXRoZXIKPiA+ID4gaXQgY2F1c2VzIGFueSBtZWFzdXJlYWJsZSBz bG93ZG93bi4KPiA+IEkgZm91bmQgdGhpcyBbMV0gZnJvbSBQYXVsIE1lbnplbCwgd2hpY2ggd2Fz IGEgc2xvd2Rvd24gY2F1c2VkIGJ5Cj4gPiBxdWlya191c2JfZWFybHlfaGFuZG9mZigpLiAgSSB0 aGluayB0aGUgcmVhbCBwcm9ibGVtIGlzIGluZGl2aWR1YWwKPiA+IHF1aXJrcyB0aGF0IHRha2Ug YSBsb25nIHRpbWUuCj4gPiAKPiA+IFRoZSBQQ0lfRklYVVBfSU9NTVUgdGhpbmdzIHdlJ3JlIHRh bGtpbmcgYWJvdXQgc2hvdWxkIGJlIGZhc3QsIGFuZCBvZgo+ID4gY291cnNlLCB0aGV5J3JlIG9u bHkgcnVuIGZvciBtYXRjaGluZyBkZXZpY2VzIGFueXdheS4gIFNvIEknZCByYXRoZXIKPiA+IGtl ZXAgdGhlbSBhcyBQQ0lfRklYVVBfRklOQUwgdGhhbiBhZGQgYSB3aG9sZSBuZXcgcGhhc2UuCj4g PiAKPiBUaGFua3MgQmpvcm4gZm9yIHRha2luZyB0aW1lIGZvciB0aGlzLgo+IElmIHNvLCBpdCB3 b3VsZCBiZSBtdWNoIHNpbXBsZXIuCj4gCj4gKysrIGIvZHJpdmVycy9pb21tdS9pb21tdS5jCj4g QEAgLTI0MTgsNiArMjQxOCwxMCBAQCBpbnQgaW9tbXVfZndzcGVjX2luaXQoc3RydWN0IGRldmlj ZSAqZGV2LCBzdHJ1Y3QKPiBmd25vZGVfaGFuZGxlICppb21tdV9md25vZGUsCj4gwqDCoMKgwqDC oMKgwqAgZndzcGVjLT5pb21tdV9md25vZGUgPSBpb21tdV9md25vZGU7Cj4gwqDCoMKgwqDCoMKg wqAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gwqDCoMKgwqDCoMKgwqAgZGV2X2lvbW11X2Z3c3BlY19z ZXQoZGV2LCBmd3NwZWMpOwo+ICsKPiArwqDCoMKgwqDCoMKgIGlmIChkZXZfaXNfcGNpKGRldikp Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcGNpX2ZpeHVwX2RldmljZShwY2lfZml4 dXBfZmluYWwsIHRvX3BjaV9kZXYoZGV2KSk7Cj4gKwo+IAo+IFRoZW4gcGNpX2ZpeHVwX2ZpbmFs IHdpbGwgYmUgY2FsbGVkIHR3aWNlLCB0aGUgZmlyc3QgaW4gcGNpX2J1c19hZGRfZGV2aWNlLgo+ IEhlcmUgaW4gaW9tbXVfZndzcGVjX2luaXQgaXMgdGhlIHNlY29uZCB0aW1lLCBzcGVjaWZpY2Fs bHkgZm9yIGlvbW11X2Z3c3BlYy4KPiBXaWxsIHNlbmQgdGhpcyB3aGVuIDUuOC1yYzEgaXMgb3Bl bi4KCldhaXQsIHRoaXMgd2hvbGUgZml4dXAgYXBwcm9hY2ggc2VlbXMgd3JvbmcgdG8gbWUuICBO byBtYXR0ZXIgaG93IHlvdQpkbyB0aGUgZml4dXAsIGl0J3Mgc3RpbGwgYSBmaXh1cCwgd2hpY2gg bWVhbnMgaXQgcmVxdWlyZXMgb25nb2luZwptYWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3 YW50IHRvIGhhdmUgdG8gYWRkIHRoZSBWZW5kb3IvRGV2aWNlIElECmZvciBldmVyeSBuZXcgQU1C QSBkZXZpY2UgdGhhdCBjb21lcyBhbG9uZywgZG8gd2U/CgpCam9ybgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=