From: "Denys Dmytriyenko" <denis@denix.org>
To: Joshua Watt <JPEWhacker@gmail.com>
Cc: bitbake-devel@lists.openembedded.org,
openembedded-core@lists.openembedded.org
Subject: Re: [bitbake-devel] [RFC PATCH 0/3] Include mcdepends in signature generation
Date: Fri, 5 Jun 2020 19:54:35 -0400 [thread overview]
Message-ID: <20200605235435.GR17660@denix.org> (raw)
In-Reply-To: <20200605181754.32883-1-JPEWhacker@gmail.com>
Joshua,
I see you've been actively working recently on multiconfig-related fixes in
bitbake, thanks! While at it, would you also be able to take a look at
multiconfig-aware RDEPENDS implementation, as discussed here[1]? Thanks!
[1] https://lists.openembedded.org/g/bitbake-devel/topic/74485221
On Fri, Jun 05, 2020 at 01:17:51PM -0500, Joshua Watt wrote:
> Updates signature generation so that mcdepends are included. Previously,
> they were not which meant that if recipe A mcdepends on recipe B, and
> recipe B changed, it would not automatically cause recipe A to also
> rebuild.
>
> In order for signature generation classes to correctly handle mcdepends,
> they need access to all the data caches, so all are passed instead of
> just the one for the recipe in question.
>
> This breaks the bitbake siggen API and makes it incompatible with
> previous signature generators, hence the cross-posting between bitbake
> and oe-core.
>
> Joshua Watt (3):
> bitbake: siggen: Pass all data caches to hash functions
> bitbake: tests: Add mcdepends test
> sstatesig: Account for all dataCaches being passed
>
> bitbake/lib/bb/runqueue.py | 6 +-
> bitbake/lib/bb/siggen.py | 32 ++++----
> .../lib/bb/tests/runqueue-tests/recipes/f1.bb | 1 +
> bitbake/lib/bb/tests/runqueue.py | 30 ++++++++
> meta/lib/oe/sstatesig.py | 77 ++++++++++---------
> 5 files changed, 89 insertions(+), 57 deletions(-)
> create mode 100644 bitbake/lib/bb/tests/runqueue-tests/recipes/f1.bb
>
> --
> 2.26.2
>
>
next prev parent reply other threads:[~2020-06-05 23:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 18:17 [RFC PATCH 0/3] Include mcdepends in signature generation Joshua Watt
2020-06-05 18:17 ` [RFC PATCH 1/3] bitbake: siggen: Pass all data caches to hash functions Joshua Watt
2020-06-05 18:17 ` [RFC PATCH 2/3] bitbake: tests: Add mcdepends test Joshua Watt
2020-06-05 18:17 ` [RFC PATCH 3/3] sstatesig: Account for all dataCaches being passed Joshua Watt
2020-06-05 23:54 ` Denys Dmytriyenko [this message]
2020-06-10 13:27 ` [bitbake-devel] [RFC PATCH 0/3] Include mcdepends in signature generation Joshua Watt
2020-06-09 18:34 ` [bitbake-devel][PATCH v2 0/2] " Joshua Watt
2020-06-09 18:34 ` [bitbake-devel][PATCH v2 1/2] bitbake: siggen: Pass all data caches to hash functions Joshua Watt
2020-06-09 18:34 ` [bitbake-devel][PATCH v2 2/2] bitbake: tests: Add mcdepends test Joshua Watt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605235435.GR17660@denix.org \
--to=denis@denix.org \
--cc=JPEWhacker@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.