From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F9EFC433DF for ; Mon, 8 Jun 2020 06:23:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A0C22067B for ; Mon, 8 Jun 2020 06:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728804AbgFHGXu (ORCPT ); Mon, 8 Jun 2020 02:23:50 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:53864 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728458AbgFHGXu (ORCPT ); Mon, 8 Jun 2020 02:23:50 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jiBCA-0001X8-Pj; Mon, 08 Jun 2020 16:23:43 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 08 Jun 2020 16:23:42 +1000 Date: Mon, 8 Jun 2020 16:23:42 +1000 From: Herbert Xu To: Eric Biggers Cc: netdev@vger.kernel.org, linux-crypto@vger.kernel.org, Corentin Labbe , Greg Kroah-Hartman , Steffen Klassert Subject: Re: [PATCH net v2] esp: select CRYPTO_SEQIV when useful Message-ID: <20200608062342.GA21732@gondor.apana.org.au> References: <20200605064748.GA595@gondor.apana.org.au> <20200605173931.241085-1-ebiggers@kernel.org> <20200605180023.GF1373@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200605180023.GF1373@sol.localdomain> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jun 05, 2020 at 11:00:23AM -0700, Eric Biggers wrote: > > Oops, this doesn't actually work: > > scripts/kconfig/conf --olddefconfig Kconfig > crypto/Kconfig:1799:error: recursive dependency detected! > crypto/Kconfig:1799: symbol CRYPTO_DRBG_MENU is selected by CRYPTO_RNG_DEFAULT > crypto/Kconfig:83: symbol CRYPTO_RNG_DEFAULT is selected by CRYPTO_SEQIV > crypto/Kconfig:330: symbol CRYPTO_SEQIV is selected by CRYPTO_CTR > crypto/Kconfig:370: symbol CRYPTO_CTR is selected by CRYPTO_DRBG_CTR > crypto/Kconfig:1819: symbol CRYPTO_DRBG_CTR depends on CRYPTO_DRBG_MENU > For a resolution refer to Documentation/kbuild/kconfig-language.rst > subsection "Kconfig recursive dependency limitations" > > I guess we need to go with v1 (which just had 'select CRYPTO_SEQIV'), > or else make users explicitly select CRYPTO_SEQIV? OK, let's just go with the unconditional select on SEQIV since Steffen recommended RFC8221 which lists GCM and CBC as MUST and GCM requires SEQIV to work. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt