From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79B70C433E0 for ; Tue, 9 Jun 2020 00:13:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49D6720775 for ; Tue, 9 Jun 2020 00:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591661586; bh=7AjkuNnUHAomKFcixfNAvXlLVD+ewVcKV2HKY7ByS1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Zm8jOurFP+BuMO53MWy2mIw37vR51UL1WGyfk9ABDySf5oh5kveVraMhpH9V2/hM6 +Yrqc8HZN3z3udry0NBGS/r8uFiY8y3kf+YNNOP/HGiAxgHEno8GbHnsLCtZzWLoU2 N9FSrT/qio7CulPcWIhwU2HaRIjBSmUbUYTQ7E9E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730818AbgFHXTe (ORCPT ); Mon, 8 Jun 2020 19:19:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:36998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729567AbgFHXPv (ORCPT ); Mon, 8 Jun 2020 19:15:51 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2875120659; Mon, 8 Jun 2020 23:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591658150; bh=7AjkuNnUHAomKFcixfNAvXlLVD+ewVcKV2HKY7ByS1o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jKMcNHBgsRCgtBG13ql40VV2fpy2+AM2TisUf/F7kjV6AzrWNi7EhA7CKvZCUqEuU 7xC+mnHAbIsN6E9NYMAZZDwygU9UCeSxHpFbK+Zfr0G22cRBE/+mQ4PTAhveZVAPs1 pmFk19N8CeBMxI5moXkYHENgoVY6IDIppkhHxgM4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wei Yongjun , Hulk Robot , Samuel Iglesias Gonsalvez , Greg Kroah-Hartman , industrypack-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.6 183/606] ipack: tpci200: fix error return code in tpci200_register() Date: Mon, 8 Jun 2020 19:05:08 -0400 Message-Id: <20200608231211.3363633-183-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200608231211.3363633-1-sashal@kernel.org> References: <20200608231211.3363633-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun commit 133317479f0324f6faaf797c4f5f3e9b1b36ce35 upstream. Fix to return negative error code -ENOMEM from the ioremap() error handling case instead of 0, as done elsewhere in this function. Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun Cc: stable Acked-by: Samuel Iglesias Gonsalvez Link: https://lore.kernel.org/r/20200507094237.13599-1-weiyongjun1@huawei.com Signed-off-by: Greg Kroah-Hartman --- drivers/ipack/carriers/tpci200.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ipack/carriers/tpci200.c b/drivers/ipack/carriers/tpci200.c index 23445ebfda5c..ec71063fff76 100644 --- a/drivers/ipack/carriers/tpci200.c +++ b/drivers/ipack/carriers/tpci200.c @@ -306,6 +306,7 @@ static int tpci200_register(struct tpci200_board *tpci200) "(bn 0x%X, sn 0x%X) failed to map driver user space!", tpci200->info->pdev->bus->number, tpci200->info->pdev->devfn); + res = -ENOMEM; goto out_release_mem8_space; } -- 2.25.1