From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887FAC433E1 for ; Tue, 9 Jun 2020 06:23:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D9DD20814 for ; Tue, 9 Jun 2020 06:23:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="FRHRoixS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbgFIGXk (ORCPT ); Tue, 9 Jun 2020 02:23:40 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:16616 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbgFIGXk (ORCPT ); Tue, 9 Jun 2020 02:23:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591683818; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=4+aCPVmw8jrDJQlSPv04BpPt31w8OcaqeOyj/nVXCVU=; b=FRHRoixSKeYKS7HJcB+ZXe4ccNlsdS+GT9H61QOdmpQsbHSvwXGcRAWp8RktW6Qn1xisH3c8 Q+EW+rG1thbmoYyOfv4KzRxXKmzNqvcJlo13TUkkoTLqLMC0MpADM9UyaougN74QmFKYBrhM tRHFBTuQmkYa6dZqA/NEea6LbT0= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n11.prod.us-east-1.postgun.com with SMTP id 5edf2ae98bec50776860c72c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Jun 2020 06:23:37 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 46ABEC433C6; Tue, 9 Jun 2020 06:23:36 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 31652C433C6; Tue, 9 Jun 2020 06:23:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 31652C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths From: Kalle Valo In-Reply-To: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> References: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> To: Evan Green Cc: kuabhs@google.com.org, sujitka@chromium.org, Evan Green , "David S. Miller" , Govind Singh , Jakub Kicinski , Michal Kazior , ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200609062336.46ABEC433C6@smtp.codeaurora.org> Date: Tue, 9 Jun 2020 06:23:36 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Evan Green wrote: > ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock > is held. Acquire the lock in a couple of error paths when calling that > function to ensure this condition is met. > > Fixes: 6421969f248fd ("ath10k: refactor tx pending management") > Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64 descriptor") > Signed-off-by: Evan Green > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. a738e766e3ed ath10k: Acquire tx_lock in tx error paths -- https://patchwork.kernel.org/patch/11588229/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches