From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F69C433DF for ; Tue, 9 Jun 2020 12:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87D1C2083E for ; Tue, 9 Jun 2020 12:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728640AbgFIMzl (ORCPT ); Tue, 9 Jun 2020 08:55:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbgFIMzl (ORCPT ); Tue, 9 Jun 2020 08:55:41 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9C6BC03E97C for ; Tue, 9 Jun 2020 05:55:39 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jidmy-0003t4-Af; Tue, 09 Jun 2020 14:55:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jidmx-0006qd-Il; Tue, 09 Jun 2020 14:55:35 +0200 Date: Tue, 9 Jun 2020 14:55:35 +0200 From: Sascha Hauer To: Andrew Lunn Cc: Russell King , devicetree@vger.kernel.org, kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode Message-ID: <20200609125535.GK11869@pengutronix.de> References: <20200608074716.9975-1-s.hauer@pengutronix.de> <20200608145737.GG1006885@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200608145737.GG1006885@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:27:56 up 110 days, 19:58, 124 users, load average: 0.09, 0.12, 0.13 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 04:57:37PM +0200, Andrew Lunn wrote: > On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > > called DRSGMII. > > > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > > from DT. The MVNETA then configures the SERDES protocol value > > accordingly. > > > > It was successfully tested on a MV78460 connected to a FPGA. > > Hi Sascha > > Is this really overclocked SGMII, or 2500BaseX? How does it differ > from 2500BaseX, which mvneta already supports? I think it is overclocked SGMII or 2500BaseX depending on the Port MAC Control Register0 PortType setting bit. As said to Russell we have a fixed link so nobody really cares if it's SGMII or 2500BaseX. This boils down the patch to fixing the Serdes configuration setting for 2500BaseX. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA018C433E0 for ; Tue, 9 Jun 2020 12:55:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E41C206A4 for ; Tue, 9 Jun 2020 12:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YsEHRnU4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E41C206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RVVEhsVnItBPu7aJmhP+SqLevTvulZLxMkR5HvOLlk0=; b=YsEHRnU43GaWtv k+VuxTG8qASRZqBpFh1N/F8w1NqPL49Yz5CJUulc/2o+WnoBa0LNWTxghThSMdx+H9xc3S/qBPt7X fj5KgDGPmUpumYY/M2hmDsU7x8FBQ8PmCGolOXM+HSHgSRGDVFRgibDb7Iq0L+NpfmruWjbj5ohzs H7CCBbWXVA7TA0FYrKHAkKseiIdkF0HAEREARli2mY3pNSmUJMDB/J/c8drm3whEgtNQ251+e9gal M7Z3o5ylVn87DP+2EhN05laA8Ad1jUnSJTibCpRnCQahGWdKEh+1WJesikQDiKWn4p7dJ46Uue9rP 7rEMDvq96ShI1KJMm63w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidn5-0008Ue-MJ; Tue, 09 Jun 2020 12:55:43 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jidn3-0008Ty-Gz for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 12:55:42 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jidmy-0003t4-Af; Tue, 09 Jun 2020 14:55:36 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jidmx-0006qd-Il; Tue, 09 Jun 2020 14:55:35 +0200 Date: Tue, 9 Jun 2020 14:55:35 +0200 From: Sascha Hauer To: Andrew Lunn Subject: Re: [PATCH] net: ethernet: mvneta: add support for 2.5G DRSGMII mode Message-ID: <20200609125535.GK11869@pengutronix.de> References: <20200608074716.9975-1-s.hauer@pengutronix.de> <20200608145737.GG1006885@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200608145737.GG1006885@lunn.ch> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:27:56 up 110 days, 19:58, 124 users, load average: 0.09, 0.12, 0.13 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_055541_559944_48CEF1CB X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 08, 2020 at 04:57:37PM +0200, Andrew Lunn wrote: > On Mon, Jun 08, 2020 at 09:47:16AM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5 Gbps SGMII mode > > called DRSGMII. > > > > This patch adds a corresponding phy-mode string 'drsgmii' and parses it > > from DT. The MVNETA then configures the SERDES protocol value > > accordingly. > > > > It was successfully tested on a MV78460 connected to a FPGA. > > Hi Sascha > > Is this really overclocked SGMII, or 2500BaseX? How does it differ > from 2500BaseX, which mvneta already supports? I think it is overclocked SGMII or 2500BaseX depending on the Port MAC Control Register0 PortType setting bit. As said to Russell we have a fixed link so nobody really cares if it's SGMII or 2500BaseX. This boils down the patch to fixing the Serdes configuration setting for 2500BaseX. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel