From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function
Date: Tue, 09 Jun 2020 14:38:21 +0800 [thread overview]
Message-ID: <202006091427.S7iDIR6W%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3196 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200608193917.13084-13-dmurphy@ti.com>
References: <20200608193917.13084-13-dmurphy@ti.com>
TO: Dan Murphy <dmurphy@ti.com>
TO: jacek.anaszewski(a)gmail.com
TO: pavel(a)ucw.cz
CC: devicetree(a)vger.kernel.org
CC: linux-leds(a)vger.kernel.org
CC: linux-kernel(a)vger.kernel.org
CC: Dan Murphy <dmurphy@ti.com>
Hi Dan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pavel-linux-leds/for-next]
[also build test WARNING on robh/for-next v5.7 next-20200608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dan-Murphy/Multicolor-Framework-v27/20200609-034319
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago
config: x86_64-randconfig-m001-20200607 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/leds/leds-lp5523.c:810 lp5523_multicolor_brightness() error: uninitialized symbol 'ret'.
# https://github.com/0day-ci/linux/commit/9e1a8e50ad52b8552435409f69eed2d3155e903c
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 9e1a8e50ad52b8552435409f69eed2d3155e903c
vim +/ret +810 drivers/leds/leds-lp5523.c
52da81eafaff13 Toshi Kikuchi 2015-05-11 793
9e1a8e50ad52b8 Dan Murphy 2020-06-08 794 static int lp5523_multicolor_brightness(struct lp55xx_led *led)
9e1a8e50ad52b8 Dan Murphy 2020-06-08 795 {
9e1a8e50ad52b8 Dan Murphy 2020-06-08 796 struct lp55xx_chip *chip = led->chip;
9e1a8e50ad52b8 Dan Murphy 2020-06-08 797 int ret;
9e1a8e50ad52b8 Dan Murphy 2020-06-08 798 int i;
9e1a8e50ad52b8 Dan Murphy 2020-06-08 799
9e1a8e50ad52b8 Dan Murphy 2020-06-08 800 mutex_lock(&chip->lock);
9e1a8e50ad52b8 Dan Murphy 2020-06-08 801 for (i = 0; i < led->mc_cdev.num_colors; i++) {
9e1a8e50ad52b8 Dan Murphy 2020-06-08 802 ret = lp55xx_write(chip,
9e1a8e50ad52b8 Dan Murphy 2020-06-08 803 LP5523_REG_LED_PWM_BASE +
9e1a8e50ad52b8 Dan Murphy 2020-06-08 804 led->mc_cdev.subled_info[i].channel,
9e1a8e50ad52b8 Dan Murphy 2020-06-08 805 led->mc_cdev.subled_info[i].brightness);
9e1a8e50ad52b8 Dan Murphy 2020-06-08 806 if (ret)
9e1a8e50ad52b8 Dan Murphy 2020-06-08 807 break;
9e1a8e50ad52b8 Dan Murphy 2020-06-08 808 }
9e1a8e50ad52b8 Dan Murphy 2020-06-08 809 mutex_unlock(&chip->lock);
9e1a8e50ad52b8 Dan Murphy 2020-06-08 @810 return ret;
9e1a8e50ad52b8 Dan Murphy 2020-06-08 811 }
9e1a8e50ad52b8 Dan Murphy 2020-06-08 812
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36733 bytes --]
next reply other threads:[~2020-06-09 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 6:38 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-08 19:39 [PATCH v27 00/15] Multicolor Framework v27 Dan Murphy
2020-06-08 19:39 ` [PATCH v27 12/15] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006091427.S7iDIR6W%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.