From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFA2C433DF for ; Tue, 9 Jun 2020 16:49:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB4B120737 for ; Tue, 9 Jun 2020 16:49:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591721375; bh=5Q7RvyofmbZbrB/I38g1tWmxg8QS/w1w0oFGJk1TAAE=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=jkZ28BwzAck5PRoltoZMTObaXnV07eqpZHebFNIZsA9nIhDT6L9gggPic/qxV3iv2 e26Qzp8soRwbJNbSPZ2ovQ/nWETJCiQdaLg7ygQ6a1dDu97YasKVULdle0HX+qNWeW gLOHUDpysKrBudj+lUMDikXWVJ1U1Ujd8PpllNOs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731199AbgFIQta (ORCPT ); Tue, 9 Jun 2020 12:49:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:51626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731061AbgFIQt3 (ORCPT ); Tue, 9 Jun 2020 12:49:29 -0400 Received: from localhost (mobile-166-170-222-206.mycingular.net [166.170.222.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D1D420737; Tue, 9 Jun 2020 16:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591721368; bh=5Q7RvyofmbZbrB/I38g1tWmxg8QS/w1w0oFGJk1TAAE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dvG4keriVYERu7ME7jmTxlggF24dPHuT8ZHwsHgyeBv8aHb5TopY1KdfJVDndSoXl RxQiw2j9xiinR8ke3p9Ltba3X4AhyTf4XbSb9RwT2AqKWdKTjRg+cV7DgApD257z37 fAvyNM3ngOAOHRMuIGrK7cGIhRs7rGlN9Hoz8zWA= Date: Tue, 9 Jun 2020 11:49:26 -0500 From: Bjorn Helgaas To: Arnd Bergmann Cc: Zhangfei Gao , Joerg Roedel , Bjorn Helgaas , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , jean-philippe , Greg Kroah-Hartman , Herbert Xu , kenneth-lee-2012@foxmail.com, Wangzhou , "linux-kernel@vger.kernel.org" , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , "open list:IOMMU DRIVERS" , ACPI Devel Maling List , Linux ARM , linux-pci Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200609164926.GA1452092@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 09, 2020 at 11:15:06AM +0200, Arnd Bergmann wrote: > On Tue, Jun 9, 2020 at 6:02 AM Zhangfei Gao wrote: > > On 2020/6/9 上午12:41, Bjorn Helgaas wrote: > > > On Mon, Jun 08, 2020 at 10:54:15AM +0800, Zhangfei Gao wrote: > > >> On 2020/6/6 上午7:19, Bjorn Helgaas wrote: > > >>>> +++ b/drivers/iommu/iommu.c > > >>>> @@ -2418,6 +2418,10 @@ int iommu_fwspec_init(struct device *dev, struct > > >>>> fwnode_handle *iommu_fwnode, > > >>>> fwspec->iommu_fwnode = iommu_fwnode; > > >>>> fwspec->ops = ops; > > >>>> dev_iommu_fwspec_set(dev, fwspec); > > >>>> + > > >>>> + if (dev_is_pci(dev)) > > >>>> + pci_fixup_device(pci_fixup_final, to_pci_dev(dev)); > > >>>> + > > >>>> > > >>>> Then pci_fixup_final will be called twice, the first in pci_bus_add_device. > > >>>> Here in iommu_fwspec_init is the second time, specifically for iommu_fwspec. > > >>>> Will send this when 5.8-rc1 is open. > > >>> Wait, this whole fixup approach seems wrong to me. No matter how you > > >>> do the fixup, it's still a fixup, which means it requires ongoing > > >>> maintenance. Surely we don't want to have to add the Vendor/Device ID > > >>> for every new AMBA device that comes along, do we? > > >>> > > >> Here the fake pci device has standard PCI cfg space, but physical > > >> implementation is base on AMBA > > >> They can provide pasid feature. > > >> However, > > >> 1, does not support tlp since they are not real pci devices. > > >> 2. does not support pri, instead support stall (provided by smmu) > > >> And stall is not a pci feature, so it is not described in struct pci_dev, > > >> but in struct iommu_fwspec. > > >> So we use this fixup to tell pci system that the devices can support stall, > > >> and hereby support pasid. > > > This did not answer my question. Are you proposing that we update a > > > quirk every time a new AMBA device is released? I don't think that > > > would be a good model. > > > > Yes, you are right, but we do not have any better idea yet. > > Currently we have three fake pci devices, which support stall and pasid. > > We have to let pci system know the device can support pasid, because of > > stall feature, though not support pri. > > Do you have any other ideas? > > It sounds like the best way would be to allocate a PCI capability for it, so > detection can be done through config space, at least in future devices, > or possibly after a firmware update if the config space in your system > is controlled by firmware somewhere. Once there is a proper mechanism > to do this, using fixups to detect the early devices that don't use that > should be uncontroversial. I have no idea what the process or timeline > is to add new capabilities into the PCIe specification, or if this one > would be acceptable to the PCI SIG at all. That sounds like a possibility. The spec already defines a Vendor-Specific Extended Capability (PCIe r5.0, sec 7.9.5) that might be a candidate. > If detection cannot be done through PCI config space, the next best > alternative is to pass auxiliary data through firmware. On DT based > machines, you can list non-hotpluggable PCIe devices and add custom > properties that could be read during device enumeration. I assume > ACPI has something similar, but I have not done that. ACPI has _DSM (ACPI v6.3, sec 9.1.1), which might be a candidate. I like this better than a PCI capability because the property you need to expose is not a PCI property. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9BB8C433E0 for ; Tue, 9 Jun 2020 16:49:34 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8ABDA2078C for ; Tue, 9 Jun 2020 16:49:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dvG4keri" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8ABDA2078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 646B6873E3; Tue, 9 Jun 2020 16:49:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2CrKLHm70-q6; Tue, 9 Jun 2020 16:49:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id C2C68873AD; Tue, 9 Jun 2020 16:49:31 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B5A2EC088C; Tue, 9 Jun 2020 16:49:31 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0CAE3C016F for ; Tue, 9 Jun 2020 16:49:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id E892D873BB for ; Tue, 9 Jun 2020 16:49:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UQetAyMrlk6V for ; Tue, 9 Jun 2020 16:49:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id D5C3F873AD for ; Tue, 9 Jun 2020 16:49:28 +0000 (UTC) Received: from localhost (mobile-166-170-222-206.mycingular.net [166.170.222.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D1D420737; Tue, 9 Jun 2020 16:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591721368; bh=5Q7RvyofmbZbrB/I38g1tWmxg8QS/w1w0oFGJk1TAAE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dvG4keriVYERu7ME7jmTxlggF24dPHuT8ZHwsHgyeBv8aHb5TopY1KdfJVDndSoXl RxQiw2j9xiinR8ke3p9Ltba3X4AhyTf4XbSb9RwT2AqKWdKTjRg+cV7DgApD257z37 fAvyNM3ngOAOHRMuIGrK7cGIhRs7rGlN9Hoz8zWA= Date: Tue, 9 Jun 2020 11:49:26 -0500 From: Bjorn Helgaas To: Arnd Bergmann Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200609164926.GA1452092@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: jean-philippe , Herbert Xu , linux-pci , Greg Kroah-Hartman , Hanjun Guo , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:IOMMU DRIVERS" , kenneth-lee-2012@foxmail.com, ACPI Devel Maling List , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Sudeep Holla , Bjorn Helgaas , Zhangfei Gao , Linux ARM , Len Brown X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gVHVlLCBKdW4gMDksIDIwMjAgYXQgMTE6MTU6MDZBTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBUdWUsIEp1biA5LCAyMDIwIGF0IDY6MDIgQU0gWmhhbmdmZWkgR2FvIDx6aGFu Z2ZlaS5nYW9AbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiBPbiAyMDIwLzYvOSDkuIrljYgxMjo0MSwg Qmpvcm4gSGVsZ2FhcyB3cm90ZToKPiA+ID4gT24gTW9uLCBKdW4gMDgsIDIwMjAgYXQgMTA6NTQ6 MTVBTSArMDgwMCwgWmhhbmdmZWkgR2FvIHdyb3RlOgo+ID4gPj4gT24gMjAyMC82LzYg5LiK5Y2I NzoxOSwgQmpvcm4gSGVsZ2FhcyB3cm90ZToKPiA+ID4+Pj4gKysrIGIvZHJpdmVycy9pb21tdS9p b21tdS5jCj4gPiA+Pj4+IEBAIC0yNDE4LDYgKzI0MTgsMTAgQEAgaW50IGlvbW11X2Z3c3BlY19p bml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0Cj4gPiA+Pj4+IGZ3bm9kZV9oYW5kbGUgKmlv bW11X2Z3bm9kZSwKPiA+ID4+Pj4gICAgICAgICAgIGZ3c3BlYy0+aW9tbXVfZndub2RlID0gaW9t bXVfZndub2RlOwo+ID4gPj4+PiAgICAgICAgICAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gPiA+Pj4+ ICAgICAgICAgICBkZXZfaW9tbXVfZndzcGVjX3NldChkZXYsIGZ3c3BlYyk7Cj4gPiA+Pj4+ICsK PiA+ID4+Pj4gKyAgICAgICBpZiAoZGV2X2lzX3BjaShkZXYpKQo+ID4gPj4+PiArICAgICAgICAg ICAgICAgcGNpX2ZpeHVwX2RldmljZShwY2lfZml4dXBfZmluYWwsIHRvX3BjaV9kZXYoZGV2KSk7 Cj4gPiA+Pj4+ICsKPiA+ID4+Pj4KPiA+ID4+Pj4gVGhlbiBwY2lfZml4dXBfZmluYWwgd2lsbCBi ZSBjYWxsZWQgdHdpY2UsIHRoZSBmaXJzdCBpbiBwY2lfYnVzX2FkZF9kZXZpY2UuCj4gPiA+Pj4+ IEhlcmUgaW4gaW9tbXVfZndzcGVjX2luaXQgaXMgdGhlIHNlY29uZCB0aW1lLCBzcGVjaWZpY2Fs bHkgZm9yIGlvbW11X2Z3c3BlYy4KPiA+ID4+Pj4gV2lsbCBzZW5kIHRoaXMgd2hlbiA1LjgtcmMx IGlzIG9wZW4uCj4gPiA+Pj4gV2FpdCwgdGhpcyB3aG9sZSBmaXh1cCBhcHByb2FjaCBzZWVtcyB3 cm9uZyB0byBtZS4gIE5vIG1hdHRlciBob3cgeW91Cj4gPiA+Pj4gZG8gdGhlIGZpeHVwLCBpdCdz IHN0aWxsIGEgZml4dXAsIHdoaWNoIG1lYW5zIGl0IHJlcXVpcmVzIG9uZ29pbmcKPiA+ID4+PiBt YWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gYWRkIHRoZSBWZW5k b3IvRGV2aWNlIElECj4gPiA+Pj4gZm9yIGV2ZXJ5IG5ldyBBTUJBIGRldmljZSB0aGF0IGNvbWVz IGFsb25nLCBkbyB3ZT8KPiA+ID4+Pgo+ID4gPj4gSGVyZSB0aGUgZmFrZSBwY2kgZGV2aWNlIGhh cyBzdGFuZGFyZCBQQ0kgY2ZnIHNwYWNlLCBidXQgcGh5c2ljYWwKPiA+ID4+IGltcGxlbWVudGF0 aW9uIGlzIGJhc2Ugb24gQU1CQQo+ID4gPj4gVGhleSBjYW4gcHJvdmlkZSBwYXNpZCBmZWF0dXJl Lgo+ID4gPj4gSG93ZXZlciwKPiA+ID4+IDEsIGRvZXMgbm90IHN1cHBvcnQgdGxwIHNpbmNlIHRo ZXkgYXJlIG5vdCByZWFsIHBjaSBkZXZpY2VzLgo+ID4gPj4gMi4gZG9lcyBub3Qgc3VwcG9ydCBw cmksIGluc3RlYWQgc3VwcG9ydCBzdGFsbCAocHJvdmlkZWQgYnkgc21tdSkKPiA+ID4+IEFuZCBz dGFsbCBpcyBub3QgYSBwY2kgZmVhdHVyZSwgc28gaXQgaXMgbm90IGRlc2NyaWJlZCBpbiBzdHJ1 Y3QgcGNpX2RldiwKPiA+ID4+IGJ1dCBpbiBzdHJ1Y3QgaW9tbXVfZndzcGVjLgo+ID4gPj4gU28g d2UgdXNlIHRoaXMgZml4dXAgdG8gdGVsbCBwY2kgc3lzdGVtIHRoYXQgdGhlIGRldmljZXMgY2Fu IHN1cHBvcnQgc3RhbGwsCj4gPiA+PiBhbmQgaGVyZWJ5IHN1cHBvcnQgcGFzaWQuCj4gPiA+IFRo aXMgZGlkIG5vdCBhbnN3ZXIgbXkgcXVlc3Rpb24uICBBcmUgeW91IHByb3Bvc2luZyB0aGF0IHdl IHVwZGF0ZSBhCj4gPiA+IHF1aXJrIGV2ZXJ5IHRpbWUgYSBuZXcgQU1CQSBkZXZpY2UgaXMgcmVs ZWFzZWQ/ICBJIGRvbid0IHRoaW5rIHRoYXQKPiA+ID4gd291bGQgYmUgYSBnb29kIG1vZGVsLgo+ ID4KPiA+IFllcywgeW91IGFyZSByaWdodCwgYnV0IHdlIGRvIG5vdCBoYXZlIGFueSBiZXR0ZXIg aWRlYSB5ZXQuCj4gPiBDdXJyZW50bHkgd2UgaGF2ZSB0aHJlZSBmYWtlIHBjaSBkZXZpY2VzLCB3 aGljaCBzdXBwb3J0IHN0YWxsIGFuZCBwYXNpZC4KPiA+IFdlIGhhdmUgdG8gbGV0IHBjaSBzeXN0 ZW0ga25vdyB0aGUgZGV2aWNlIGNhbiBzdXBwb3J0IHBhc2lkLCBiZWNhdXNlIG9mCj4gPiBzdGFs bCBmZWF0dXJlLCB0aG91Z2ggbm90IHN1cHBvcnQgcHJpLgo+ID4gRG8geW91IGhhdmUgYW55IG90 aGVyIGlkZWFzPwo+IAo+IEl0IHNvdW5kcyBsaWtlIHRoZSBiZXN0IHdheSB3b3VsZCBiZSB0byBh bGxvY2F0ZSBhIFBDSSBjYXBhYmlsaXR5IGZvciBpdCwgc28KPiBkZXRlY3Rpb24gY2FuIGJlIGRv bmUgdGhyb3VnaCBjb25maWcgc3BhY2UsIGF0IGxlYXN0IGluIGZ1dHVyZSBkZXZpY2VzLAo+IG9y IHBvc3NpYmx5IGFmdGVyIGEgZmlybXdhcmUgdXBkYXRlIGlmIHRoZSBjb25maWcgc3BhY2UgaW4g eW91ciBzeXN0ZW0KPiBpcyBjb250cm9sbGVkIGJ5IGZpcm13YXJlIHNvbWV3aGVyZS4gIE9uY2Ug dGhlcmUgaXMgYSBwcm9wZXIgbWVjaGFuaXNtCj4gdG8gZG8gdGhpcywgdXNpbmcgZml4dXBzIHRv IGRldGVjdCB0aGUgZWFybHkgZGV2aWNlcyB0aGF0IGRvbid0IHVzZSB0aGF0Cj4gc2hvdWxkIGJl IHVuY29udHJvdmVyc2lhbC4gSSBoYXZlIG5vIGlkZWEgd2hhdCB0aGUgcHJvY2VzcyBvciB0aW1l bGluZQo+IGlzIHRvIGFkZCBuZXcgY2FwYWJpbGl0aWVzIGludG8gdGhlIFBDSWUgc3BlY2lmaWNh dGlvbiwgb3IgaWYgdGhpcyBvbmUKPiB3b3VsZCBiZSBhY2NlcHRhYmxlIHRvIHRoZSBQQ0kgU0lH IGF0IGFsbC4KClRoYXQgc291bmRzIGxpa2UgYSBwb3NzaWJpbGl0eS4gIFRoZSBzcGVjIGFscmVh ZHkgZGVmaW5lcyBhClZlbmRvci1TcGVjaWZpYyBFeHRlbmRlZCBDYXBhYmlsaXR5IChQQ0llIHI1 LjAsIHNlYyA3LjkuNSkgdGhhdCBtaWdodApiZSBhIGNhbmRpZGF0ZS4KCj4gSWYgZGV0ZWN0aW9u IGNhbm5vdCBiZSBkb25lIHRocm91Z2ggUENJIGNvbmZpZyBzcGFjZSwgdGhlIG5leHQgYmVzdAo+ IGFsdGVybmF0aXZlIGlzIHRvIHBhc3MgYXV4aWxpYXJ5IGRhdGEgdGhyb3VnaCBmaXJtd2FyZS4g T24gRFQgYmFzZWQKPiBtYWNoaW5lcywgeW91IGNhbiBsaXN0IG5vbi1ob3RwbHVnZ2FibGUgUENJ ZSBkZXZpY2VzIGFuZCBhZGQgY3VzdG9tCj4gcHJvcGVydGllcyB0aGF0IGNvdWxkIGJlIHJlYWQg ZHVyaW5nIGRldmljZSBlbnVtZXJhdGlvbi4gSSBhc3N1bWUKPiBBQ1BJIGhhcyBzb21ldGhpbmcg c2ltaWxhciwgYnV0IEkgaGF2ZSBub3QgZG9uZSB0aGF0LgoKQUNQSSBoYXMgX0RTTSAoQUNQSSB2 Ni4zLCBzZWMgOS4xLjEpLCB3aGljaCBtaWdodCBiZSBhIGNhbmRpZGF0ZS4gIEkKbGlrZSB0aGlz IGJldHRlciB0aGFuIGEgUENJIGNhcGFiaWxpdHkgYmVjYXVzZSB0aGUgcHJvcGVydHkgeW91IG5l ZWQKdG8gZXhwb3NlIGlzIG5vdCBhIFBDSSBwcm9wZXJ0eS4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3Rz LmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F436C433E3 for ; Tue, 9 Jun 2020 16:49:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E577E20737 for ; Tue, 9 Jun 2020 16:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="p6/iXswM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="dvG4keri" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E577E20737 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=BGsisdBu6NnSvU3QoWlF+ggJe8dnjVEWxiALuLcfbBU=; b=p6/iXswMVPon3y UsDEOseFdbCA2lnuekFgqH1X1LXHYUIFyW27N7oTSOs/kfqUmEEbihCtcoCVL1QTKAg2SkS0qNHho lzycxfl1SvkjgtuBPD82uTTij0PeQTmBCokO7DM4oLJgHHFNr16gfMalERuOVzDklA2udkYR773ck ZupXPhCwmj8f+QaE3JbLgiqzszVCCyO644KEvwupIrnK3MbMqhKWf+DEFC6zJ17XRH9dd/1vpqH4t D3rqiHES9ts5Gstd230FlAN0EtgvZxIe0K3589bmtICNPqsjMZDw2/GQN7xVvwDnqG9Z+MOuQfEYP Crr6VALAhtGoUZo26MRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jihRM-0008Kx-NU; Tue, 09 Jun 2020 16:49:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jihRJ-0008KR-Go for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 16:49:30 +0000 Received: from localhost (mobile-166-170-222-206.mycingular.net [166.170.222.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D1D420737; Tue, 9 Jun 2020 16:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591721368; bh=5Q7RvyofmbZbrB/I38g1tWmxg8QS/w1w0oFGJk1TAAE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dvG4keriVYERu7ME7jmTxlggF24dPHuT8ZHwsHgyeBv8aHb5TopY1KdfJVDndSoXl RxQiw2j9xiinR8ke3p9Ltba3X4AhyTf4XbSb9RwT2AqKWdKTjRg+cV7DgApD257z37 fAvyNM3ngOAOHRMuIGrK7cGIhRs7rGlN9Hoz8zWA= Date: Tue, 9 Jun 2020 11:49:26 -0500 From: Bjorn Helgaas To: Arnd Bergmann Subject: Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU Message-ID: <20200609164926.GA1452092@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_094929_597939_F02101CE X-CRM114-Status: GOOD ( 27.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jean-philippe , Lorenzo Pieralisi , Herbert Xu , linux-pci , Greg Kroah-Hartman , Joerg Roedel , Hanjun Guo , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "open list:IOMMU DRIVERS" , kenneth-lee-2012@foxmail.com, ACPI Devel Maling List , Wangzhou , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Sudeep Holla , Bjorn Helgaas , Zhangfei Gao , Linux ARM , Len Brown Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMDksIDIwMjAgYXQgMTE6MTU6MDZBTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBPbiBUdWUsIEp1biA5LCAyMDIwIGF0IDY6MDIgQU0gWmhhbmdmZWkgR2FvIDx6aGFu Z2ZlaS5nYW9AbGluYXJvLm9yZz4gd3JvdGU6Cj4gPiBPbiAyMDIwLzYvOSDkuIrljYgxMjo0MSwg Qmpvcm4gSGVsZ2FhcyB3cm90ZToKPiA+ID4gT24gTW9uLCBKdW4gMDgsIDIwMjAgYXQgMTA6NTQ6 MTVBTSArMDgwMCwgWmhhbmdmZWkgR2FvIHdyb3RlOgo+ID4gPj4gT24gMjAyMC82LzYg5LiK5Y2I NzoxOSwgQmpvcm4gSGVsZ2FhcyB3cm90ZToKPiA+ID4+Pj4gKysrIGIvZHJpdmVycy9pb21tdS9p b21tdS5jCj4gPiA+Pj4+IEBAIC0yNDE4LDYgKzI0MTgsMTAgQEAgaW50IGlvbW11X2Z3c3BlY19p bml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0Cj4gPiA+Pj4+IGZ3bm9kZV9oYW5kbGUgKmlv bW11X2Z3bm9kZSwKPiA+ID4+Pj4gICAgICAgICAgIGZ3c3BlYy0+aW9tbXVfZndub2RlID0gaW9t bXVfZndub2RlOwo+ID4gPj4+PiAgICAgICAgICAgZndzcGVjLT5vcHMgPSBvcHM7Cj4gPiA+Pj4+ ICAgICAgICAgICBkZXZfaW9tbXVfZndzcGVjX3NldChkZXYsIGZ3c3BlYyk7Cj4gPiA+Pj4+ICsK PiA+ID4+Pj4gKyAgICAgICBpZiAoZGV2X2lzX3BjaShkZXYpKQo+ID4gPj4+PiArICAgICAgICAg ICAgICAgcGNpX2ZpeHVwX2RldmljZShwY2lfZml4dXBfZmluYWwsIHRvX3BjaV9kZXYoZGV2KSk7 Cj4gPiA+Pj4+ICsKPiA+ID4+Pj4KPiA+ID4+Pj4gVGhlbiBwY2lfZml4dXBfZmluYWwgd2lsbCBi ZSBjYWxsZWQgdHdpY2UsIHRoZSBmaXJzdCBpbiBwY2lfYnVzX2FkZF9kZXZpY2UuCj4gPiA+Pj4+ IEhlcmUgaW4gaW9tbXVfZndzcGVjX2luaXQgaXMgdGhlIHNlY29uZCB0aW1lLCBzcGVjaWZpY2Fs bHkgZm9yIGlvbW11X2Z3c3BlYy4KPiA+ID4+Pj4gV2lsbCBzZW5kIHRoaXMgd2hlbiA1LjgtcmMx IGlzIG9wZW4uCj4gPiA+Pj4gV2FpdCwgdGhpcyB3aG9sZSBmaXh1cCBhcHByb2FjaCBzZWVtcyB3 cm9uZyB0byBtZS4gIE5vIG1hdHRlciBob3cgeW91Cj4gPiA+Pj4gZG8gdGhlIGZpeHVwLCBpdCdz IHN0aWxsIGEgZml4dXAsIHdoaWNoIG1lYW5zIGl0IHJlcXVpcmVzIG9uZ29pbmcKPiA+ID4+PiBt YWludGVuYW5jZS4gIFN1cmVseSB3ZSBkb24ndCB3YW50IHRvIGhhdmUgdG8gYWRkIHRoZSBWZW5k b3IvRGV2aWNlIElECj4gPiA+Pj4gZm9yIGV2ZXJ5IG5ldyBBTUJBIGRldmljZSB0aGF0IGNvbWVz IGFsb25nLCBkbyB3ZT8KPiA+ID4+Pgo+ID4gPj4gSGVyZSB0aGUgZmFrZSBwY2kgZGV2aWNlIGhh cyBzdGFuZGFyZCBQQ0kgY2ZnIHNwYWNlLCBidXQgcGh5c2ljYWwKPiA+ID4+IGltcGxlbWVudGF0 aW9uIGlzIGJhc2Ugb24gQU1CQQo+ID4gPj4gVGhleSBjYW4gcHJvdmlkZSBwYXNpZCBmZWF0dXJl Lgo+ID4gPj4gSG93ZXZlciwKPiA+ID4+IDEsIGRvZXMgbm90IHN1cHBvcnQgdGxwIHNpbmNlIHRo ZXkgYXJlIG5vdCByZWFsIHBjaSBkZXZpY2VzLgo+ID4gPj4gMi4gZG9lcyBub3Qgc3VwcG9ydCBw cmksIGluc3RlYWQgc3VwcG9ydCBzdGFsbCAocHJvdmlkZWQgYnkgc21tdSkKPiA+ID4+IEFuZCBz dGFsbCBpcyBub3QgYSBwY2kgZmVhdHVyZSwgc28gaXQgaXMgbm90IGRlc2NyaWJlZCBpbiBzdHJ1 Y3QgcGNpX2RldiwKPiA+ID4+IGJ1dCBpbiBzdHJ1Y3QgaW9tbXVfZndzcGVjLgo+ID4gPj4gU28g d2UgdXNlIHRoaXMgZml4dXAgdG8gdGVsbCBwY2kgc3lzdGVtIHRoYXQgdGhlIGRldmljZXMgY2Fu IHN1cHBvcnQgc3RhbGwsCj4gPiA+PiBhbmQgaGVyZWJ5IHN1cHBvcnQgcGFzaWQuCj4gPiA+IFRo aXMgZGlkIG5vdCBhbnN3ZXIgbXkgcXVlc3Rpb24uICBBcmUgeW91IHByb3Bvc2luZyB0aGF0IHdl IHVwZGF0ZSBhCj4gPiA+IHF1aXJrIGV2ZXJ5IHRpbWUgYSBuZXcgQU1CQSBkZXZpY2UgaXMgcmVs ZWFzZWQ/ICBJIGRvbid0IHRoaW5rIHRoYXQKPiA+ID4gd291bGQgYmUgYSBnb29kIG1vZGVsLgo+ ID4KPiA+IFllcywgeW91IGFyZSByaWdodCwgYnV0IHdlIGRvIG5vdCBoYXZlIGFueSBiZXR0ZXIg aWRlYSB5ZXQuCj4gPiBDdXJyZW50bHkgd2UgaGF2ZSB0aHJlZSBmYWtlIHBjaSBkZXZpY2VzLCB3 aGljaCBzdXBwb3J0IHN0YWxsIGFuZCBwYXNpZC4KPiA+IFdlIGhhdmUgdG8gbGV0IHBjaSBzeXN0 ZW0ga25vdyB0aGUgZGV2aWNlIGNhbiBzdXBwb3J0IHBhc2lkLCBiZWNhdXNlIG9mCj4gPiBzdGFs bCBmZWF0dXJlLCB0aG91Z2ggbm90IHN1cHBvcnQgcHJpLgo+ID4gRG8geW91IGhhdmUgYW55IG90 aGVyIGlkZWFzPwo+IAo+IEl0IHNvdW5kcyBsaWtlIHRoZSBiZXN0IHdheSB3b3VsZCBiZSB0byBh bGxvY2F0ZSBhIFBDSSBjYXBhYmlsaXR5IGZvciBpdCwgc28KPiBkZXRlY3Rpb24gY2FuIGJlIGRv bmUgdGhyb3VnaCBjb25maWcgc3BhY2UsIGF0IGxlYXN0IGluIGZ1dHVyZSBkZXZpY2VzLAo+IG9y IHBvc3NpYmx5IGFmdGVyIGEgZmlybXdhcmUgdXBkYXRlIGlmIHRoZSBjb25maWcgc3BhY2UgaW4g eW91ciBzeXN0ZW0KPiBpcyBjb250cm9sbGVkIGJ5IGZpcm13YXJlIHNvbWV3aGVyZS4gIE9uY2Ug dGhlcmUgaXMgYSBwcm9wZXIgbWVjaGFuaXNtCj4gdG8gZG8gdGhpcywgdXNpbmcgZml4dXBzIHRv IGRldGVjdCB0aGUgZWFybHkgZGV2aWNlcyB0aGF0IGRvbid0IHVzZSB0aGF0Cj4gc2hvdWxkIGJl IHVuY29udHJvdmVyc2lhbC4gSSBoYXZlIG5vIGlkZWEgd2hhdCB0aGUgcHJvY2VzcyBvciB0aW1l bGluZQo+IGlzIHRvIGFkZCBuZXcgY2FwYWJpbGl0aWVzIGludG8gdGhlIFBDSWUgc3BlY2lmaWNh dGlvbiwgb3IgaWYgdGhpcyBvbmUKPiB3b3VsZCBiZSBhY2NlcHRhYmxlIHRvIHRoZSBQQ0kgU0lH IGF0IGFsbC4KClRoYXQgc291bmRzIGxpa2UgYSBwb3NzaWJpbGl0eS4gIFRoZSBzcGVjIGFscmVh ZHkgZGVmaW5lcyBhClZlbmRvci1TcGVjaWZpYyBFeHRlbmRlZCBDYXBhYmlsaXR5IChQQ0llIHI1 LjAsIHNlYyA3LjkuNSkgdGhhdCBtaWdodApiZSBhIGNhbmRpZGF0ZS4KCj4gSWYgZGV0ZWN0aW9u IGNhbm5vdCBiZSBkb25lIHRocm91Z2ggUENJIGNvbmZpZyBzcGFjZSwgdGhlIG5leHQgYmVzdAo+ IGFsdGVybmF0aXZlIGlzIHRvIHBhc3MgYXV4aWxpYXJ5IGRhdGEgdGhyb3VnaCBmaXJtd2FyZS4g T24gRFQgYmFzZWQKPiBtYWNoaW5lcywgeW91IGNhbiBsaXN0IG5vbi1ob3RwbHVnZ2FibGUgUENJ ZSBkZXZpY2VzIGFuZCBhZGQgY3VzdG9tCj4gcHJvcGVydGllcyB0aGF0IGNvdWxkIGJlIHJlYWQg ZHVyaW5nIGRldmljZSBlbnVtZXJhdGlvbi4gSSBhc3N1bWUKPiBBQ1BJIGhhcyBzb21ldGhpbmcg c2ltaWxhciwgYnV0IEkgaGF2ZSBub3QgZG9uZSB0aGF0LgoKQUNQSSBoYXMgX0RTTSAoQUNQSSB2 Ni4zLCBzZWMgOS4xLjEpLCB3aGljaCBtaWdodCBiZSBhIGNhbmRpZGF0ZS4gIEkKbGlrZSB0aGlz IGJldHRlciB0aGFuIGEgUENJIGNhcGFiaWxpdHkgYmVjYXVzZSB0aGUgcHJvcGVydHkgeW91IG5l ZWQKdG8gZXhwb3NlIGlzIG5vdCBhIFBDSSBwcm9wZXJ0eS4KCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK