From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1FB3C433DF for ; Tue, 9 Jun 2020 19:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB17720737 for ; Tue, 9 Jun 2020 19:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YzCXPlKz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389143AbgFITEw (ORCPT ); Tue, 9 Jun 2020 15:04:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730525AbgFITEv (ORCPT ); Tue, 9 Jun 2020 15:04:51 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99C2EC08C5C2 for ; Tue, 9 Jun 2020 12:04:49 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id g10so3837499wmh.4 for ; Tue, 09 Jun 2020 12:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ge3VyoAaZL1/OTneZ+2zUT+PtoEIvR18KepPJWadg9c=; b=YzCXPlKztl5CJV/qwyuSuukBnUr3e+8KLSfzl0TTqnV1Tbrsyld6tNRKD3PrQoU0l9 Sa5fTQ6+C9sRbTX2XaHSoLR1M6k97ZiNwg4wPy8nTgzHmiS6XNuh6V5W6g0utgMwljM5 rzYxOOFmojUpgjLWDRYm6IUeSOsSK+AWPgs4xw9KocaDbKG0yrMIKJJzm2GUeOkmN2Zc kPZljWf/OGSNTRpZJveKQDz5RY+4kFNQNIWjdAb7CZtH+rcPNb6BOf6lC13G7R7mCGEk h5F9TxveHrq1CUWDceH9H+nZ/cLOxU0xOILATOaRfuJRqTysFIz3kwn7j5rR1F494h5I Ukdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ge3VyoAaZL1/OTneZ+2zUT+PtoEIvR18KepPJWadg9c=; b=Nesxt2qVxbREmg/pzUfbubX2QbghmZ6+oSXlzVy6+0UFHUZXOGeBdEa6RuzdFh/z0/ T+9GjThTrV6ES55GhC7+KbrYUdVuD1kbmhI71VILcltr+cm1ud4EPqBZnyCq7IyMDBUD jyvCfKvAwmybwR43xbr5326iwO+XXIu5ta5qwlTd7BFtFEvFuPZR4FnSPXa3Pwmmh3el co/VIx3IQ3wXSwLOVPrh9ekZjzKyuGL9HrgVZX/qMFvXsioDTls6O73FJCnO6xkqw14y gpaYB3eLFsnR8kJ+ofd/6vcvA1gtpuHH4v0BsQLcqTl7a/0+QE6zXs6OVx6jrQAwA/bI SZmQ== X-Gm-Message-State: AOAM531yMoqgsxtsGj/dVHInpg6CCofB2qOdC9omgOlKk7IfdCrrRbYg zcyTYbqoQTqlO7XAb0zFgeLydw== X-Google-Smtp-Source: ABdhPJzN+BygjHAXONePT0Kf4YAs7yH6hesdbbYDOCsdr+huL8ukQ34b+ZD+otUf+KiEJ7FWdD9eJA== X-Received: by 2002:a7b:ce88:: with SMTP id q8mr5410226wmj.176.1591729488213; Tue, 09 Jun 2020 12:04:48 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id g25sm3794436wmh.18.2020.06.09.12.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 12:04:46 -0700 (PDT) Date: Tue, 9 Jun 2020 20:04:45 +0100 From: Lee Jones To: Andy Shevchenko Cc: Michael Walle , Rob Herring , Mark Brown , devicetree , Linux Kernel Mailing List , linux-arm Mailing List , Linus Walleij , Guenter Roeck , Andy Shevchenko , Robin Murphy , GregKroah-Hartmangregkh@linuxfoundation.org Subject: Re: [RFC] MFD's relationship with Device Tree (OF) Message-ID: <20200609190445.GP4106@dell> References: <20200609110136.GJ4106@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Jun 2020, Andy Shevchenko wrote: > On Tue, Jun 9, 2020 at 2:01 PM Lee Jones wrote: > > > > Good morning, > > > > After a number of reports/queries surrounding a known long-term issue > > in the MFD core, including the submission of a couple of attempted > > solutions, I've decided to finally tackle this one myself. > > > > Currently, when a child platform device (sometimes referred to as a > > sub-device) is registered via the Multi-Functional Device (MFD) API, > > the framework attempts to match the newly registered platform device > > with its associated Device Tree (OF) node. Until now, the device has > > been allocated the first node found with an identical OF compatible > > string. Unfortunately, if there are, say for example '3' devices > > which are to be handled by the same driver and therefore have the same > > compatible string, each of them will be allocated a pointer to the > > *first* node. > > > > Let me give you an example. > > > > I have knocked up an example 'parent' and 'child' device driver. The > > parent utilises the MFD API to register 3 identical children, each > > controlled by the same driver. This happens a lot. Fortunately, in > > the majority of cases, the OF nodes are also totally identical, but > > what if you wish to configure one of the child devices with different > > attributes or resources supplied via Device Tree, like a clock? This > > is currently impossible. > > > > Here is the Device Tree representation for the 1 parent and the 3 > > child (sub) devices described above: > > > > parent { > > compatible = "mfd,of-test-parent"; > > > > child@0 { > > compatible = "mfd,of-test-child"; > > clocks = <&clock 0>; > > }; > > > > child@1 { > > compatible = "mfd,of-test-child"; > > clocks = <&clock 1>; > > }; > > > > child@2 { > > compatible = "mfd,of-test-child"; > > clocks = <&clock 2>; > > }; > > }; > > > > This is how we register those devices from MFD: > > > > static const struct mfd_cell mfd_of_test_cell[] = { > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 0, "mfd,of-test-child"), > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 1, "mfd,of-test-child"), > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 2, "mfd,of-test-child") > > }; > > > > ... which we pass into mfd_add_devices() for processing. > > > > In an ideal world. The devices with the platform_id; 0, 1 and 2 would > > be matched up to Device Tree nodes; child@0, child@1 and child@2 > > respectively. Instead all 3 devices will be allocated a pointer to > > child@0's OF node, which is obviously not correct. > > > > This is how it looks when each of the child devices are probed: > > > > [0.708287] mfd-of-test-parent mfd_of_test: Registering 3 devices > > [...] > > [0.712511] mfd-of-test-child mfd_of_test_child.0: Probing platform device: 0 > > [0.712710] mfd-of-test-child mfd_of_test_child.0: Using OF node: child@0 > > [0.713033] mfd-of-test-child mfd_of_test_child.1: Probing platform device: 1 > > [0.713381] mfd-of-test-child mfd_of_test_child.1: Using OF node: child@0 > > [0.713691] mfd-of-test-child mfd_of_test_child.2: Probing platform device: 2 > > [0.713889] mfd-of-test-child mfd_of_test_child.2: Using OF node: child@0 > > > > "Why is it when I change child 2's clock rate, it also changes 0's?" > > > > Whoops! > > > > So in order to fix this, we need to make MFD more-cleverer! > > > > However, this is not so simple. There are some rules we should abide > > by (I use "should" intentionally here, as something might just have to > > give): > > > > a) Since Device Tree is designed to describe hardware, inserting > > arbitrary properties into DT is forbidden. This precludes things > > we would ordinarily be able to match on, like 'id' or 'name'. > > b) As an extension to a) DTs should also be OS agnostic, so > > properties like 'mfd-device', 'mfd-order' etc are also not > > not suitable for inclusion. > > c) The final solution should ideally be capable of supporting both > > newly defined and current trees (without retroactive edits) > > alike. > > d) Existing properties could be used, but not abused. For example, > > one of my suggestions (see below) is to use the 'reg' property. > > This is fine in principle but loading 'reg' with arbitrary values > > (such as; 0, 1, 2 ... x) which 1) clearly do not have anything to > > do with registers and 2) would be meaningless in other OSes/ > > implementations, just to serve our purpose, is to be interpreted > > as an abuse. > > > > Proposal 1: > > > > As mentioned above, my initial thoughts were to use the 'reg' property > > to match an MFD cell entry with the correct DT node. However, not > > all Device Tree nodes have 'reg' properties. Particularly true in the > > case of MFD, where memory resources are usually shared with the parent > > via Regmap, or (as in the case of the ab8500) the MFD handles all > > register transactions via its own API. > > > > Proposal 2: > > > > If we can't guarantee that all DT nodes will have at least one > > property in common to be used for matching and we're prevented from > > supplying additional, potentially bespoke properties, then we must > > seek an alternative procedure. > > > > It should be possible to match based on order. However, the developer > > would have to guarantee that the order in which the child devices are > > presented to the MFD API are in exactly the same order as they are > > represented in the Device Tree. The obvious draw-back to this > > strategy is that it's potentially very fragile. > > > > Current Proposal: > > > > How about a collection of Proposal 1 and Proposal 2? First we could > > attempt a match on the 'reg' property. Then, if that fails, we would > > use the fragile-but-its-all-we-have Proposal 2 as the fall-back. > > > > Thoughts? > > Just a side note, have you considered software nodes on the picture? > You can add properties or additional references to the existing > (firmware) nodes. Is that the properties framework you are trying to replace? Is that different to placing additional attributes into pdata? Using my clock example above, how would one allocate a DT based clock to a child device using properties? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72A02C433DF for ; Tue, 9 Jun 2020 19:05:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2819D2068D for ; Tue, 9 Jun 2020 19:05:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KrUqLigt"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YzCXPlKz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2819D2068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+VGQ0gB+foWRryULxUOKSb/5LpAM/34TG8qdforvZO4=; b=KrUqLigtsXx9y6 UdYNSlZAL1K0iAJJ9Wvz1NfIu5QtX+s3SXkOMtkBJiGN7/dp9Osa1LF02fhHRIbmx7rWea92lUW5V 4Zv5Yry1lXlXSz7yUa+VsRtKm5F2kWXDTJEkcWalS8YjTdkIuy4d2zEj4b0rNhpiQskrwpWQ0cjAT 4dFwMlHMlS1C0o+iIU9yyhq0kvzIUrQ/6G65JMbm8pQpbuUsuWwcDdozyfVTPr1UJqu9Qe/WOaNvd N4k/fTOOkfQM2cOHYtEBDthCbjT3ynslNnr05b5vwIa4CmC3wwipJ/TrSmFyZi2SOnuPGGyiTax80 wOU88aVaZ3jCByjKSEXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jijYL-0003ij-8k; Tue, 09 Jun 2020 19:04:53 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jijYH-0003iD-Ix for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 19:04:51 +0000 Received: by mail-wm1-x344.google.com with SMTP id r9so3850952wmh.2 for ; Tue, 09 Jun 2020 12:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ge3VyoAaZL1/OTneZ+2zUT+PtoEIvR18KepPJWadg9c=; b=YzCXPlKztl5CJV/qwyuSuukBnUr3e+8KLSfzl0TTqnV1Tbrsyld6tNRKD3PrQoU0l9 Sa5fTQ6+C9sRbTX2XaHSoLR1M6k97ZiNwg4wPy8nTgzHmiS6XNuh6V5W6g0utgMwljM5 rzYxOOFmojUpgjLWDRYm6IUeSOsSK+AWPgs4xw9KocaDbKG0yrMIKJJzm2GUeOkmN2Zc kPZljWf/OGSNTRpZJveKQDz5RY+4kFNQNIWjdAb7CZtH+rcPNb6BOf6lC13G7R7mCGEk h5F9TxveHrq1CUWDceH9H+nZ/cLOxU0xOILATOaRfuJRqTysFIz3kwn7j5rR1F494h5I Ukdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ge3VyoAaZL1/OTneZ+2zUT+PtoEIvR18KepPJWadg9c=; b=DC7rBgLQGH4OZJd8FVwmpae8fdx/vGwOATlJ3I8WT3Boj2vqG05GREMnYBLJX8EwWJ dSvgMBJ8FetXf20qzUrvi4Pw6RvuRJFjYpbwa2K6M9EQ6GeD3OmLB2i9kT9WC8cJDej6 fKRYMlnrwxPyWYlrrW1nm/bzchaA6btyCUd3cE4vg4titjMJogidCrH93cPS/wtPssuj SiaYRXYfyyzeEvi/SrpZPlPNPC8M49VNjqS0T3PZClAGrzen8gCozuebIIhNDjQ2Rc9L +E4k+7mHJnPWdoEKvpA7cTOVcDiO5v4waWDAkruA/MPuL1qenVfoBon1ZL/siA9rxp8W B0iQ== X-Gm-Message-State: AOAM532miSIBg50G02sduBRLVRp9UMJ6ld8gVjb557IrYcpmDvzzaMeL 5hVpfRUJ4ZejNrM1kuBy8rnBXQ== X-Google-Smtp-Source: ABdhPJzN+BygjHAXONePT0Kf4YAs7yH6hesdbbYDOCsdr+huL8ukQ34b+ZD+otUf+KiEJ7FWdD9eJA== X-Received: by 2002:a7b:ce88:: with SMTP id q8mr5410226wmj.176.1591729488213; Tue, 09 Jun 2020 12:04:48 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id g25sm3794436wmh.18.2020.06.09.12.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 12:04:46 -0700 (PDT) Date: Tue, 9 Jun 2020 20:04:45 +0100 From: Lee Jones To: Andy Shevchenko Subject: Re: [RFC] MFD's relationship with Device Tree (OF) Message-ID: <20200609190445.GP4106@dell> References: <20200609110136.GJ4106@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_120449_660594_E3D1E3FB X-CRM114-Status: GOOD ( 36.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Mark Brown , Linux Kernel Mailing List , Michael Walle , Rob Herring , Guenter Roeck , GregKroah-Hartmangregkh@linuxfoundation.org, Andy Shevchenko , Robin Murphy , Linus Walleij , linux-arm Mailing List Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBKdW4gMjAyMCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgoKPiBPbiBUdWUsIEp1 biA5LCAyMDIwIGF0IDI6MDEgUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3Jv dGU6Cj4gPgo+ID4gR29vZCBtb3JuaW5nLAo+ID4KPiA+IEFmdGVyIGEgbnVtYmVyIG9mIHJlcG9y dHMvcXVlcmllcyBzdXJyb3VuZGluZyBhIGtub3duIGxvbmctdGVybSBpc3N1ZQo+ID4gaW4gdGhl IE1GRCBjb3JlLCBpbmNsdWRpbmcgdGhlIHN1Ym1pc3Npb24gb2YgYSBjb3VwbGUgb2YgYXR0ZW1w dGVkCj4gPiBzb2x1dGlvbnMsIEkndmUgZGVjaWRlZCB0byBmaW5hbGx5IHRhY2tsZSB0aGlzIG9u ZSBteXNlbGYuCj4gPgo+ID4gQ3VycmVudGx5LCB3aGVuIGEgY2hpbGQgcGxhdGZvcm0gZGV2aWNl IChzb21ldGltZXMgcmVmZXJyZWQgdG8gYXMgYQo+ID4gc3ViLWRldmljZSkgaXMgcmVnaXN0ZXJl ZCB2aWEgdGhlIE11bHRpLUZ1bmN0aW9uYWwgRGV2aWNlIChNRkQpIEFQSSwKPiA+IHRoZSBmcmFt ZXdvcmsgYXR0ZW1wdHMgdG8gbWF0Y2ggdGhlIG5ld2x5IHJlZ2lzdGVyZWQgcGxhdGZvcm0gZGV2 aWNlCj4gPiB3aXRoIGl0cyBhc3NvY2lhdGVkIERldmljZSBUcmVlIChPRikgbm9kZS4gIFVudGls IG5vdywgdGhlIGRldmljZSBoYXMKPiA+IGJlZW4gYWxsb2NhdGVkIHRoZSBmaXJzdCBub2RlIGZv dW5kIHdpdGggYW4gaWRlbnRpY2FsIE9GIGNvbXBhdGlibGUKPiA+IHN0cmluZy4gIFVuZm9ydHVu YXRlbHksIGlmIHRoZXJlIGFyZSwgc2F5IGZvciBleGFtcGxlICczJyBkZXZpY2VzCj4gPiB3aGlj aCBhcmUgdG8gYmUgaGFuZGxlZCBieSB0aGUgc2FtZSBkcml2ZXIgYW5kIHRoZXJlZm9yZSBoYXZl IHRoZSBzYW1lCj4gPiBjb21wYXRpYmxlIHN0cmluZywgZWFjaCBvZiB0aGVtIHdpbGwgYmUgYWxs b2NhdGVkIGEgcG9pbnRlciB0byB0aGUKPiA+ICpmaXJzdCogbm9kZS4KPiA+Cj4gPiBMZXQgbWUg Z2l2ZSB5b3UgYW4gZXhhbXBsZS4KPiA+Cj4gPiBJIGhhdmUga25vY2tlZCB1cCBhbiBleGFtcGxl ICdwYXJlbnQnIGFuZCAnY2hpbGQnIGRldmljZSBkcml2ZXIuICBUaGUKPiA+IHBhcmVudCB1dGls aXNlcyB0aGUgTUZEIEFQSSB0byByZWdpc3RlciAzIGlkZW50aWNhbCBjaGlsZHJlbiwgZWFjaAo+ ID4gY29udHJvbGxlZCBieSB0aGUgc2FtZSBkcml2ZXIuICBUaGlzIGhhcHBlbnMgYSBsb3QuICBG b3J0dW5hdGVseSwgaW4KPiA+IHRoZSBtYWpvcml0eSBvZiBjYXNlcywgdGhlIE9GIG5vZGVzIGFy ZSBhbHNvIHRvdGFsbHkgaWRlbnRpY2FsLCBidXQKPiA+IHdoYXQgaWYgeW91IHdpc2ggdG8gY29u ZmlndXJlIG9uZSBvZiB0aGUgY2hpbGQgZGV2aWNlcyB3aXRoIGRpZmZlcmVudAo+ID4gYXR0cmli dXRlcyBvciByZXNvdXJjZXMgc3VwcGxpZWQgdmlhIERldmljZSBUcmVlLCBsaWtlIGEgY2xvY2s/ ICBUaGlzCj4gPiBpcyBjdXJyZW50bHkgaW1wb3NzaWJsZS4KPiA+Cj4gPiBIZXJlIGlzIHRoZSBE ZXZpY2UgVHJlZSByZXByZXNlbnRhdGlvbiBmb3IgdGhlIDEgcGFyZW50IGFuZCB0aGUgMwo+ID4g Y2hpbGQgKHN1YikgZGV2aWNlcyBkZXNjcmliZWQgYWJvdmU6Cj4gPgo+ID4gICAgICAgICBwYXJl bnQgewo+ID4gICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibWZkLG9mLXRlc3QtcGFyZW50 IjsKPiA+Cj4gPiAgICAgICAgICAgICAgICAgY2hpbGRAMCB7Cj4gPiAgICAgICAgICAgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0gIm1mZCxvZi10ZXN0LWNoaWxkIjsKPiA+ICAgICAgICAgICAg ICAgICAgICAgICAgIGNsb2NrcyA9IDwmY2xvY2sgMD47Cj4gPiAgICAgICAgICAgICAgICAgfTsK PiA+Cj4gPiAgICAgICAgICAgICAgICAgY2hpbGRAMSB7Cj4gPiAgICAgICAgICAgICAgICAgICAg ICAgICBjb21wYXRpYmxlID0gIm1mZCxvZi10ZXN0LWNoaWxkIjsKPiA+ICAgICAgICAgICAgICAg ICAgICAgICAgIGNsb2NrcyA9IDwmY2xvY2sgMT47Cj4gPiAgICAgICAgICAgICAgICAgfTsKPiA+ Cj4gPiAgICAgICAgICAgICAgICAgY2hpbGRAMiB7Cj4gPiAgICAgICAgICAgICAgICAgICAgICAg ICBjb21wYXRpYmxlID0gIm1mZCxvZi10ZXN0LWNoaWxkIjsKPiA+ICAgICAgICAgICAgICAgICAg ICAgICAgIGNsb2NrcyA9IDwmY2xvY2sgMj47Cj4gPiAgICAgICAgICAgICAgICAgfTsKPiA+ICAg ICAgICAgfTsKPiA+Cj4gPiBUaGlzIGlzIGhvdyB3ZSByZWdpc3RlciB0aG9zZSBkZXZpY2VzIGZy b20gTUZEOgo+ID4KPiA+IHN0YXRpYyBjb25zdCBzdHJ1Y3QgbWZkX2NlbGwgbWZkX29mX3Rlc3Rf Y2VsbFtdID0gewo+ID4gICAgICAgICBPRl9NRkRfQ0VMTCgibWZkX29mX3Rlc3RfY2hpbGQiLCBO VUxMLCBOVUxMLCAwLCAwLCAibWZkLG9mLXRlc3QtY2hpbGQiKSwKPiA+ICAgICAgICAgT0ZfTUZE X0NFTEwoIm1mZF9vZl90ZXN0X2NoaWxkIiwgTlVMTCwgTlVMTCwgMCwgMSwgIm1mZCxvZi10ZXN0 LWNoaWxkIiksCj4gPiAgICAgICAgIE9GX01GRF9DRUxMKCJtZmRfb2ZfdGVzdF9jaGlsZCIsIE5V TEwsIE5VTEwsIDAsIDIsICJtZmQsb2YtdGVzdC1jaGlsZCIpCj4gPiB9Owo+ID4KPiA+IC4uLiB3 aGljaCB3ZSBwYXNzIGludG8gbWZkX2FkZF9kZXZpY2VzKCkgZm9yIHByb2Nlc3NpbmcuCj4gPgo+ ID4gSW4gYW4gaWRlYWwgd29ybGQuICBUaGUgZGV2aWNlcyB3aXRoIHRoZSBwbGF0Zm9ybV9pZDsg MCwgMSBhbmQgMiB3b3VsZAo+ID4gYmUgbWF0Y2hlZCB1cCB0byBEZXZpY2UgVHJlZSBub2Rlczsg Y2hpbGRAMCwgY2hpbGRAMSBhbmQgY2hpbGRAMgo+ID4gcmVzcGVjdGl2ZWx5LiAgSW5zdGVhZCBh bGwgMyBkZXZpY2VzIHdpbGwgYmUgYWxsb2NhdGVkIGEgcG9pbnRlciB0bwo+ID4gY2hpbGRAMCdz IE9GIG5vZGUsIHdoaWNoIGlzIG9idmlvdXNseSBub3QgY29ycmVjdC4KPiA+Cj4gPiBUaGlzIGlz IGhvdyBpdCBsb29rcyB3aGVuIGVhY2ggb2YgdGhlIGNoaWxkIGRldmljZXMgYXJlIHByb2JlZDoK PiA+Cj4gPiAgWzAuNzA4Mjg3XSBtZmQtb2YtdGVzdC1wYXJlbnQgbWZkX29mX3Rlc3Q6IFJlZ2lz dGVyaW5nIDMgZGV2aWNlcwo+ID4gIFsuLi5dCj4gPiAgWzAuNzEyNTExXSBtZmQtb2YtdGVzdC1j aGlsZCBtZmRfb2ZfdGVzdF9jaGlsZC4wOiBQcm9iaW5nIHBsYXRmb3JtIGRldmljZTogMAo+ID4g IFswLjcxMjcxMF0gbWZkLW9mLXRlc3QtY2hpbGQgbWZkX29mX3Rlc3RfY2hpbGQuMDogVXNpbmcg T0Ygbm9kZTogY2hpbGRAMAo+ID4gIFswLjcxMzAzM10gbWZkLW9mLXRlc3QtY2hpbGQgbWZkX29m X3Rlc3RfY2hpbGQuMTogUHJvYmluZyBwbGF0Zm9ybSBkZXZpY2U6IDEKPiA+ICBbMC43MTMzODFd IG1mZC1vZi10ZXN0LWNoaWxkIG1mZF9vZl90ZXN0X2NoaWxkLjE6IFVzaW5nIE9GIG5vZGU6IGNo aWxkQDAKPiA+ICBbMC43MTM2OTFdIG1mZC1vZi10ZXN0LWNoaWxkIG1mZF9vZl90ZXN0X2NoaWxk LjI6IFByb2JpbmcgcGxhdGZvcm0gZGV2aWNlOiAyCj4gPiAgWzAuNzEzODg5XSBtZmQtb2YtdGVz dC1jaGlsZCBtZmRfb2ZfdGVzdF9jaGlsZC4yOiBVc2luZyBPRiBub2RlOiBjaGlsZEAwCj4gPgo+ ID4gIldoeSBpcyBpdCB3aGVuIEkgY2hhbmdlIGNoaWxkIDIncyBjbG9jayByYXRlLCBpdCBhbHNv IGNoYW5nZXMgMCdzPyIKPiA+Cj4gPiBXaG9vcHMhCj4gPgo+ID4gU28gaW4gb3JkZXIgdG8gZml4 IHRoaXMsIHdlIG5lZWQgdG8gbWFrZSBNRkQgbW9yZS1jbGV2ZXJlciEKPiA+Cj4gPiBIb3dldmVy LCB0aGlzIGlzIG5vdCBzbyBzaW1wbGUuICBUaGVyZSBhcmUgc29tZSBydWxlcyB3ZSBzaG91bGQg YWJpZGUKPiA+IGJ5IChJIHVzZSAic2hvdWxkIiBpbnRlbnRpb25hbGx5IGhlcmUsIGFzIHNvbWV0 aGluZyBtaWdodCBqdXN0IGhhdmUgdG8KPiA+IGdpdmUpOgo+ID4KPiA+ICBhKSBTaW5jZSBEZXZp Y2UgVHJlZSBpcyBkZXNpZ25lZCB0byBkZXNjcmliZSBoYXJkd2FyZSwgaW5zZXJ0aW5nCj4gPiAg ICAgYXJiaXRyYXJ5IHByb3BlcnRpZXMgaW50byBEVCBpcyBmb3JiaWRkZW4uICBUaGlzIHByZWNs dWRlcyB0aGluZ3MKPiA+ICAgICB3ZSB3b3VsZCBvcmRpbmFyaWx5IGJlIGFibGUgdG8gbWF0Y2gg b24sIGxpa2UgJ2lkJyBvciAnbmFtZScuCj4gPiAgYikgQXMgYW4gZXh0ZW5zaW9uIHRvIGEpIERU cyBzaG91bGQgYWxzbyBiZSBPUyBhZ25vc3RpYywgc28KPiA+ICAgICBwcm9wZXJ0aWVzIGxpa2Ug J21mZC1kZXZpY2UnLCAnbWZkLW9yZGVyJyBldGMgYXJlIGFsc28gbm90Cj4gPiAgICAgbm90IHN1 aXRhYmxlIGZvciBpbmNsdXNpb24uCj4gPiAgYykgVGhlIGZpbmFsIHNvbHV0aW9uIHNob3VsZCBp ZGVhbGx5IGJlIGNhcGFibGUgb2Ygc3VwcG9ydGluZyBib3RoCj4gPiAgICAgbmV3bHkgZGVmaW5l ZCBhbmQgY3VycmVudCB0cmVlcyAod2l0aG91dCByZXRyb2FjdGl2ZSBlZGl0cykKPiA+ICAgICBh bGlrZS4KPiA+ICBkKSBFeGlzdGluZyBwcm9wZXJ0aWVzIGNvdWxkIGJlIHVzZWQsIGJ1dCBub3Qg YWJ1c2VkLiAgRm9yIGV4YW1wbGUsCj4gPiAgICAgb25lIG9mIG15IHN1Z2dlc3Rpb25zIChzZWUg YmVsb3cpIGlzIHRvIHVzZSB0aGUgJ3JlZycgcHJvcGVydHkuCj4gPiAgICAgVGhpcyBpcyBmaW5l IGluIHByaW5jaXBsZSBidXQgbG9hZGluZyAncmVnJyB3aXRoIGFyYml0cmFyeSB2YWx1ZXMKPiA+ ICAgICAoc3VjaCBhczsgMCwgMSwgMiAuLi4geCkgd2hpY2ggMSkgY2xlYXJseSBkbyBub3QgaGF2 ZSBhbnl0aGluZyB0bwo+ID4gICAgIGRvIHdpdGggcmVnaXN0ZXJzIGFuZCAyKSB3b3VsZCBiZSBt ZWFuaW5nbGVzcyBpbiBvdGhlciBPU2VzLwo+ID4gICAgIGltcGxlbWVudGF0aW9ucywganVzdCB0 byBzZXJ2ZSBvdXIgcHVycG9zZSwgaXMgdG8gYmUgaW50ZXJwcmV0ZWQKPiA+ICAgICBhcyBhbiBh YnVzZS4KPiA+Cj4gPiBQcm9wb3NhbCAxOgo+ID4KPiA+IEFzIG1lbnRpb25lZCBhYm92ZSwgbXkg aW5pdGlhbCB0aG91Z2h0cyB3ZXJlIHRvIHVzZSB0aGUgJ3JlZycgcHJvcGVydHkKPiA+IHRvIG1h dGNoIGFuIE1GRCBjZWxsIGVudHJ5IHdpdGggdGhlIGNvcnJlY3QgRFQgbm9kZS4gIEhvd2V2ZXIs IG5vdAo+ID4gYWxsIERldmljZSBUcmVlIG5vZGVzIGhhdmUgJ3JlZycgcHJvcGVydGllcy4gIFBh cnRpY3VsYXJseSB0cnVlIGluIHRoZQo+ID4gY2FzZSBvZiBNRkQsIHdoZXJlIG1lbW9yeSByZXNv dXJjZXMgYXJlIHVzdWFsbHkgc2hhcmVkIHdpdGggdGhlIHBhcmVudAo+ID4gdmlhIFJlZ21hcCwg b3IgKGFzIGluIHRoZSBjYXNlIG9mIHRoZSBhYjg1MDApIHRoZSBNRkQgaGFuZGxlcyBhbGwKPiA+ IHJlZ2lzdGVyIHRyYW5zYWN0aW9ucyB2aWEgaXRzIG93biBBUEkuCj4gPgo+ID4gUHJvcG9zYWwg MjoKPiA+Cj4gPiBJZiB3ZSBjYW4ndCBndWFyYW50ZWUgdGhhdCBhbGwgRFQgbm9kZXMgd2lsbCBo YXZlIGF0IGxlYXN0IG9uZQo+ID4gcHJvcGVydHkgaW4gY29tbW9uIHRvIGJlIHVzZWQgZm9yIG1h dGNoaW5nIGFuZCB3ZSdyZSBwcmV2ZW50ZWQgZnJvbQo+ID4gc3VwcGx5aW5nIGFkZGl0aW9uYWws IHBvdGVudGlhbGx5IGJlc3Bva2UgcHJvcGVydGllcywgdGhlbiB3ZSBtdXN0Cj4gPiBzZWVrIGFu IGFsdGVybmF0aXZlIHByb2NlZHVyZS4KPiA+Cj4gPiBJdCBzaG91bGQgYmUgcG9zc2libGUgdG8g bWF0Y2ggYmFzZWQgb24gb3JkZXIuICBIb3dldmVyLCB0aGUgZGV2ZWxvcGVyCj4gPiB3b3VsZCBo YXZlIHRvIGd1YXJhbnRlZSB0aGF0IHRoZSBvcmRlciBpbiB3aGljaCB0aGUgY2hpbGQgZGV2aWNl cyBhcmUKPiA+IHByZXNlbnRlZCB0byB0aGUgTUZEIEFQSSBhcmUgaW4gZXhhY3RseSB0aGUgc2Ft ZSBvcmRlciBhcyB0aGV5IGFyZQo+ID4gcmVwcmVzZW50ZWQgaW4gdGhlIERldmljZSBUcmVlLiAg VGhlIG9idmlvdXMgZHJhdy1iYWNrIHRvIHRoaXMKPiA+IHN0cmF0ZWd5IGlzIHRoYXQgaXQncyBw b3RlbnRpYWxseSB2ZXJ5IGZyYWdpbGUuCj4gPgo+ID4gQ3VycmVudCBQcm9wb3NhbDoKPiA+Cj4g PiBIb3cgYWJvdXQgYSBjb2xsZWN0aW9uIG9mIFByb3Bvc2FsIDEgYW5kIFByb3Bvc2FsIDI/ICBG aXJzdCB3ZSBjb3VsZAo+ID4gYXR0ZW1wdCBhIG1hdGNoIG9uIHRoZSAncmVnJyBwcm9wZXJ0eS4g IFRoZW4sIGlmIHRoYXQgZmFpbHMsIHdlIHdvdWxkCj4gPiB1c2UgdGhlIGZyYWdpbGUtYnV0LWl0 cy1hbGwtd2UtaGF2ZSBQcm9wb3NhbCAyIGFzIHRoZSBmYWxsLWJhY2suCj4gPgo+ID4gVGhvdWdo dHM/Cj4gCj4gSnVzdCBhIHNpZGUgbm90ZSwgaGF2ZSB5b3UgY29uc2lkZXJlZCBzb2Z0d2FyZSBu b2RlcyBvbiB0aGUgcGljdHVyZT8KPiBZb3UgY2FuIGFkZCBwcm9wZXJ0aWVzIG9yIGFkZGl0aW9u YWwgcmVmZXJlbmNlcyB0byB0aGUgZXhpc3RpbmcKPiAoZmlybXdhcmUpIG5vZGVzLgoKSXMgdGhh dCB0aGUgcHJvcGVydGllcyBmcmFtZXdvcmsgeW91IGFyZSB0cnlpbmcgdG8gcmVwbGFjZT8KCklz IHRoYXQgZGlmZmVyZW50IHRvIHBsYWNpbmcgYWRkaXRpb25hbCBhdHRyaWJ1dGVzIGludG8gcGRh dGE/CgpVc2luZyBteSBjbG9jayBleGFtcGxlIGFib3ZlLCBob3cgd291bGQgb25lIGFsbG9jYXRl IGEgRFQgYmFzZWQgY2xvY2sKdG8gYSBjaGlsZCBkZXZpY2UgdXNpbmcgcHJvcGVydGllcz8KCi0t IApMZWUgSm9uZXMgW+adjueQvOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVy IFNlcnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29D cwpGb2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxp bmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==