From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF548C433DF for ; Tue, 9 Jun 2020 15:53:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8E11A2078D for ; Tue, 9 Jun 2020 15:53:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="kd6bzfOP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730959AbgFIPxf (ORCPT ); Tue, 9 Jun 2020 11:53:35 -0400 Received: from ozlabs.org ([203.11.71.1]:49977 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730603AbgFIPxe (ORCPT ); Tue, 9 Jun 2020 11:53:34 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49hF5h2Zbfz9sRK; Wed, 10 Jun 2020 01:53:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1591718012; bh=MVR0wu1WoLMcDMDIi7X7cjBzBYkvIBCEhvhBXLeas1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kd6bzfOPzl1O284EHmMfACEZ4Z3kTmQt3TkPdxk/xbq/g+CndtPFmzrb5I6cFIjL3 TCj8JaxomBlTHtD1HNd3lc11OaisOObYmnDuz0FWnhNXSbk6sQLB5RlzgJ0kKRUzeO 4RR9BFJegW96ziLLfs0zdJoGNtdfcBxK/U97/BO3jytFhykBazbLcZNC0CG1U2m2mH XQv7oGH3L2LTlmr4yTmGzGKyWtcRG+9Y55CWOl5wpi02RuPeOuAVdUc5/3abNg45Jz 0YoTrf4Qt9kN56z6VRUaS9He9TnbXXz9osNTC7BUx30agRYOyV7aR7iIGkseR/qS8O YxmXhftkoU8cQ== Date: Wed, 10 Jun 2020 01:53:27 +1000 From: Stephen Rothwell To: Christophe Leroy Cc: Joerg Roedel , Andrew Morton , linux-arch@vger.kernel.org, jroedel@suse.de, linux-mm@kvack.org, peterz@infradead.org, Linus Torvalds , linuxppc-dev@lists.ozlabs.org, Steven Rostedt , Mike Rapoport , Abdul Haleem , linux-next@vger.kernel.org, Satheesh Rajendran , Andy Lutomirski , manvanth@linux.vnet.ibm.com, hch@lst.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file Message-ID: <20200610015327.02d210ba@canb.auug.org.au> In-Reply-To: <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu> References: <20200609120533.25867-1-joro@8bytes.org> <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/rdvwFz8_JqljFG+KPhRUM/U"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/rdvwFz8_JqljFG+KPhRUM/U Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Christophe, On Tue, 9 Jun 2020 17:24:14 +0200 Christophe Leroy wrote: > > Le 09/06/2020 =C3=A0 14:05, Joerg Roedel a =C3=A9crit=C2=A0: > > From: Joerg Roedel > >=20 > > The functions are only used in two source files, so there is no need > > for them to be in the global header. Move them to the new > > header and include it only where needed. =20 >=20 > Do you mean we will now create a new header file for any new couple on=20 > functions based on where they are used ? >=20 > Can you explain why this change is needed or is a plus ? Well at a minimum, it means 45 lines less to be parsed every time the linux/mm is included (in at last count, 1996 places some of which are include files included by other files). And, as someone who does a lot of builds every day, I am in favour of that :-) --=20 Cheers, Stephen Rothwell --Sig_/rdvwFz8_JqljFG+KPhRUM/U Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl7fsHcACgkQAVBC80lX 0Gweigf+PD8mMUG1c9BtwY0sS3cc9f4TEcShuv7vlAhWEDtMJ9S9N9/8iPkWNrhV ULELcWDWgQozqP470o451a9APq+Llzh+bKUho77kXN3GEXlkeiR0Q0VzEIDRqB2u D4fwyQH7pdPTQTnXCKffVuHk9D7PIp4/Y/d4oMwDRVkHppv7GmXzyq8iWjoZwkJm E2hfxBWErz7ZQxHbkv7ns7pWvBSgjn0VYr6JqsyW4Sv199pESrO97zgKJFk7FD3M NcqyhVvPxGwVYA8TstWfsokP5tPRz5RSABoZTNqmdwzu+I1gYEANCmPDnC9zetHn pvmbLciQrEbjgRevDnJHaJQZiNKVnw== =xmAg -----END PGP SIGNATURE----- --Sig_/rdvwFz8_JqljFG+KPhRUM/U-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C457EC433E0 for ; Tue, 9 Jun 2020 15:55:24 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72BC82072F for ; Tue, 9 Jun 2020 15:55:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.b="kd6bzfOP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72BC82072F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49hF7t4JC8zDqdr for ; Wed, 10 Jun 2020 01:55:22 +1000 (AEST) Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49hF5n4l2NzDqXK for ; Wed, 10 Jun 2020 01:53:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=canb.auug.org.au header.i=@canb.auug.org.au header.a=rsa-sha256 header.s=201702 header.b=kd6bzfOP; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49hF5h2Zbfz9sRK; Wed, 10 Jun 2020 01:53:28 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1591718012; bh=MVR0wu1WoLMcDMDIi7X7cjBzBYkvIBCEhvhBXLeas1c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kd6bzfOPzl1O284EHmMfACEZ4Z3kTmQt3TkPdxk/xbq/g+CndtPFmzrb5I6cFIjL3 TCj8JaxomBlTHtD1HNd3lc11OaisOObYmnDuz0FWnhNXSbk6sQLB5RlzgJ0kKRUzeO 4RR9BFJegW96ziLLfs0zdJoGNtdfcBxK/U97/BO3jytFhykBazbLcZNC0CG1U2m2mH XQv7oGH3L2LTlmr4yTmGzGKyWtcRG+9Y55CWOl5wpi02RuPeOuAVdUc5/3abNg45Jz 0YoTrf4Qt9kN56z6VRUaS9He9TnbXXz9osNTC7BUx30agRYOyV7aR7iIGkseR/qS8O YxmXhftkoU8cQ== Date: Wed, 10 Jun 2020 01:53:27 +1000 From: Stephen Rothwell To: Christophe Leroy Subject: Re: [PATCH] mm: Move p?d_alloc_track to separate header file Message-ID: <20200610015327.02d210ba@canb.auug.org.au> In-Reply-To: <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu> References: <20200609120533.25867-1-joro@8bytes.org> <2aecbc65-db1a-dccd-046d-b7c97b714ee0@csgroup.eu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/rdvwFz8_JqljFG+KPhRUM/U"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, manvanth@linux.vnet.ibm.com, jroedel@suse.de, Abdul Haleem , peterz@infradead.org, linuxppc-dev@lists.ozlabs.org, Joerg Roedel , linux-kernel@vger.kernel.org, Steven Rostedt , Mike Rapoport , linux-mm@kvack.org, linux-next@vger.kernel.org, Satheesh Rajendran , Andy Lutomirski , Andrew Morton , Linus Torvalds , hch@lst.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --Sig_/rdvwFz8_JqljFG+KPhRUM/U Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Christophe, On Tue, 9 Jun 2020 17:24:14 +0200 Christophe Leroy wrote: > > Le 09/06/2020 =C3=A0 14:05, Joerg Roedel a =C3=A9crit=C2=A0: > > From: Joerg Roedel > >=20 > > The functions are only used in two source files, so there is no need > > for them to be in the global header. Move them to the new > > header and include it only where needed. =20 >=20 > Do you mean we will now create a new header file for any new couple on=20 > functions based on where they are used ? >=20 > Can you explain why this change is needed or is a plus ? Well at a minimum, it means 45 lines less to be parsed every time the linux/mm is included (in at last count, 1996 places some of which are include files included by other files). And, as someone who does a lot of builds every day, I am in favour of that :-) --=20 Cheers, Stephen Rothwell --Sig_/rdvwFz8_JqljFG+KPhRUM/U Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl7fsHcACgkQAVBC80lX 0Gweigf+PD8mMUG1c9BtwY0sS3cc9f4TEcShuv7vlAhWEDtMJ9S9N9/8iPkWNrhV ULELcWDWgQozqP470o451a9APq+Llzh+bKUho77kXN3GEXlkeiR0Q0VzEIDRqB2u D4fwyQH7pdPTQTnXCKffVuHk9D7PIp4/Y/d4oMwDRVkHppv7GmXzyq8iWjoZwkJm E2hfxBWErz7ZQxHbkv7ns7pWvBSgjn0VYr6JqsyW4Sv199pESrO97zgKJFk7FD3M NcqyhVvPxGwVYA8TstWfsokP5tPRz5RSABoZTNqmdwzu+I1gYEANCmPDnC9zetHn pvmbLciQrEbjgRevDnJHaJQZiNKVnw== =xmAg -----END PGP SIGNATURE----- --Sig_/rdvwFz8_JqljFG+KPhRUM/U--