From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2107AC433E1 for ; Wed, 10 Jun 2020 06:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E82FD2074B for ; Wed, 10 Jun 2020 06:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WpAdeT9d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbgFJGn0 (ORCPT ); Wed, 10 Jun 2020 02:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgFJGnV (ORCPT ); Wed, 10 Jun 2020 02:43:21 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3E1FC03E96B for ; Tue, 9 Jun 2020 23:43:19 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id j10so881765wrw.8 for ; Tue, 09 Jun 2020 23:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=50byfSUtLO2L1CsGut80+OISi/Nz9nsAC9YkkMqMXOM=; b=WpAdeT9dbF9UyWDJZv0gWHAQMuuBqmw5us09gBqWv+GWgq+kxrUfIl8gfsmGhALYRN 9U88mTavWdGgeMiEitVvkwac8h/MigSeJesciURuMINjhqnylY868I+AXmLy3CHeKK4P Xe+AlqVbHt4WBnTG1f8JhdVuwbTMAbJOjy5TFxeEHF5cXMmFTDwyPmEaDiqrwZ5X6ZU9 O2hrYZYEQdr60oSPRqLkRvGI8eXrcyplPOevfujiGJYbUm9lfLo0lFaFzifhAsL09oDj QJXOxBR3qtn+1jT1b8rXZcqpYHhumFRmVcFCr3GMMys3xSzduKC41iTYvv9r9E5MMR3d n+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=50byfSUtLO2L1CsGut80+OISi/Nz9nsAC9YkkMqMXOM=; b=BdMXwuPjqCHfBJjB+8TzOh1perH4pFl004yonh1bm9o7A1LwHEK3NjrzFAwCLLpBdh G88w5EuOYqHhxlqUJd/JtklVwMDg+pLXmAqGnMBUpe+oAkYERYF91c9P1pkGkPSPJeh6 Mq19hM0u+Y2TGVip66t+crk3N+p4ubekdS69iCsr6t38Pej+e9ocyUj6kiXJL4l4lHG/ 2xjm9bbazzK1qQRTliDU2quYKelwqqOiL1qINYh3gK/b5JmVy6heFR+LrOCsDpNpXGkh ObT27uAOCeCiqqah0YJrTQjfDekhNWlo0q3YbmV8ut5SAIZaLKBix12ik2ripJBiaTWI Uwaw== X-Gm-Message-State: AOAM530AxVxtj2Byqij5U/Y8lobiFol9d+ztTucX7mjVWZeNSOOMwmwI jkHpSelTUNI+b7Ep8aPUKXBp1A== X-Google-Smtp-Source: ABdhPJwaoQK+X0lo6GNX+4YH4LmVZ34yndsRQ2O8DgNG6DNYc2XV0ST4pDrJrPqXkHWMBQcWpVJ2Mg== X-Received: by 2002:a5d:608d:: with SMTP id w13mr1828741wrt.298.1591771398313; Tue, 09 Jun 2020 23:43:18 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id y14sm5513504wma.25.2020.06.09.23.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 23:43:17 -0700 (PDT) Date: Wed, 10 Jun 2020 07:43:15 +0100 From: Lee Jones To: Rob Herring Cc: Andy Shevchenko , Michael Walle , Mark Brown , devicetree , Linux Kernel Mailing List , linux-arm Mailing List , Linus Walleij , Guenter Roeck , Andy Shevchenko , Robin Murphy , GregKroah-Hartmangregkh@linuxfoundation.org Subject: Re: [RFC] MFD's relationship with Device Tree (OF) Message-ID: <20200610064315.GR4106@dell> References: <20200609110136.GJ4106@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Jun 2020, Rob Herring wrote: Thanks for replying Rob. > On Tue, Jun 9, 2020 at 5:01 AM Lee Jones wrote: > > > > Good morning, > > > > After a number of reports/queries surrounding a known long-term issue > > in the MFD core, including the submission of a couple of attempted > > solutions, I've decided to finally tackle this one myself. > > > > Currently, when a child platform device (sometimes referred to as a > > sub-device) is registered via the Multi-Functional Device (MFD) API, > > the framework attempts to match the newly registered platform device > > with its associated Device Tree (OF) node. Until now, the device has > > been allocated the first node found with an identical OF compatible > > string. Unfortunately, if there are, say for example '3' devices > > which are to be handled by the same driver and therefore have the same > > compatible string, each of them will be allocated a pointer to the > > *first* node. > > > > Let me give you an example. > > > > I have knocked up an example 'parent' and 'child' device driver. The > > parent utilises the MFD API to register 3 identical children, each > > controlled by the same driver. This happens a lot. Fortunately, in > > the majority of cases, the OF nodes are also totally identical, but > > what if you wish to configure one of the child devices with different > > attributes or resources supplied via Device Tree, like a clock? This > > is currently impossible. > > > > Here is the Device Tree representation for the 1 parent and the 3 > > child (sub) devices described above: > > > > parent { > > compatible = "mfd,of-test-parent"; > > > > child@0 { > > Just a note, unit-address implies there is a 'reg' property. Why > that's important below. Right. This is just an example to express the problem more easily. > > compatible = "mfd,of-test-child"; > > clocks = <&clock 0>; > > }; > > > > child@1 { > > compatible = "mfd,of-test-child"; > > clocks = <&clock 1>; > > }; > > > > child@2 { > > compatible = "mfd,of-test-child"; > > clocks = <&clock 2>; > > }; > > }; > > > > This is how we register those devices from MFD: > > > > static const struct mfd_cell mfd_of_test_cell[] = { > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 0, "mfd,of-test-child"), > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 1, "mfd,of-test-child"), > > OF_MFD_CELL("mfd_of_test_child", NULL, NULL, 0, 2, "mfd,of-test-child") > > }; > > > > ... which we pass into mfd_add_devices() for processing. > > > > In an ideal world. The devices with the platform_id; 0, 1 and 2 would > > be matched up to Device Tree nodes; child@0, child@1 and child@2 > > respectively. Instead all 3 devices will be allocated a pointer to > > child@0's OF node, which is obviously not correct. > > > > This is how it looks when each of the child devices are probed: > > > > [0.708287] mfd-of-test-parent mfd_of_test: Registering 3 devices > > [...] > > [0.712511] mfd-of-test-child mfd_of_test_child.0: Probing platform device: 0 > > [0.712710] mfd-of-test-child mfd_of_test_child.0: Using OF node: child@0 > > [0.713033] mfd-of-test-child mfd_of_test_child.1: Probing platform device: 1 > > [0.713381] mfd-of-test-child mfd_of_test_child.1: Using OF node: child@0 > > [0.713691] mfd-of-test-child mfd_of_test_child.2: Probing platform device: 2 > > [0.713889] mfd-of-test-child mfd_of_test_child.2: Using OF node: child@0 > > > > "Why is it when I change child 2's clock rate, it also changes 0's?" > > > > Whoops! > > > > So in order to fix this, we need to make MFD more-cleverer! > > > > However, this is not so simple. There are some rules we should abide > > by (I use "should" intentionally here, as something might just have to > > give): > > > > a) Since Device Tree is designed to describe hardware, inserting > > arbitrary properties into DT is forbidden. This precludes things > > we would ordinarily be able to match on, like 'id' or 'name'. > > b) As an extension to a) DTs should also be OS agnostic, so > > properties like 'mfd-device', 'mfd-order' etc are also not > > not suitable for inclusion. > > c) The final solution should ideally be capable of supporting both > > newly defined and current trees (without retroactive edits) > > alike. > > Presumably anything current already works. If you had the above > example already, requiring updating the DT to make it work seems fine. "works" it a matter of opinion. Some instances "work" out of luck. Some "work" because they have been worked-around or an alternative implementation sought. For instance, 'ab8500-pwm' only has 1 DT node present, yet 3 devices are registered via MFD. Since MFD matches devices with DT nodes containing identical compatible strings using first-found, all PWM instances are assigned a pointer to the 1 existing DT node. Fortunately in this case they all share the same clock, so it "works", but that's clearly not the intended implementation. > > d) Existing properties could be used, but not abused. For example, > > one of my suggestions (see below) is to use the 'reg' property. > > This is fine in principle but loading 'reg' with arbitrary values > > (such as; 0, 1, 2 ... x) which 1) clearly do not have anything to > > do with registers and 2) would be meaningless in other OSes/ > > implementations, just to serve our purpose, is to be interpreted > > as an abuse. > > Multiple instances of something implies you have some way to address > them and 'reg' is what defines the address of something. 0,1,2,etc. > looks suspiciously like just some kernel defined indexes, but if > that's how things are defined in the datasheet I'm okay with them. > > The one wrinkle is there's only one address space at one level, so > gpio@0, gpio@1, pwm@0, pwm@1, etc. doesn't really work (well, it > works, but having overlapping addresses is not good practice). Either > we relax that in this case or we can add another level to group nodes. All agreed. Sounds promising. > > Proposal 1: > > > > As mentioned above, my initial thoughts were to use the 'reg' property > > to match an MFD cell entry with the correct DT node. However, not > > all Device Tree nodes have 'reg' properties. Particularly true in the > > case of MFD, where memory resources are usually shared with the parent > > via Regmap, or (as in the case of the ab8500) the MFD handles all > > register transactions via its own API. > > Just to pick on ab8500, it should have had 'reg' property IMO. The > 'bank' is clearly a h/w property and how you address each sub-device. > > > > > Proposal 2: > > > > If we can't guarantee that all DT nodes will have at least one > > property in common to be used for matching and we're prevented from > > supplying additional, potentially bespoke properties, then we must > > seek an alternative procedure. > > > > It should be possible to match based on order. However, the developer > > would have to guarantee that the order in which the child devices are > > presented to the MFD API are in exactly the same order as they are > > represented in the Device Tree. The obvious draw-back to this > > strategy is that it's potentially very fragile. > > I don't think we should use order. If it's always possible to have a 'reg' property then we won't need to. > > Current Proposal: > > > > How about a collection of Proposal 1 and Proposal 2? First we could > > attempt a match on the 'reg' property. Then, if that fails, we would > > use the fragile-but-its-all-we-have Proposal 2 as the fall-back. > > Yes, we should use 'reg' whenever possible. If we don't have 'reg', > then you shouldn't have a unit-address either and you can simply match > on the node name (standard DT driver matching is with compatible, > device_type, and node name (w/o unit-address)). We've generally been > doing 'classname-N' when there's no 'reg' to do 'classname@N'. > Matching on 'classname-N' would work with node name matching as only > unit-addresses are stripped. Let me try and knock something up. I'll get back to you when it's done. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8774AC433DF for ; Wed, 10 Jun 2020 06:43:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52C8F20801 for ; Wed, 10 Jun 2020 06:43:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OB6IJs5B"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WpAdeT9d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52C8F20801 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B8syS9bs744ckE9iWRR8A0v989KjG3b5xaRts354pYM=; b=OB6IJs5BZgrvEB g8DZcO2rjngBAJ1HWG4n0gKeLGIlwh6NU29U2X9TVUfJOPrTKCohipFdLpwsEACmnMVsy5iDt8wO1 mM/IKo32Dy6K084uLOPvFfiKlrSyFFoFtraSupc9G7d/9lGNe8XLDU+8xdFITI/P+4ycjwZx1sgF+ +oad6Ky89rFAiodptJuvbZUCmOW69LNP5eDvbx6rdunfaBjMCOyr+/yC3Xq1QGT8ObyfOx3o92P/s Ib9RKm6X37rKm21YypnsucD95dZa6Vj7ZMR9pJSVs6wxf05u0iftcQ1Lm9AAQpGuDjGFAVlRRSaPp +L6NSMrvjIOJfiwp6Rbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiuSJ-0001fv-C6; Wed, 10 Jun 2020 06:43:23 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiuSF-0001ef-T1 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jun 2020 06:43:21 +0000 Received: by mail-wr1-x443.google.com with SMTP id x6so859921wrm.13 for ; Tue, 09 Jun 2020 23:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=50byfSUtLO2L1CsGut80+OISi/Nz9nsAC9YkkMqMXOM=; b=WpAdeT9dbF9UyWDJZv0gWHAQMuuBqmw5us09gBqWv+GWgq+kxrUfIl8gfsmGhALYRN 9U88mTavWdGgeMiEitVvkwac8h/MigSeJesciURuMINjhqnylY868I+AXmLy3CHeKK4P Xe+AlqVbHt4WBnTG1f8JhdVuwbTMAbJOjy5TFxeEHF5cXMmFTDwyPmEaDiqrwZ5X6ZU9 O2hrYZYEQdr60oSPRqLkRvGI8eXrcyplPOevfujiGJYbUm9lfLo0lFaFzifhAsL09oDj QJXOxBR3qtn+1jT1b8rXZcqpYHhumFRmVcFCr3GMMys3xSzduKC41iTYvv9r9E5MMR3d n+DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=50byfSUtLO2L1CsGut80+OISi/Nz9nsAC9YkkMqMXOM=; b=S0QC5G+yHlLV6pHdXYxj+sNtLxcVctc+Z507GwGHDkUh20Gp3XU23PMmayq4+z2lvj z4UkQe0lCdO1EDjISlGfwq2tC7erzs49LPtvhMnsbz6o2JGYAEqsUtg1Gpgii2y8uIBy TNaYkU3q4urmC/2Nvx0ifO4qqN6ZDjjHikx/1F3NFqlkVM+gn7k4h+Lc1Fw1TDngl1Pc jYNEc+jiqwFEMF9K00JPkQmrmduUwVrh+pjbdc90eZoT2KQSsYZ6TClJQMAI6xN0laW+ DJll6V4mgXgkQv/DFUMjXR05jV93shKUdok8hNp3FHbRV/zywHjrg9jzBudU1qUwjHMb Osmw== X-Gm-Message-State: AOAM530Kmgd9+BjzjIlVinTU1bwb1JDbvluByioxP1uMItCkNXnZkKk3 p2eC26kmt+Ax1kXirrioITLOJg== X-Google-Smtp-Source: ABdhPJwaoQK+X0lo6GNX+4YH4LmVZ34yndsRQ2O8DgNG6DNYc2XV0ST4pDrJrPqXkHWMBQcWpVJ2Mg== X-Received: by 2002:a5d:608d:: with SMTP id w13mr1828741wrt.298.1591771398313; Tue, 09 Jun 2020 23:43:18 -0700 (PDT) Received: from dell ([2.27.167.101]) by smtp.gmail.com with ESMTPSA id y14sm5513504wma.25.2020.06.09.23.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 23:43:17 -0700 (PDT) Date: Wed, 10 Jun 2020 07:43:15 +0100 From: Lee Jones To: Rob Herring Subject: Re: [RFC] MFD's relationship with Device Tree (OF) Message-ID: <20200610064315.GR4106@dell> References: <20200609110136.GJ4106@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_234319_971330_4DD9D425 X-CRM114-Status: GOOD ( 41.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linus Walleij , Michael Walle , Linux Kernel Mailing List , Andy Shevchenko , Mark Brown , Guenter Roeck , GregKroah-Hartmangregkh@linuxfoundation.org, Andy Shevchenko , Robin Murphy , linux-arm Mailing List Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAwOSBKdW4gMjAyMCwgUm9iIEhlcnJpbmcgd3JvdGU6CgpUaGFua3MgZm9yIHJlcGx5 aW5nIFJvYi4KCj4gT24gVHVlLCBKdW4gOSwgMjAyMCBhdCA1OjAxIEFNIExlZSBKb25lcyA8bGVl LmpvbmVzQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4KPiA+IEdvb2QgbW9ybmluZywKPiA+Cj4gPiBB ZnRlciBhIG51bWJlciBvZiByZXBvcnRzL3F1ZXJpZXMgc3Vycm91bmRpbmcgYSBrbm93biBsb25n LXRlcm0gaXNzdWUKPiA+IGluIHRoZSBNRkQgY29yZSwgaW5jbHVkaW5nIHRoZSBzdWJtaXNzaW9u IG9mIGEgY291cGxlIG9mIGF0dGVtcHRlZAo+ID4gc29sdXRpb25zLCBJJ3ZlIGRlY2lkZWQgdG8g ZmluYWxseSB0YWNrbGUgdGhpcyBvbmUgbXlzZWxmLgo+ID4KPiA+IEN1cnJlbnRseSwgd2hlbiBh IGNoaWxkIHBsYXRmb3JtIGRldmljZSAoc29tZXRpbWVzIHJlZmVycmVkIHRvIGFzIGEKPiA+IHN1 Yi1kZXZpY2UpIGlzIHJlZ2lzdGVyZWQgdmlhIHRoZSBNdWx0aS1GdW5jdGlvbmFsIERldmljZSAo TUZEKSBBUEksCj4gPiB0aGUgZnJhbWV3b3JrIGF0dGVtcHRzIHRvIG1hdGNoIHRoZSBuZXdseSBy ZWdpc3RlcmVkIHBsYXRmb3JtIGRldmljZQo+ID4gd2l0aCBpdHMgYXNzb2NpYXRlZCBEZXZpY2Ug VHJlZSAoT0YpIG5vZGUuICBVbnRpbCBub3csIHRoZSBkZXZpY2UgaGFzCj4gPiBiZWVuIGFsbG9j YXRlZCB0aGUgZmlyc3Qgbm9kZSBmb3VuZCB3aXRoIGFuIGlkZW50aWNhbCBPRiBjb21wYXRpYmxl Cj4gPiBzdHJpbmcuICBVbmZvcnR1bmF0ZWx5LCBpZiB0aGVyZSBhcmUsIHNheSBmb3IgZXhhbXBs ZSAnMycgZGV2aWNlcwo+ID4gd2hpY2ggYXJlIHRvIGJlIGhhbmRsZWQgYnkgdGhlIHNhbWUgZHJp dmVyIGFuZCB0aGVyZWZvcmUgaGF2ZSB0aGUgc2FtZQo+ID4gY29tcGF0aWJsZSBzdHJpbmcsIGVh Y2ggb2YgdGhlbSB3aWxsIGJlIGFsbG9jYXRlZCBhIHBvaW50ZXIgdG8gdGhlCj4gPiAqZmlyc3Qq IG5vZGUuCj4gPgo+ID4gTGV0IG1lIGdpdmUgeW91IGFuIGV4YW1wbGUuCj4gPgo+ID4gSSBoYXZl IGtub2NrZWQgdXAgYW4gZXhhbXBsZSAncGFyZW50JyBhbmQgJ2NoaWxkJyBkZXZpY2UgZHJpdmVy LiAgVGhlCj4gPiBwYXJlbnQgdXRpbGlzZXMgdGhlIE1GRCBBUEkgdG8gcmVnaXN0ZXIgMyBpZGVu dGljYWwgY2hpbGRyZW4sIGVhY2gKPiA+IGNvbnRyb2xsZWQgYnkgdGhlIHNhbWUgZHJpdmVyLiAg VGhpcyBoYXBwZW5zIGEgbG90LiAgRm9ydHVuYXRlbHksIGluCj4gPiB0aGUgbWFqb3JpdHkgb2Yg Y2FzZXMsIHRoZSBPRiBub2RlcyBhcmUgYWxzbyB0b3RhbGx5IGlkZW50aWNhbCwgYnV0Cj4gPiB3 aGF0IGlmIHlvdSB3aXNoIHRvIGNvbmZpZ3VyZSBvbmUgb2YgdGhlIGNoaWxkIGRldmljZXMgd2l0 aCBkaWZmZXJlbnQKPiA+IGF0dHJpYnV0ZXMgb3IgcmVzb3VyY2VzIHN1cHBsaWVkIHZpYSBEZXZp Y2UgVHJlZSwgbGlrZSBhIGNsb2NrPyAgVGhpcwo+ID4gaXMgY3VycmVudGx5IGltcG9zc2libGUu Cj4gPgo+ID4gSGVyZSBpcyB0aGUgRGV2aWNlIFRyZWUgcmVwcmVzZW50YXRpb24gZm9yIHRoZSAx IHBhcmVudCBhbmQgdGhlIDMKPiA+IGNoaWxkIChzdWIpIGRldmljZXMgZGVzY3JpYmVkIGFib3Zl Ogo+ID4KPiA+ICAgICAgICAgcGFyZW50IHsKPiA+ICAgICAgICAgICAgICAgICBjb21wYXRpYmxl ID0gIm1mZCxvZi10ZXN0LXBhcmVudCI7Cj4gPgo+ID4gICAgICAgICAgICAgICAgIGNoaWxkQDAg ewo+IAo+IEp1c3QgYSBub3RlLCB1bml0LWFkZHJlc3MgaW1wbGllcyB0aGVyZSBpcyBhICdyZWcn IHByb3BlcnR5LiBXaHkKPiB0aGF0J3MgaW1wb3J0YW50IGJlbG93LgoKUmlnaHQuICBUaGlzIGlz IGp1c3QgYW4gZXhhbXBsZSB0byBleHByZXNzIHRoZSBwcm9ibGVtIG1vcmUgZWFzaWx5LgoKPiA+ ICAgICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibWZkLG9mLXRlc3QtY2hpbGQi Owo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0gPCZjbG9jayAwPjsKPiA+ICAg ICAgICAgICAgICAgICB9Owo+ID4KPiA+ICAgICAgICAgICAgICAgICBjaGlsZEAxIHsKPiA+ICAg ICAgICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibWZkLG9mLXRlc3QtY2hpbGQiOwo+ ID4gICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0gPCZjbG9jayAxPjsKPiA+ICAgICAg ICAgICAgICAgICB9Owo+ID4KPiA+ICAgICAgICAgICAgICAgICBjaGlsZEAyIHsKPiA+ICAgICAg ICAgICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAibWZkLG9mLXRlc3QtY2hpbGQiOwo+ID4g ICAgICAgICAgICAgICAgICAgICAgICAgY2xvY2tzID0gPCZjbG9jayAyPjsKPiA+ICAgICAgICAg ICAgICAgICB9Owo+ID4gICAgICAgICB9Owo+ID4KPiA+IFRoaXMgaXMgaG93IHdlIHJlZ2lzdGVy IHRob3NlIGRldmljZXMgZnJvbSBNRkQ6Cj4gPgo+ID4gc3RhdGljIGNvbnN0IHN0cnVjdCBtZmRf Y2VsbCBtZmRfb2ZfdGVzdF9jZWxsW10gPSB7Cj4gPiAgICAgICAgIE9GX01GRF9DRUxMKCJtZmRf b2ZfdGVzdF9jaGlsZCIsIE5VTEwsIE5VTEwsIDAsIDAsICJtZmQsb2YtdGVzdC1jaGlsZCIpLAo+ ID4gICAgICAgICBPRl9NRkRfQ0VMTCgibWZkX29mX3Rlc3RfY2hpbGQiLCBOVUxMLCBOVUxMLCAw LCAxLCAibWZkLG9mLXRlc3QtY2hpbGQiKSwKPiA+ICAgICAgICAgT0ZfTUZEX0NFTEwoIm1mZF9v Zl90ZXN0X2NoaWxkIiwgTlVMTCwgTlVMTCwgMCwgMiwgIm1mZCxvZi10ZXN0LWNoaWxkIikKPiA+ IH07Cj4gPgo+ID4gLi4uIHdoaWNoIHdlIHBhc3MgaW50byBtZmRfYWRkX2RldmljZXMoKSBmb3Ig cHJvY2Vzc2luZy4KPiA+Cj4gPiBJbiBhbiBpZGVhbCB3b3JsZC4gIFRoZSBkZXZpY2VzIHdpdGgg dGhlIHBsYXRmb3JtX2lkOyAwLCAxIGFuZCAyIHdvdWxkCj4gPiBiZSBtYXRjaGVkIHVwIHRvIERl dmljZSBUcmVlIG5vZGVzOyBjaGlsZEAwLCBjaGlsZEAxIGFuZCBjaGlsZEAyCj4gPiByZXNwZWN0 aXZlbHkuICBJbnN0ZWFkIGFsbCAzIGRldmljZXMgd2lsbCBiZSBhbGxvY2F0ZWQgYSBwb2ludGVy IHRvCj4gPiBjaGlsZEAwJ3MgT0Ygbm9kZSwgd2hpY2ggaXMgb2J2aW91c2x5IG5vdCBjb3JyZWN0 Lgo+ID4KPiA+IFRoaXMgaXMgaG93IGl0IGxvb2tzIHdoZW4gZWFjaCBvZiB0aGUgY2hpbGQgZGV2 aWNlcyBhcmUgcHJvYmVkOgo+ID4KPiA+ICBbMC43MDgyODddIG1mZC1vZi10ZXN0LXBhcmVudCBt ZmRfb2ZfdGVzdDogUmVnaXN0ZXJpbmcgMyBkZXZpY2VzCj4gPiAgWy4uLl0KPiA+ICBbMC43MTI1 MTFdIG1mZC1vZi10ZXN0LWNoaWxkIG1mZF9vZl90ZXN0X2NoaWxkLjA6IFByb2JpbmcgcGxhdGZv cm0gZGV2aWNlOiAwCj4gPiAgWzAuNzEyNzEwXSBtZmQtb2YtdGVzdC1jaGlsZCBtZmRfb2ZfdGVz dF9jaGlsZC4wOiBVc2luZyBPRiBub2RlOiBjaGlsZEAwCj4gPiAgWzAuNzEzMDMzXSBtZmQtb2Yt dGVzdC1jaGlsZCBtZmRfb2ZfdGVzdF9jaGlsZC4xOiBQcm9iaW5nIHBsYXRmb3JtIGRldmljZTog MQo+ID4gIFswLjcxMzM4MV0gbWZkLW9mLXRlc3QtY2hpbGQgbWZkX29mX3Rlc3RfY2hpbGQuMTog VXNpbmcgT0Ygbm9kZTogY2hpbGRAMAo+ID4gIFswLjcxMzY5MV0gbWZkLW9mLXRlc3QtY2hpbGQg bWZkX29mX3Rlc3RfY2hpbGQuMjogUHJvYmluZyBwbGF0Zm9ybSBkZXZpY2U6IDIKPiA+ICBbMC43 MTM4ODldIG1mZC1vZi10ZXN0LWNoaWxkIG1mZF9vZl90ZXN0X2NoaWxkLjI6IFVzaW5nIE9GIG5v ZGU6IGNoaWxkQDAKPiA+Cj4gPiAiV2h5IGlzIGl0IHdoZW4gSSBjaGFuZ2UgY2hpbGQgMidzIGNs b2NrIHJhdGUsIGl0IGFsc28gY2hhbmdlcyAwJ3M/Igo+ID4KPiA+IFdob29wcyEKPiA+Cj4gPiBT byBpbiBvcmRlciB0byBmaXggdGhpcywgd2UgbmVlZCB0byBtYWtlIE1GRCBtb3JlLWNsZXZlcmVy IQo+ID4KPiA+IEhvd2V2ZXIsIHRoaXMgaXMgbm90IHNvIHNpbXBsZS4gIFRoZXJlIGFyZSBzb21l IHJ1bGVzIHdlIHNob3VsZCBhYmlkZQo+ID4gYnkgKEkgdXNlICJzaG91bGQiIGludGVudGlvbmFs bHkgaGVyZSwgYXMgc29tZXRoaW5nIG1pZ2h0IGp1c3QgaGF2ZSB0bwo+ID4gZ2l2ZSk6Cj4gPgo+ ID4gIGEpIFNpbmNlIERldmljZSBUcmVlIGlzIGRlc2lnbmVkIHRvIGRlc2NyaWJlIGhhcmR3YXJl LCBpbnNlcnRpbmcKPiA+ICAgICBhcmJpdHJhcnkgcHJvcGVydGllcyBpbnRvIERUIGlzIGZvcmJp ZGRlbi4gIFRoaXMgcHJlY2x1ZGVzIHRoaW5ncwo+ID4gICAgIHdlIHdvdWxkIG9yZGluYXJpbHkg YmUgYWJsZSB0byBtYXRjaCBvbiwgbGlrZSAnaWQnIG9yICduYW1lJy4KPiA+ICBiKSBBcyBhbiBl eHRlbnNpb24gdG8gYSkgRFRzIHNob3VsZCBhbHNvIGJlIE9TIGFnbm9zdGljLCBzbwo+ID4gICAg IHByb3BlcnRpZXMgbGlrZSAnbWZkLWRldmljZScsICdtZmQtb3JkZXInIGV0YyBhcmUgYWxzbyBu b3QKPiA+ICAgICBub3Qgc3VpdGFibGUgZm9yIGluY2x1c2lvbi4KPiA+ICBjKSBUaGUgZmluYWwg c29sdXRpb24gc2hvdWxkIGlkZWFsbHkgYmUgY2FwYWJsZSBvZiBzdXBwb3J0aW5nIGJvdGgKPiA+ ICAgICBuZXdseSBkZWZpbmVkIGFuZCBjdXJyZW50IHRyZWVzICh3aXRob3V0IHJldHJvYWN0aXZl IGVkaXRzKQo+ID4gICAgIGFsaWtlLgo+IAo+IFByZXN1bWFibHkgYW55dGhpbmcgY3VycmVudCBh bHJlYWR5IHdvcmtzLiBJZiB5b3UgaGFkIHRoZSBhYm92ZQo+IGV4YW1wbGUgYWxyZWFkeSwgcmVx dWlyaW5nIHVwZGF0aW5nIHRoZSBEVCB0byBtYWtlIGl0IHdvcmsgc2VlbXMgZmluZS4KCiJ3b3Jr cyIgaXQgYSBtYXR0ZXIgb2Ygb3Bpbmlvbi4gIFNvbWUgaW5zdGFuY2VzICJ3b3JrIiBvdXQgb2Yg bHVjay4KU29tZSAid29yayIgYmVjYXVzZSB0aGV5IGhhdmUgYmVlbiB3b3JrZWQtYXJvdW5kIG9y IGFuIGFsdGVybmF0aXZlCmltcGxlbWVudGF0aW9uIHNvdWdodC4KCkZvciBpbnN0YW5jZSwgJ2Fi ODUwMC1wd20nIG9ubHkgaGFzIDEgRFQgbm9kZSBwcmVzZW50LCB5ZXQgMyBkZXZpY2VzCmFyZSBy ZWdpc3RlcmVkIHZpYSBNRkQuICBTaW5jZSBNRkQgbWF0Y2hlcyBkZXZpY2VzIHdpdGggRFQgbm9k ZXMKY29udGFpbmluZyBpZGVudGljYWwgY29tcGF0aWJsZSBzdHJpbmdzIHVzaW5nIGZpcnN0LWZv dW5kLCBhbGwgUFdNCmluc3RhbmNlcyBhcmUgYXNzaWduZWQgYSBwb2ludGVyIHRvIHRoZSAxIGV4 aXN0aW5nIERUIG5vZGUuCkZvcnR1bmF0ZWx5IGluIHRoaXMgY2FzZSB0aGV5IGFsbCBzaGFyZSB0 aGUgc2FtZSBjbG9jaywgc28gaXQgIndvcmtzIiwKYnV0IHRoYXQncyBjbGVhcmx5IG5vdCB0aGUg aW50ZW5kZWQgaW1wbGVtZW50YXRpb24uCgo+ID4gIGQpIEV4aXN0aW5nIHByb3BlcnRpZXMgY291 bGQgYmUgdXNlZCwgYnV0IG5vdCBhYnVzZWQuICBGb3IgZXhhbXBsZSwKPiA+ICAgICBvbmUgb2Yg bXkgc3VnZ2VzdGlvbnMgKHNlZSBiZWxvdykgaXMgdG8gdXNlIHRoZSAncmVnJyBwcm9wZXJ0eS4K PiA+ICAgICBUaGlzIGlzIGZpbmUgaW4gcHJpbmNpcGxlIGJ1dCBsb2FkaW5nICdyZWcnIHdpdGgg YXJiaXRyYXJ5IHZhbHVlcwo+ID4gICAgIChzdWNoIGFzOyAwLCAxLCAyIC4uLiB4KSB3aGljaCAx KSBjbGVhcmx5IGRvIG5vdCBoYXZlIGFueXRoaW5nIHRvCj4gPiAgICAgZG8gd2l0aCByZWdpc3Rl cnMgYW5kIDIpIHdvdWxkIGJlIG1lYW5pbmdsZXNzIGluIG90aGVyIE9TZXMvCj4gPiAgICAgaW1w bGVtZW50YXRpb25zLCBqdXN0IHRvIHNlcnZlIG91ciBwdXJwb3NlLCBpcyB0byBiZSBpbnRlcnBy ZXRlZAo+ID4gICAgIGFzIGFuIGFidXNlLgo+IAo+IE11bHRpcGxlIGluc3RhbmNlcyBvZiBzb21l dGhpbmcgaW1wbGllcyB5b3UgaGF2ZSBzb21lIHdheSB0byBhZGRyZXNzCj4gdGhlbSBhbmQgJ3Jl ZycgaXMgd2hhdCBkZWZpbmVzIHRoZSBhZGRyZXNzIG9mIHNvbWV0aGluZy4gMCwxLDIsZXRjLgo+ IGxvb2tzIHN1c3BpY2lvdXNseSBsaWtlIGp1c3Qgc29tZSBrZXJuZWwgZGVmaW5lZCBpbmRleGVz LCBidXQgaWYKPiB0aGF0J3MgaG93IHRoaW5ncyBhcmUgZGVmaW5lZCBpbiB0aGUgZGF0YXNoZWV0 IEknbSBva2F5IHdpdGggdGhlbS4KPiAKPiBUaGUgb25lIHdyaW5rbGUgaXMgdGhlcmUncyBvbmx5 IG9uZSBhZGRyZXNzIHNwYWNlIGF0IG9uZSBsZXZlbCwgc28KPiBncGlvQDAsIGdwaW9AMSwgcHdt QDAsIHB3bUAxLCBldGMuIGRvZXNuJ3QgcmVhbGx5IHdvcmsgKHdlbGwsIGl0Cj4gd29ya3MsIGJ1 dCBoYXZpbmcgb3ZlcmxhcHBpbmcgYWRkcmVzc2VzIGlzIG5vdCBnb29kIHByYWN0aWNlKS4gRWl0 aGVyCj4gd2UgcmVsYXggdGhhdCBpbiB0aGlzIGNhc2Ugb3Igd2UgY2FuIGFkZCBhbm90aGVyIGxl dmVsIHRvIGdyb3VwIG5vZGVzLgoKQWxsIGFncmVlZC4gIFNvdW5kcyBwcm9taXNpbmcuCgo+ID4g UHJvcG9zYWwgMToKPiA+Cj4gPiBBcyBtZW50aW9uZWQgYWJvdmUsIG15IGluaXRpYWwgdGhvdWdo dHMgd2VyZSB0byB1c2UgdGhlICdyZWcnIHByb3BlcnR5Cj4gPiB0byBtYXRjaCBhbiBNRkQgY2Vs bCBlbnRyeSB3aXRoIHRoZSBjb3JyZWN0IERUIG5vZGUuICBIb3dldmVyLCBub3QKPiA+IGFsbCBE ZXZpY2UgVHJlZSBub2RlcyBoYXZlICdyZWcnIHByb3BlcnRpZXMuICBQYXJ0aWN1bGFybHkgdHJ1 ZSBpbiB0aGUKPiA+IGNhc2Ugb2YgTUZELCB3aGVyZSBtZW1vcnkgcmVzb3VyY2VzIGFyZSB1c3Vh bGx5IHNoYXJlZCB3aXRoIHRoZSBwYXJlbnQKPiA+IHZpYSBSZWdtYXAsIG9yIChhcyBpbiB0aGUg Y2FzZSBvZiB0aGUgYWI4NTAwKSB0aGUgTUZEIGhhbmRsZXMgYWxsCj4gPiByZWdpc3RlciB0cmFu c2FjdGlvbnMgdmlhIGl0cyBvd24gQVBJLgo+IAo+IEp1c3QgdG8gcGljayBvbiBhYjg1MDAsIGl0 IHNob3VsZCBoYXZlIGhhZCAncmVnJyBwcm9wZXJ0eSBJTU8uIFRoZQo+ICdiYW5rJyBpcyBjbGVh cmx5IGEgaC93IHByb3BlcnR5IGFuZCBob3cgeW91IGFkZHJlc3MgZWFjaCBzdWItZGV2aWNlLgo+ IAo+ID4KPiA+IFByb3Bvc2FsIDI6Cj4gPgo+ID4gSWYgd2UgY2FuJ3QgZ3VhcmFudGVlIHRoYXQg YWxsIERUIG5vZGVzIHdpbGwgaGF2ZSBhdCBsZWFzdCBvbmUKPiA+IHByb3BlcnR5IGluIGNvbW1v biB0byBiZSB1c2VkIGZvciBtYXRjaGluZyBhbmQgd2UncmUgcHJldmVudGVkIGZyb20KPiA+IHN1 cHBseWluZyBhZGRpdGlvbmFsLCBwb3RlbnRpYWxseSBiZXNwb2tlIHByb3BlcnRpZXMsIHRoZW4g d2UgbXVzdAo+ID4gc2VlayBhbiBhbHRlcm5hdGl2ZSBwcm9jZWR1cmUuCj4gPgo+ID4gSXQgc2hv dWxkIGJlIHBvc3NpYmxlIHRvIG1hdGNoIGJhc2VkIG9uIG9yZGVyLiAgSG93ZXZlciwgdGhlIGRl dmVsb3Blcgo+ID4gd291bGQgaGF2ZSB0byBndWFyYW50ZWUgdGhhdCB0aGUgb3JkZXIgaW4gd2hp Y2ggdGhlIGNoaWxkIGRldmljZXMgYXJlCj4gPiBwcmVzZW50ZWQgdG8gdGhlIE1GRCBBUEkgYXJl IGluIGV4YWN0bHkgdGhlIHNhbWUgb3JkZXIgYXMgdGhleSBhcmUKPiA+IHJlcHJlc2VudGVkIGlu IHRoZSBEZXZpY2UgVHJlZS4gIFRoZSBvYnZpb3VzIGRyYXctYmFjayB0byB0aGlzCj4gPiBzdHJh dGVneSBpcyB0aGF0IGl0J3MgcG90ZW50aWFsbHkgdmVyeSBmcmFnaWxlLgo+IAo+IEkgZG9uJ3Qg dGhpbmsgd2Ugc2hvdWxkIHVzZSBvcmRlci4KCklmIGl0J3MgYWx3YXlzIHBvc3NpYmxlIHRvIGhh dmUgYSAncmVnJyBwcm9wZXJ0eSB0aGVuIHdlIHdvbid0IG5lZWQKdG8uCgo+ID4gQ3VycmVudCBQ cm9wb3NhbDoKPiA+Cj4gPiBIb3cgYWJvdXQgYSBjb2xsZWN0aW9uIG9mIFByb3Bvc2FsIDEgYW5k IFByb3Bvc2FsIDI/ICBGaXJzdCB3ZSBjb3VsZAo+ID4gYXR0ZW1wdCBhIG1hdGNoIG9uIHRoZSAn cmVnJyBwcm9wZXJ0eS4gIFRoZW4sIGlmIHRoYXQgZmFpbHMsIHdlIHdvdWxkCj4gPiB1c2UgdGhl IGZyYWdpbGUtYnV0LWl0cy1hbGwtd2UtaGF2ZSBQcm9wb3NhbCAyIGFzIHRoZSBmYWxsLWJhY2su Cj4gCj4gWWVzLCB3ZSBzaG91bGQgdXNlICdyZWcnIHdoZW5ldmVyIHBvc3NpYmxlLiBJZiB3ZSBk b24ndCBoYXZlICdyZWcnLAo+IHRoZW4geW91IHNob3VsZG4ndCBoYXZlIGEgdW5pdC1hZGRyZXNz IGVpdGhlciBhbmQgeW91IGNhbiBzaW1wbHkgbWF0Y2gKPiBvbiB0aGUgbm9kZSBuYW1lIChzdGFu ZGFyZCBEVCBkcml2ZXIgbWF0Y2hpbmcgaXMgd2l0aCBjb21wYXRpYmxlLAo+IGRldmljZV90eXBl LCBhbmQgbm9kZSBuYW1lICh3L28gdW5pdC1hZGRyZXNzKSkuIFdlJ3ZlIGdlbmVyYWxseSBiZWVu Cj4gZG9pbmcgJ2NsYXNzbmFtZS1OJyB3aGVuIHRoZXJlJ3Mgbm8gJ3JlZycgdG8gZG8gJ2NsYXNz bmFtZUBOJy4KPiBNYXRjaGluZyBvbiAnY2xhc3NuYW1lLU4nIHdvdWxkIHdvcmsgd2l0aCBub2Rl IG5hbWUgbWF0Y2hpbmcgYXMgb25seQo+IHVuaXQtYWRkcmVzc2VzIGFyZSBzdHJpcHBlZC4KCkxl dCBtZSB0cnkgYW5kIGtub2NrIHNvbWV0aGluZyB1cC4KCkknbGwgZ2V0IGJhY2sgdG8geW91IHdo ZW4gaXQncyBkb25lLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQpTZW5pb3IgVGVjaG5pY2Fs IExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29m dHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJs b2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK