All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
	philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
	axboe@kernel.dk, bfields@fieldses.org, chuck.lever@oracle.com,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	davem@davemloft.net, kuba@kernel.org, dhowells@redhat.com,
	jarkko.sakkinen@linux.intel.com, jmorris@namei.org,
	serge@hallyn.com, christian.brauner@ubuntu.com
Cc: slyfox@gentoo.org, ast@kernel.org, keescook@chromium.org,
	josh@joshtriplett.org, ravenexp@gmail.com, chainsaw@gentoo.org,
	linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
	bridge@lists.linux-foundation.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: [PATCH 3/5] test_kmod: Avoid potential double free in trigger_config_run_type()
Date: Wed, 10 Jun 2020 15:49:21 +0000	[thread overview]
Message-ID: <20200610154923.27510-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20200610154923.27510-1-mcgrof@kernel.org>

From: Tiezhu Yang <yangtiezhu@loongson.cn>

Reset the member "test_fs" of the test configuration after a call
of the function "kfree_const" to a null pointer so that a double
memory release will not be performed.

Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index e651c37d56db..eab52770070d 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -745,7 +745,7 @@ static int trigger_config_run_type(struct kmod_test_device *test_dev,
 		break;
 	case TEST_KMOD_FS_TYPE:
 		kfree_const(config->test_fs);
-		config->test_driver = NULL;
+		config->test_fs = NULL;
 		copied = config_copy_test_fs(config, test_str,
 					     strlen(test_str));
 		break;
-- 
2.26.2

WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
	philipp.reisner@linbit.com, lars.ellenberg@linbit.com,
	axboe@kernel.dk, bfields@fieldses.org, chuck.lever@oracle.com,
	roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com,
	davem@davemloft.net, kuba@kernel.org, dhowells@redhat.com,
	jarkko.sakkinen@linux.intel.com, jmorris@namei.org,
	serge@hallyn.com, christian.brauner@ubuntu.com
Cc: linux-nfs@vger.kernel.org, chainsaw@gentoo.org,
	ravenexp@gmail.com, linux-kernel@vger.kernel.org,
	bridge@lists.linux-foundation.org, josh@joshtriplett.org,
	slyfox@gentoo.org, ast@kernel.org,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	Luis Chamberlain <mcgrof@kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	keescook@chromium.org
Subject: [Bridge] [PATCH 3/5] test_kmod: Avoid potential double free in trigger_config_run_type()
Date: Wed, 10 Jun 2020 15:49:28 -0000	[thread overview]
Message-ID: <20200610154923.27510-4-mcgrof@kernel.org> (raw)
In-Reply-To: <20200610154923.27510-1-mcgrof@kernel.org>

From: Tiezhu Yang <yangtiezhu@loongson.cn>

Reset the member "test_fs" of the test configuration after a call
of the function "kfree_const" to a null pointer so that a double
memory release will not be performed.

Fixes: d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 lib/test_kmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_kmod.c b/lib/test_kmod.c
index e651c37d56db..eab52770070d 100644
--- a/lib/test_kmod.c
+++ b/lib/test_kmod.c
@@ -745,7 +745,7 @@ static int trigger_config_run_type(struct kmod_test_device *test_dev,
 		break;
 	case TEST_KMOD_FS_TYPE:
 		kfree_const(config->test_fs);
-		config->test_driver = NULL;
+		config->test_fs = NULL;
 		copied = config_copy_test_fs(config, test_str,
 					     strlen(test_str));
 		break;
-- 
2.26.2


  parent reply	other threads:[~2020-06-10 15:49 UTC|newest]

Thread overview: 124+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-10 15:49 [PATCH 0/5] kmod/umh: a few fixes Luis R. Rodriguez
2020-06-10 15:49 ` [Bridge] " Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 1/5] selftests: kmod: Use variable NAME in kmod_test_0001() Luis R. Rodriguez
2020-06-10 15:49   ` [Bridge] " Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 2/5] kmod: Remove redundant "be an" in the comment Luis R. Rodriguez
2020-06-10 15:49   ` [Bridge] " Luis R. Rodriguez
2020-06-10 15:49 ` Luis R. Rodriguez [this message]
2020-06-10 15:49   ` [Bridge] [PATCH 3/5] test_kmod: Avoid potential double free in trigger_config_run_type() Luis R. Rodriguez
2020-06-10 15:49 ` [PATCH 4/5] umh: fix processed error when UMH_WAIT_PROC is used Luis R. Rodriguez
2020-06-10 15:49   ` [Bridge] " Luis R. Rodriguez
2020-06-10 15:49   ` Luis R. Rodriguez
2020-06-23 14:11   ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x Christian Borntraeger
2020-06-23 14:12     ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-23 14:11     ` Christian Borntraeger
2020-06-23 14:23     ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-23 15:09       ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-23 14:23       ` Christian Borntraeger
2020-06-24 11:11       ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 11:12         ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 11:11         ` Christian Borntraeger
2020-06-24 12:05         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-24 12:05           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-24 12:05           ` Luis Chamberlain
2020-06-24 13:17           ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-24 13:17             ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-24 13:17             ` Luis Chamberlain
2020-06-24 16:13             ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-24 16:13               ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-24 16:13               ` Luis Chamberlain
2020-06-24 14:43         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christoph Hellwig
2020-06-24 14:43           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christoph Hellwig
2020-06-24 14:43           ` Christoph Hellwig
2020-06-24 15:54           ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 15:56             ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 15:54             ` Christian Borntraeger
2020-06-24 16:09             ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-24 16:09               ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-24 16:09               ` Luis Chamberlain
2020-06-24 17:58               ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 17:59                 ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 17:58                 ` Christian Borntraeger
2020-06-24 18:09                 ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 18:10                   ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 18:09                   ` Christian Borntraeger
2020-06-24 18:32                   ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 18:32                     ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 18:32                     ` Christian Borntraeger
2020-06-24 18:37                     ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-24 18:38                       ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-24 18:37                       ` Christian Borntraeger
2020-06-25 13:26                       ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-25 13:27                         ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-25 13:26                         ` Christian Borntraeger
2020-06-26  2:54                       ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-26  2:54                         ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-26  2:54                         ` Luis Chamberlain
2020-06-26  5:22                         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-06-26  5:24                           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-06-26  5:22                           ` Christian Borntraeger
2020-06-26  9:00                           ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christoph Hellwig
2020-06-26  9:00                             ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christoph Hellwig
2020-06-26  9:00                             ` Christoph Hellwig
2020-06-26 11:40                             ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-26 11:40                               ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-26 11:40                               ` Luis Chamberlain
2020-06-26 11:50                               ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-26 11:50                                 ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-26 11:50                                 ` Luis Chamberlain
2020-06-30 17:57                         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-06-30 17:57                           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-06-30 17:57                           ` Luis Chamberlain
2020-07-01 10:08                           ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-07-01 10:08                             ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-07-01 10:08                             ` Christian Borntraeger
2020-07-01 13:24                             ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Tetsuo Handa
2020-07-01 13:24                               ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Tetsuo Handa
2020-07-01 13:24                               ` Tetsuo Handa
2020-07-01 13:53                               ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-01 13:53                                 ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-01 13:53                                 ` Luis Chamberlain
2020-07-01 14:08                                 ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Tetsuo Handa
2020-07-01 14:08                                   ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Tetsuo Handa
2020-07-01 14:08                                   ` Tetsuo Handa
2020-07-01 15:38                                   ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-01 15:39                                     ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-01 15:38                                     ` Luis Chamberlain
2020-07-01 15:48                                     ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-07-01 15:49                                       ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-07-01 15:48                                       ` Christian Borntraeger
2020-07-01 15:58                                       ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-01 15:58                                         ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-01 15:58                                         ` Luis Chamberlain
2020-07-01 16:01                                         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-07-01 16:03                                           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-07-01 16:01                                           ` Christian Borntraeger
2020-07-02  4:26                                     ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Tetsuo Handa
2020-07-02  4:26                                       ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Tetsuo Handa
2020-07-02  4:26                                       ` Tetsuo Handa
2020-07-02 19:46                                       ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-02 19:47                                         ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-02 19:46                                         ` Luis Chamberlain
2020-07-03  0:52                                         ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Tetsuo Handa
2020-07-03  0:52                                           ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Tetsuo Handa
2020-07-03  0:52                                           ` Tetsuo Handa
2020-07-03 13:28                                           ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-03 13:28                                             ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-03 13:28                                             ` Luis Chamberlain
2020-07-01 15:26                                 ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Christian Borntraeger
2020-07-01 15:27                                   ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Christian Borntraeger
2020-07-01 15:26                                   ` Christian Borntraeger
2020-07-01 13:46                             ` linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s Luis Chamberlain
2020-07-01 13:46                               ` [Bridge] linux-next: umh: fix processed error when UMH_WAIT_PROC is used seems to break linux bridge on s390x (bisected) Luis Chamberlain
2020-07-01 13:46                               ` Luis Chamberlain
2020-06-10 15:49 ` [PATCH 5/5] selftests: simplify kmod failure value Luis R. Rodriguez
2020-06-10 15:49   ` [Bridge] " Luis R. Rodriguez
2020-06-10 15:49   ` Luis R. Rodriguez
2020-06-18  0:43 ` [PATCH 0/5] kmod/umh: a few fixes Andrew Morton
2020-06-18  0:43   ` [Bridge] " Andrew Morton
2020-06-18  0:43   ` Andrew Morton
2020-06-19 20:46   ` Luis Chamberlain
2020-06-19 20:46     ` [Bridge] " Luis Chamberlain
2020-06-19 20:46     ` Luis Chamberlain
2020-06-19 21:07     ` Luis Chamberlain
2020-06-19 21:07       ` [Bridge] " Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200610154923.27510-4-mcgrof@kernel.org \
    --to=mcgrof@kernel.org \
    --cc=ast@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=bfields@fieldses.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=chainsaw@gentoo.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=chuck.lever@oracle.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jmorris@namei.org \
    --cc=josh@joshtriplett.org \
    --cc=keescook@chromium.org \
    --cc=keyrings@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=philipp.reisner@linbit.com \
    --cc=ravenexp@gmail.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=serge@hallyn.com \
    --cc=slyfox@gentoo.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.