From: Tomasz Figa <tfiga@chromium.org>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com,
helen.koike@collabora.com, ezequiel@collabora.com,
hverkuil@xs4all.nl, kernel@collabora.com, dafna3@gmail.com,
sakari.ailus@linux.intel.com, linux-rockchip@lists.infradead.org,
mchehab@kernel.org, skhan@linuxfoundation.org,
niklas.soderlund@ragnatech.se--annotate
Subject: Re: [PATCH v4 3/5] media: staging: rkisp1: validate links before powering and streaming
Date: Wed, 10 Jun 2020 17:00:07 +0000 [thread overview]
Message-ID: <20200610170007.GB201868@chromium.org> (raw)
In-Reply-To: <20200522075522.6190-4-dafna.hirschfeld@collabora.com>
On Fri, May 22, 2020 at 09:55:20AM +0200, Dafna Hirschfeld wrote:
> In function rkisp1_vb2_start_streaming, the call to
> media_pipeline_start should be the first thing in order
> to validate the links and prevents their state from being modified
> before power up and streaming.
>
> Adjust stop streaming to the same logic, call media_pipeline_stop
> after we disable streaming on the entities in the topology.
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
> ---
> drivers/staging/media/rkisp1/rkisp1-capture.c | 21 ++++++++++---------
> 1 file changed, 11 insertions(+), 10 deletions(-)
>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
next prev parent reply other threads:[~2020-06-10 17:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:55 [PATCH v4 0/5] media: add v4l2_pipeline_stream_{enable,disable} Dafna Hirschfeld
2020-05-22 7:55 ` [PATCH v4 1/5] media: mc-entity.c: add media_graph_walk_next_stream() Dafna Hirschfeld
2020-05-22 7:55 ` [PATCH v4 2/5] media: v4l2-common: add helper functions to call s_stream() callbacks Dafna Hirschfeld
2020-05-25 9:23 ` Sakari Ailus
2020-05-25 9:42 ` Dafna Hirschfeld
2020-05-25 10:03 ` Sakari Ailus
2020-05-25 10:45 ` Dafna Hirschfeld
2020-06-22 9:20 ` Sakari Ailus
2020-06-22 9:00 ` Hans Verkuil
2020-06-22 14:07 ` Dafna Hirschfeld
2020-05-22 7:55 ` [PATCH v4 3/5] media: staging: rkisp1: validate links before powering and streaming Dafna Hirschfeld
2020-06-10 17:00 ` Tomasz Figa [this message]
2020-05-22 7:55 ` [PATCH v4 4/5] media: staging: rkisp1: cap: use v4l2_pipeline_stream_{enable,disable} helpers Dafna Hirschfeld
2020-06-10 17:03 ` Tomasz Figa
2020-06-10 17:22 ` Dafna Hirschfeld
2020-06-10 17:28 ` Tomasz Figa
2020-05-22 7:55 ` [PATCH v4 5/5] media: vimc: " Dafna Hirschfeld
2020-05-22 9:06 ` [PATCH v4 0/5] media: add v4l2_pipeline_stream_{enable,disable} Helen Koike
2020-05-26 16:11 ` Tomasz Figa
2020-05-26 18:57 ` Laurent Pinchart
2020-05-28 16:21 ` Dafna Hirschfeld
2020-05-29 13:26 ` Tomasz Figa
2020-05-29 13:27 ` Tomasz Figa
2020-05-29 13:49 ` Helen Koike
2020-05-29 14:48 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200610170007.GB201868@chromium.org \
--to=tfiga@chromium.org \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=ezequiel@collabora.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se--annotate \
--cc=sakari.ailus@linux.intel.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.