From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58925C433E0 for ; Thu, 11 Jun 2020 03:10:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EE935206FA for ; Thu, 11 Jun 2020 03:10:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CFRiL+ZF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE935206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A34C8D0076; Wed, 10 Jun 2020 23:10:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32D608D004C; Wed, 10 Jun 2020 23:10:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CE468D0076; Wed, 10 Jun 2020 23:10:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 00E0A8D004C for ; Wed, 10 Jun 2020 23:10:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B03138017B3C for ; Thu, 11 Jun 2020 03:10:11 +0000 (UTC) X-FDA: 76915452222.25.coach32_5b0934426dd0 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 745AD1804E3E0 for ; Thu, 11 Jun 2020 03:10:11 +0000 (UTC) X-HE-Tag: coach32_5b0934426dd0 X-Filterd-Recvd-Size: 5868 Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 11 Jun 2020 03:10:10 +0000 (UTC) Received: by mail-pj1-f67.google.com with SMTP id ga6so1667034pjb.1 for ; Wed, 10 Jun 2020 20:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vDiv9K+R80Of7Rf+WZwp3JnikQ0o+LDfnejX8SJBW/g=; b=CFRiL+ZF426+/u6PuA1WLovGaAWi/DkmNtLnZHjyXbs+lE3v4VWDYlyrV5PrFfgkka i5xMYXETlaoURUwNeQypuz0Blt06pWAjaCXBxiXKI7TcRXd70x9K18W6Si1QjDXv+QJg 4y7CTPDCgBlYtEK57ph7ThHsEKrEqRcyb9QPysO673+406vl9w5jEorrPt8h6oSUM7vF p4sRZ9xDeMGN8yQjRJ7w39vRZBd5iaWjOZ0dDfIh48tXBZ9lt7ubymQg8ca7DRZ8hyeH NYLst2+cna9tiagnAx4IN4b6B7WOm4B5z2TniC3nQJbn/IbpLsWFDNywip3JlSH9JY+D yhmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=vDiv9K+R80Of7Rf+WZwp3JnikQ0o+LDfnejX8SJBW/g=; b=r0yB76TQtedsxFns9PFAE+v2bT7+ACCaxthT8uGC/5iccMBzqvtRp+i50wGsiCuw9g Hx0ffZfX3jyghdpzQBCfHb7yqsAglyai/PQgkE3gKfMwA4WhTS22BQpi9Gu8y9cyrYso VKFD6E8VGeSnNN8D/M8xiNXwXnGenpzTUZHCcOsgt+FLYvjfZ8blf6qASWgIbsGsIFzQ hroAywfV78vOOYtwMbU4TeogGWlTyqf353UIgf5jynJvEOO0hyPLs+ubC8TIHhapl3uB w5RYMK5z5JLsqnpSEabRS2msi43ZWmE12jC2ovwXb/clXtX3iDXfner0lFzeGLn1sQe3 iA+g== X-Gm-Message-State: AOAM532YFJnwfls6xNAOyurEPFoA8stvP2SiMBwplRWtYRxD83lnv/cE zbf8uUQ3j1fbDVcAzGrIyZM= X-Google-Smtp-Source: ABdhPJyImkbLSSjBrF7lDYUf/YHeHajQkT4mYFoRJNN14glQ8F6xjRRB2BXM6b2EuTRlSX//uakxZw== X-Received: by 2002:a17:90a:7c48:: with SMTP id e8mr5882399pjl.235.1591845009917; Wed, 10 Jun 2020 20:10:09 -0700 (PDT) Received: from google.com ([2601:647:4001:3000::e690]) by smtp.gmail.com with ESMTPSA id m22sm1358431pfk.216.2020.06.10.20.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 20:10:08 -0700 (PDT) Date: Wed, 10 Jun 2020 20:10:06 -0700 From: Minchan Kim To: Linus Torvalds Cc: Andrew Morton , arjunroy@google.com, Brian Geffon , Christian Brauner , Daniel Colascione , Johannes Weiner , joaodias@google.com, Joel Fernandes , Linux-MM , Michal Hocko , mm-commits@vger.kernel.org, Oleksandr Natalenko , David Rientjes , Shakeel Butt , sj38.park@gmail.com, Sonny Rao , sspatil@google.com, Suren Baghdasaryan , Tim Murray , Vlastimil Babka Subject: Re: [patch 24/25] mm: use only pidfd for process_madvise syscall Message-ID: <20200611031006.GA137891@google.com> References: <20200610184053.3fa7368ab80e23bfd44de71f@linux-foundation.org> <20200611014241.11iF_RJqJ%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 745AD1804E3E0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 10, 2020 at 07:09:16PM -0700, Linus Torvalds wrote: > On Wed, Jun 10, 2020 at 6:42 PM Andrew Morton wrote: > > > > From: Minchan Kim > > Subject: mm: use only pidfd for process_madvise syscall > > No. > > I'm not taking this crazy series. > > First we have patch 18/25, which introduces process_madvise() that > takes a pidfd. > > Then we have patch 21/25, which says > > "There is a demand[1] to support pid as well pidfd for process_madvise.." > > and points to > > https://lore.kernel.org/linux-mm/9d849087-3359-c4ab-fbec-859e8186c509@virtuozzo.com/ > > And then finally we have patch 24/25, which says > > "Based on discussion[1], people didn't feel we need to support both > pid and pidfd for every new coming API[2] so this patch keeps only > pidfd" > > and points to > > https://lore.kernel.org/linux-mm/20200509124817.xmrvsrq3mla6b76k@wittgenstein/ > > Fine. Discussion is good. But this patch-series is crazy, and I refuse > to take this kind of schizophrenic patches that can't make up their > mind. > > Make up your mind, dammit! Don't send me patches that vacillate > between two standpoints and make the history and the eventual final > end result really hard to tell. > > What will it be tomorrow? Another two patches that decide to go the > other way and then back? > > I'm going to flush this whole madvise patch-set down the toilet, > because after having this kind of whip-lash looking through it, I > can't take it any more. > > So all of 17-25 are just going in the garbage until people can make up > their minds. At next revision, I will merge 18 and 23 into a patch with dropping 21 and 24. Andrew, I will resend it after rc window is closed. Thanks. [patch 18/25] mm/madvise: introduce process_madvise() syscall: an external memory hinting API [patch 21/25] mm/madvise: support both pid and pidfd for process_madvise [patch 23/25] mm: support vector address ranges for process_madvise [patch 24/25] mm: use only pidfd for process_madvise syscall