From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F5BC433E0 for ; Thu, 11 Jun 2020 13:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C8E332083E for ; Thu, 11 Jun 2020 13:54:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbgFKNyc (ORCPT ); Thu, 11 Jun 2020 09:54:32 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37332 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726109AbgFKNyb (ORCPT ); Thu, 11 Jun 2020 09:54:31 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jjNf3-000BIH-4f; Thu, 11 Jun 2020 15:54:29 +0200 Date: Thu, 11 Jun 2020 15:54:29 +0200 From: Andrew Lunn To: Meir Lichtinger Cc: netdev Subject: Re: [PATCH net-next 1/2] ethtool: Add support for 100Gbps per lane link modes Message-ID: <20200611135429.GF19869@lunn.ch> References: <20200430234106.52732-1-saeedm@mellanox.com> <20200430234106.52732-2-saeedm@mellanox.com> <20200502150857.GC142589@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > How do you know you have connected a 400000baseLR4 to a > > 400000baseER4 with a 40Km and it is not expected to work, when looking > > at ethtool? I assume the EEPROM contents tell you if the module is > > LR4, ER4, or FR4? > > > > Andrew > Correct. Hi Meir Do you also have patches to Ethtool to decode these bits in the SFP EEPROM? > In addition, this is the terminology exposed in 50 Gbps and we > followed it. Yes, i missed the patch which added those. I would probably of objected. But we have them now, so lets keep going. But we might want a clear definition of when modes can be combined like this. Andrew