From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D505C433E0 for ; Thu, 11 Jun 2020 15:24:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5505A2067B for ; Thu, 11 Jun 2020 15:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbgFKPYW convert rfc822-to-8bit (ORCPT ); Thu, 11 Jun 2020 11:24:22 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:43067 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728104AbgFKPYW (ORCPT ); Thu, 11 Jun 2020 11:24:22 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 523F120000C; Thu, 11 Jun 2020 15:24:18 +0000 (UTC) Date: Thu, 11 Jun 2020 17:24:17 +0200 From: Miquel Raynal To: Kamal Dasu Cc: Brian Norris , Richard Weinberger , Vignesh Raghavendra , MTD Maling List , bcm-kernel-feedback-list , Linux Kernel Mailing List Subject: Re: [PATCH 1/2] mtd: rawnand: brcmnand: Don't default to edu transfer Message-ID: <20200611172417.66eb6c3b@xps13> In-Reply-To: References: <20200611054454.2547-1-kdasu.kdev@gmail.com> <20200611091604.1bec2418@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kamal, Kamal Dasu wrote on Thu, 11 Jun 2020 11:22:56 -0400: > On Thu, Jun 11, 2020 at 3:16 AM Miquel Raynal wrote: > > > > Hi Kamal, > > > > Kamal Dasu wrote on Thu, 11 Jun 2020 01:44:53 > > -0400: > > > > > When flash-dma is absent do not default to using flash-edu. > > > Make sure flash-edu is enabled before setting EDU transfer > > > function. > > > > > > Fixes: a5d53ad26a8b ("mtd: rawnand: brcmnand: Add support for flash-edu for dma transfers") > > > Signed-off-by: Kamal Dasu > > > --- > > > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > > index 8f9ffb46a09f..0c1d6e543586 100644 > > > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > > > @@ -2953,8 +2953,9 @@ int brcmnand_probe(struct platform_device *pdev, struct brcmnand_soc *soc) > > > if (ret < 0) > > > goto err; > > > > > > - /* set edu transfer function to call */ > > > - ctrl->dma_trans = brcmnand_edu_trans; > > > + if (has_edu(ctrl)) > > > + /* set edu transfer function to call */ > > > + ctrl->dma_trans = brcmnand_edu_trans; > > > > Does this fallback to returning an error in case !has_edu() ? Othewise, > > how is it handled? > > > > The driver will default to pio if both flash-dma and falsh-edu are > not present. > > > Thanks, > > Miquèl > > Kamal Ok, thanks for the clarification! Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 621EEC433DF for ; Thu, 11 Jun 2020 15:24:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 211F42067B for ; Thu, 11 Jun 2020 15:24:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="apgCtSJo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 211F42067B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f6UeRk0sAyxJYD2rEbov2mWTVkElB2VWgqz0KEpIiTo=; b=apgCtSJojZmx44 jMSKGIew9MsZTMkiQb8X31++zsYJgLFzzP4T5nLlhhUcKf/JM13ptHLRmWFiZc/B7eOvCqB+9qIQT KI0Ckx3uW5w8tOP+lPrE9w4bsKsPd5Gtoj9qyvdbafGG0fOG7yNvDQZd6GVaJXncXa2Li3+Uh8qjd qwn0KDvPTVELr7qX+k1bgCtNt7ijefVY9xcIHfO7wZCxEbZfq65TqaUsZ8+hdKUdtQjnlCttu91wk xNvwBcfeuRiaWlZimCzMhFInyoDM97VVv2FfguzMU3EHi68yCUDM7X4ObtQhbwW4mb85AgTGcr7+T B6bstJk8ONPnsG61eNUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjP46-0000mv-4e; Thu, 11 Jun 2020 15:24:26 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjP43-0000lw-9F for linux-mtd@lists.infradead.org; Thu, 11 Jun 2020 15:24:24 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 523F120000C; Thu, 11 Jun 2020 15:24:18 +0000 (UTC) Date: Thu, 11 Jun 2020 17:24:17 +0200 From: Miquel Raynal To: Kamal Dasu Subject: Re: [PATCH 1/2] mtd: rawnand: brcmnand: Don't default to edu transfer Message-ID: <20200611172417.66eb6c3b@xps13> In-Reply-To: References: <20200611054454.2547-1-kdasu.kdev@gmail.com> <20200611091604.1bec2418@xps13> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200611_082423_462726_EFF62328 X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Richard Weinberger , Linux Kernel Mailing List , MTD Maling List , bcm-kernel-feedback-list , Brian Norris Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgS2FtYWwsCgpLYW1hbCBEYXN1IDxrZGFzdS5rZGV2QGdtYWlsLmNvbT4gd3JvdGUgb24gVGh1 LCAxMSBKdW4gMjAyMCAxMToyMjo1NgotMDQwMDoKCj4gT24gVGh1LCBKdW4gMTEsIDIwMjAgYXQg MzoxNiBBTSBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPiB3cm90ZToK PiA+Cj4gPiBIaSBLYW1hbCwKPiA+Cj4gPiBLYW1hbCBEYXN1IDxrZGFzdS5rZGV2QGdtYWlsLmNv bT4gd3JvdGUgb24gVGh1LCAxMSBKdW4gMjAyMCAwMTo0NDo1Mwo+ID4gLTA0MDA6Cj4gPiAgCj4g PiA+IFdoZW4gZmxhc2gtZG1hIGlzIGFic2VudCBkbyBub3QgZGVmYXVsdCB0byB1c2luZyBmbGFz aC1lZHUuCj4gPiA+IE1ha2Ugc3VyZSBmbGFzaC1lZHUgaXMgZW5hYmxlZCBiZWZvcmUgc2V0dGlu ZyBFRFUgdHJhbnNmZXIKPiA+ID4gZnVuY3Rpb24uCj4gPiA+Cj4gPiA+IEZpeGVzOiBhNWQ1M2Fk MjZhOGIgKCJtdGQ6IHJhd25hbmQ6IGJyY21uYW5kOiBBZGQgc3VwcG9ydCBmb3IgZmxhc2gtZWR1 IGZvciBkbWEgdHJhbnNmZXJzIikKPiA+ID4gU2lnbmVkLW9mZi1ieTogS2FtYWwgRGFzdSA8a2Rh c3Uua2RldkBnbWFpbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcv YnJjbW5hbmQvYnJjbW5hbmQuYyB8IDUgKysrLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4gPiA+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFuZC5jIGIvZHJpdmVycy9tdGQvbmFuZC9y YXcvYnJjbW5hbmQvYnJjbW5hbmQuYwo+ID4gPiBpbmRleCA4ZjlmZmI0NmEwOWYuLjBjMWQ2ZTU0 MzU4NiAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9tdGQvbmFuZC9yYXcvYnJjbW5hbmQvYnJj bW5hbmQuYwo+ID4gPiArKysgYi9kcml2ZXJzL210ZC9uYW5kL3Jhdy9icmNtbmFuZC9icmNtbmFu ZC5jCj4gPiA+IEBAIC0yOTUzLDggKzI5NTMsOSBAQCBpbnQgYnJjbW5hbmRfcHJvYmUoc3RydWN0 IHBsYXRmb3JtX2RldmljZSAqcGRldiwgc3RydWN0IGJyY21uYW5kX3NvYyAqc29jKQo+ID4gPiAg ICAgICAgICAgICAgIGlmIChyZXQgPCAwKQo+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgZ290 byBlcnI7Cj4gPiA+Cj4gPiA+IC0gICAgICAgICAgICAgLyogc2V0IGVkdSB0cmFuc2ZlciBmdW5j dGlvbiB0byBjYWxsICovCj4gPiA+IC0gICAgICAgICAgICAgY3RybC0+ZG1hX3RyYW5zID0gYnJj bW5hbmRfZWR1X3RyYW5zOwo+ID4gPiArICAgICAgICAgICAgIGlmIChoYXNfZWR1KGN0cmwpKQo+ ID4gPiArICAgICAgICAgICAgICAgICAgICAgLyogc2V0IGVkdSB0cmFuc2ZlciBmdW5jdGlvbiB0 byBjYWxsICovCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICBjdHJsLT5kbWFfdHJhbnMgPSBi cmNtbmFuZF9lZHVfdHJhbnM7ICAKPiA+Cj4gPiBEb2VzIHRoaXMgZmFsbGJhY2sgdG8gcmV0dXJu aW5nIGFuIGVycm9yIGluIGNhc2UgIWhhc19lZHUoKSA/IE90aGV3aXNlLAo+ID4gaG93IGlzIGl0 IGhhbmRsZWQ/Cj4gPiAgCj4gCj4gIFRoZSBkcml2ZXIgd2lsbCBkZWZhdWx0IHRvIHBpbyBpZiBi b3RoIGZsYXNoLWRtYSBhbmQgZmFsc2gtZWR1IGFyZQo+IG5vdCBwcmVzZW50Lgo+IAo+ID4gVGhh bmtzLAo+ID4gTWlxdcOobCAgCj4gCj4gS2FtYWwKCgpPaywgdGhhbmtzIGZvciB0aGUgY2xhcmlm aWNhdGlvbiEKClRoYW5rcywKTWlxdcOobAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlz dApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K