From: Josh Kunz <jkz@google.com>
To: qemu-devel@nongnu.org
Cc: riku.voipio@iki.fi, laurent@vivier.eu, alex.bennee@linaro.org,
Josh Kunz <jkz@google.com>
Subject: [PATCH 0/5] linux-user: Support extended clone(CLONE_VM)
Date: Thu, 11 Jun 2020 18:46:01 -0700 [thread overview]
Message-ID: <20200612014606.147691-1-jkz@google.com> (raw)
This patch series implements extended support for the `clone` system
call. As best I can tell, any option combination including `CLONE_VM`
should be supported with the addition of this patch series. The
implementation is described in greater detail in the patches themselves.
Testing:
* All targets built on x86_64.
* `make check` and `make check-tcg` are passing. Additional tests have
been added to `linux-test.c` to validate clone behavior.
Caveats:
* This series touches, but does not fix, several bits of code that are
racey (namely the sigact table and the fd trans table).
* `exit_group` does not perform the appropriate cleanup for non-thread
children created with `CLONE_VM`. CPUs for such children are never
cleaned up. The correct implementation of exit-group is non-trivial
(since it also needs to track/handle cleanup for threads in the
clone'd child process). Also, I don't fully understand the
interaction between QOM<->linux-user. My naive implementation based
on the current implementation `exit(2)` was regularly crashing. If
maintainers have suggestions for better ways to handle exit_group,
they would be greatly appreciated.
* execve does not clean up the CPUs of clone'd children, for the same
reasons as `exit_group`.
Josh Kunz (5):
linux-user: Refactor do_fork to use new `qemu_clone`
linux-user: Make fd_trans task-specific.
linux-user: Make sigact_table part of the task state.
linux-user: Support CLONE_VM and extended clone options
linux-user: Add PDEATHSIG test for clone process hierarchy.
linux-user/Makefile.objs | 2 +-
linux-user/clone.c | 565 ++++++++++++++++++++++++++++
linux-user/clone.h | 27 ++
linux-user/fd-trans-tbl.c | 13 +
linux-user/fd-trans-type.h | 17 +
linux-user/fd-trans.c | 3 -
linux-user/fd-trans.h | 75 ++--
linux-user/main.c | 1 +
linux-user/qemu.h | 49 +++
linux-user/signal.c | 84 ++++-
linux-user/syscall.c | 452 ++++++++++++----------
tests/tcg/multiarch/Makefile.target | 3 +
tests/tcg/multiarch/linux-test.c | 227 ++++++++++-
13 files changed, 1264 insertions(+), 254 deletions(-)
create mode 100644 linux-user/clone.c
create mode 100644 linux-user/clone.h
create mode 100644 linux-user/fd-trans-tbl.c
create mode 100644 linux-user/fd-trans-type.h
--
2.27.0.290.gba653c62da-goog
next reply other threads:[~2020-06-12 1:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 1:46 Josh Kunz [this message]
2020-06-12 1:46 ` [PATCH 1/5] linux-user: Refactor do_fork to use new `qemu_clone` Josh Kunz
2020-06-16 15:51 ` Alex Bennée
2020-06-12 1:46 ` [PATCH 2/5] linux-user: Make fd_trans task-specific Josh Kunz
2020-06-12 1:46 ` [PATCH 3/5] linux-user: Make sigact_table part of the task state Josh Kunz
2020-06-12 1:46 ` [PATCH 4/5] linux-user: Support CLONE_VM and extended clone options Josh Kunz
2020-06-13 0:10 ` Josh Kunz
2020-06-16 16:08 ` Alex Bennée
2020-06-23 3:43 ` Josh Kunz
2020-06-23 8:21 ` Alex Bennée
[not found] ` <CADgy-2tB0Z133RB1i8OdnpKMD3xATL059dFoduHOjdim11G4-A@mail.gmail.com>
[not found] ` <87k0zw7opa.fsf@linaro.org>
2020-07-09 0:16 ` Josh Kunz
2020-07-16 10:41 ` Alex Bennée
2020-06-12 1:46 ` [PATCH 5/5] linux-user: Add PDEATHSIG test for clone process hierarchy Josh Kunz
2020-06-12 3:48 ` [PATCH 0/5] linux-user: Support extended clone(CLONE_VM) no-reply
2020-06-13 11:16 ` Alex Bennée
2020-06-16 16:02 ` Alex Bennée
2020-06-16 16:32 ` Peter Maydell
2020-06-16 23:38 ` Josh Kunz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612014606.147691-1-jkz@google.com \
--to=jkz@google.com \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.