All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining
Date: Fri, 12 Jun 2020 22:16:51 +1000	[thread overview]
Message-ID: <20200612121651.GA15849@gondor.apana.org.au> (raw)
In-Reply-To: <1688262.LSb4nGpegl@tauon.chronox.de>

On Fri, Jun 12, 2020 at 02:15:52PM +0200, Stephan Mueller wrote:
>
> > +static inline unsigned int crypto_skcipher_fcsize(
> > +	struct crypto_skcipher *tfm)
> > +{
> > +	return crypto_skcipher_alg_fcsize(crypto_skcipher_alg(tfm));
> 
> Don't we have an implicit signedness conversion here? int -> unsigned int?

Good catch.  It's supposed to be int.  Let me fix this.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2020-06-12 12:16 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19 19:02 [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Ard Biesheuvel
2020-05-19 19:02 ` Ard Biesheuvel
2020-05-19 19:02 ` [RFC/RFT PATCH 1/2] crypto: arm64/aes - align output IV with generic CBC-CTS driver Ard Biesheuvel
2020-05-19 19:02   ` Ard Biesheuvel
2020-05-19 19:02 ` [RFC/RFT PATCH 2/2] crypto: testmgr - add output IVs for AES-CBC with ciphertext stealing Ard Biesheuvel
2020-05-19 19:02   ` Ard Biesheuvel
2020-05-19 19:04 ` [RFC/RFT PATCH 0/2] crypto: add CTS output IVs for arm64 and testmgr Ard Biesheuvel
2020-05-19 19:04   ` Ard Biesheuvel
2020-05-20  6:03 ` Stephan Mueller
2020-05-20  6:03   ` Stephan Mueller
2020-05-20  6:40   ` Ard Biesheuvel
2020-05-20  6:40     ` Ard Biesheuvel
2020-05-20  6:47     ` Stephan Mueller
2020-05-20  6:47       ` Stephan Mueller
2020-05-20  6:54       ` Ard Biesheuvel
2020-05-20  6:54         ` Ard Biesheuvel
2020-05-20  7:01         ` Stephan Mueller
2020-05-20  7:01           ` Stephan Mueller
2020-05-20  7:09           ` Ard Biesheuvel
2020-05-20  7:09             ` Ard Biesheuvel
2020-05-21 13:01             ` Gilad Ben-Yossef
2020-05-21 13:01               ` Gilad Ben-Yossef
2020-05-21 13:23               ` Ard Biesheuvel
2020-05-21 13:23                 ` Ard Biesheuvel
2020-05-23 18:52                 ` Stephan Müller
2020-05-23 18:52                   ` Stephan Müller
2020-05-23 22:40                   ` Ard Biesheuvel
2020-05-23 22:40                     ` Ard Biesheuvel
2020-05-28  7:33 ` Herbert Xu
2020-05-28  7:33   ` Herbert Xu
2020-05-28  8:33   ` Ard Biesheuvel
2020-05-28  8:33     ` Ard Biesheuvel
2020-05-29  8:05     ` Herbert Xu
2020-05-29  8:05       ` Herbert Xu
2020-05-29  8:20       ` Ard Biesheuvel
2020-05-29  8:20         ` Ard Biesheuvel
2020-05-29 11:51         ` Herbert Xu
2020-05-29 11:51           ` Herbert Xu
2020-05-29 12:00           ` Ard Biesheuvel
2020-05-29 12:00             ` Ard Biesheuvel
2020-05-29 12:02             ` Herbert Xu
2020-05-29 12:02               ` Herbert Xu
2020-05-29 13:10               ` Ard Biesheuvel
2020-05-29 13:10                 ` Ard Biesheuvel
2020-05-29 13:19                 ` Herbert Xu
2020-05-29 13:19                   ` Herbert Xu
2020-05-29 13:41                   ` Ard Biesheuvel
2020-05-29 13:41                     ` Ard Biesheuvel
2020-05-29 13:42                     ` Herbert Xu
2020-05-29 13:42                       ` Herbert Xu
2020-06-12 12:06                       ` [PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Herbert Xu
2020-06-12 12:07                         ` [PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining Herbert Xu
2020-06-12 12:15                           ` Stephan Mueller
2020-06-12 12:16                             ` Herbert Xu [this message]
2020-06-12 12:21                               ` [v2 PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Herbert Xu
2020-06-12 12:21                                 ` [v2 PATCH 1/3] crypto: skcipher - Add final chunk size field for chaining Herbert Xu
2020-06-12 12:21                                 ` [v2 PATCH 2/3] crypto: algif_skcipher - Add support for fcsize Herbert Xu
2020-06-12 12:21                                 ` [v2 PATCH 3/3] crypto: cts - Add support for chaining Herbert Xu
2020-06-12 16:10                                 ` [v2 PATCH 0/3] crypto: skcipher - Add support for no chaining and partial chaining Ard Biesheuvel
2020-06-15  7:30                                   ` Herbert Xu
2020-06-15  7:50                                     ` Ard Biesheuvel
2020-06-15 18:50                                       ` Eric Biggers
2020-06-15 23:18                                         ` Ard Biesheuvel
2020-06-16 11:04                                         ` Herbert Xu
2020-06-16 16:53                                           ` Eric Biggers
2020-06-12 12:07                         ` [PATCH 2/3] crypto: algif_skcipher - Add support for fcsize Herbert Xu
2020-06-12 12:07                         ` [PATCH 3/3] crypto: cts - Add support for chaining Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612121651.GA15849@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=ardb@kernel.org \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=smueller@chronox.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.