From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE34C433DF for ; Sun, 14 Jun 2020 03:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 810282083E for ; Sun, 14 Jun 2020 03:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="khudvC7k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgFNDBU (ORCPT ); Sat, 13 Jun 2020 23:01:20 -0400 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:35852 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726499AbgFNDBT (ORCPT ); Sat, 13 Jun 2020 23:01:19 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 49kzkQ5zv6z9vZw4 for ; Sun, 14 Jun 2020 03:01:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0o_eabydskmD for ; Sat, 13 Jun 2020 22:01:18 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 49kzkQ4Dz3z9vZx6 for ; Sat, 13 Jun 2020 22:01:18 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p8.oit.umn.edu 49kzkQ4Dz3z9vZx6 DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p8.oit.umn.edu 49kzkQ4Dz3z9vZx6 Received: by mail-io1-f72.google.com with SMTP id d20so8930264iom.16 for ; Sat, 13 Jun 2020 20:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=cOgHpCEAAAGqQDbbixnX7uhIWd2KMk0lv565gUU7esU=; b=khudvC7kbksJLnNR3xG6AAZ5VFW/9CNcXYYV/ulZ976gfAAaipmqB15w7jO76lIoMJ YB9I982kBR9w2M2joRO5CDUZTExYtrIB+V0LlC2Clx8qohj4QgvSR4xKCR1+jz+K5P50 iRItj7gd4U5cgYXpFEh+c3c7xRYl7BDUXe9DZOV0IrWnVv0ODucjWYIR8kkFp+dMI3Bu lvJssg30dL9Ac1IdAuA+cU0zeb5i61gOVz4dwY/txEbznKi7gXL0wmZKFE9PDWid04Jf oeIBsk5tqxN5gI3+uj7e2wd8txqTd7SolqocLPy6eZg/QKXgxQ7oqulCFVCuO/Xp4QM3 FP6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cOgHpCEAAAGqQDbbixnX7uhIWd2KMk0lv565gUU7esU=; b=cvMsZot7HGvK2kT7GbCGoEd2rOPnDl7+W6CD3i7qyhHmKiD/wIM+3pHlW/adjtjQ/A pMXt7VlxHrln6dtmhdPu/gNTpAVh+GJDiwJZdM1h8SIc7uSXAdz1jC6Rz5kCfr5n0kLo RHtUgYVbyqYu0jZuJ5BYmH0kUgkjNiN8gD6zfPAChHbYj9VNTMIg6Adh0ZAx4VgvYIjw BBrvbNcvKJ4aAQ8qAP970x7YzvLFmJBW+HsgJwyTmSjA3rONib2xyCCNzygirwaahQnp Vz3luFlXLfLbkZeNw/FVbbiHqScncpctQfSku1U/QYIgY591C/kDveDDQpzmMJVENCBj iWYg== X-Gm-Message-State: AOAM533crPbSiBVy3ciAT0g5tRSQDP8sd5FDRByCGHksk8mmMHgMOfzL jQenXv39evuPJ0DVsQZMmWseURLDA6iBLawyAQ2rg8kPMQ4qfKWVo0J4vJXlUvHCRUcEuAAbkQk 2NDO2ZJv1ihIg/E+dh/L1B7Htrc3T X-Received: by 2002:a92:d112:: with SMTP id a18mr19876653ilb.3.1592103678098; Sat, 13 Jun 2020 20:01:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTFVu29soAQKwJchdpgwjpKebLlBpdEM/Z/hVt5TRB+tZ1yqGgKWvSgKXVBGcdcozs35SC4w== X-Received: by 2002:a92:d112:: with SMTP id a18mr19876632ilb.3.1592103677826; Sat, 13 Jun 2020 20:01:17 -0700 (PDT) Received: from qiushi.cs.umn.edu ([2607:ea00:101:3c74:4874:45:bcb4:df60]) by smtp.gmail.com with ESMTPSA id q5sm5656947ile.37.2020.06.13.20.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 20:01:17 -0700 (PDT) From: wu000273@umn.edu To: kjlu@umn.edu Cc: wu000273@umn.edu, Kyungmin Park , Sylwester Nawrocki , Mauro Carvalho Chehab , Kukjin Kim , Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: exynos4-is: Fix a reference count leak Date: Sat, 13 Jun 2020 22:01:11 -0500 Message-Id: <20200614030111.28843-1-wu000273@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi Wu --- drivers/media/platform/exynos4-is/mipi-csis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index 540151bbf58f..1aac167abb17 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -510,8 +510,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable) if (enable) { s5pcsis_clear_counters(state); ret = pm_runtime_get_sync(&state->pdev->dev); - if (ret && ret != 1) + if (ret && ret != 1) { + pm_runtime_put_noidle(&state->pdev->dev); return ret; + } } mutex_lock(&state->lock); -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60365C433E0 for ; Sun, 14 Jun 2020 03:01:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3540E2083E for ; Sun, 14 Jun 2020 03:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Rf7krFqC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=umn.edu header.i=@umn.edu header.b="khudvC7k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3540E2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=umn.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=DxCeHvIHafqaYj5+rOtG2PmUBg05Ij0k2JNE1sEn1yQ=; b=Rf7 krFqC6V1T/5gt3fSLOdqPyPJdIlhhm7RPhE99ml9K60Owwkc2SlFcr1OvVPvzpnLpqBrRecV6ucVs KvTAzA4D7NsGRAYKprGXTBRWqU1D/KRwlFfESd4qKqEApYa1mrkz7kqMyx/+vT1OcWDj7jN2LBWgY AsyzyCQgQwq09QL3jyOAs6/WiHsP6b+zkpZvDF1sKfqHhduffb7QHmx/N12ZEPBp5UZEP8T8o+dne a/knPpdjOtTFEK4MIHVEI49XYN+9mZeze+aDTO7z5E54J02C/zBwevcFv3EONi5djq68Wjq/LwgD1 x4v2d8uoNvFH2WZzwDTvLrhGQ9Oni8Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkItd-0001RJ-NY; Sun, 14 Jun 2020 03:01:21 +0000 Received: from mta-p8.oit.umn.edu ([134.84.196.208]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkItb-0001Qq-FG for linux-arm-kernel@lists.infradead.org; Sun, 14 Jun 2020 03:01:20 +0000 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 49kzkQ5ZCzz9vZx8 for ; Sun, 14 Jun 2020 03:01:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tv-GXWHld09y for ; Sat, 13 Jun 2020 22:01:18 -0500 (CDT) Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 49kzkQ3jNsz9vZw4 for ; Sat, 13 Jun 2020 22:01:18 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p8.oit.umn.edu 49kzkQ3jNsz9vZw4 DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p8.oit.umn.edu 49kzkQ3jNsz9vZw4 Received: by mail-io1-f72.google.com with SMTP id a16so8985691iow.9 for ; Sat, 13 Jun 2020 20:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=cOgHpCEAAAGqQDbbixnX7uhIWd2KMk0lv565gUU7esU=; b=khudvC7kbksJLnNR3xG6AAZ5VFW/9CNcXYYV/ulZ976gfAAaipmqB15w7jO76lIoMJ YB9I982kBR9w2M2joRO5CDUZTExYtrIB+V0LlC2Clx8qohj4QgvSR4xKCR1+jz+K5P50 iRItj7gd4U5cgYXpFEh+c3c7xRYl7BDUXe9DZOV0IrWnVv0ODucjWYIR8kkFp+dMI3Bu lvJssg30dL9Ac1IdAuA+cU0zeb5i61gOVz4dwY/txEbznKi7gXL0wmZKFE9PDWid04Jf oeIBsk5tqxN5gI3+uj7e2wd8txqTd7SolqocLPy6eZg/QKXgxQ7oqulCFVCuO/Xp4QM3 FP6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cOgHpCEAAAGqQDbbixnX7uhIWd2KMk0lv565gUU7esU=; b=o+y4LH87MA6oIOEo9BTvWRMjbip1qLOGyYt7rFkPN17gQBcfnFtNNNdIXWWqGCXohE zdxIM0bP4d3UasoXn1Ird07m1PgGtWBigVMgz5ScZVNkjK0nku/KGUebyJCFt1XTPFKP QqAd9AzJZbVPDZBFu0E8D8zBdzHTf77Yooh+HqRCmHaOCZ7afm13m0pNwCFD4fzkm2H6 G3LWrYtspJYtN/91Zvhsp7GfqX1j+Xma0916g1r5xzeOMc57hzS2S+eYVKDhswyGCV+k 5saKZHWiiok6YxFzcb9IwJv1w7Qz3NiUXhWAFABnW0ha4Zo5v6JFuTWzeLBR69qo50PP fEXw== X-Gm-Message-State: AOAM533/Q3KqbuOdGMBkWVlC4TWZLoVyc2y4jHDCIGcN5wCpX92XZ4RX M3k9CRFnd5NxKQvivsbUB/bhFopdOApWlQnsreDrHuVJyXwejsfzdyxSsLE0FT/0oK51EY0asJA we0DaXH46sSUw1cPr5AmIex+058l+ch7Hs89WxT8= X-Received: by 2002:a92:d112:: with SMTP id a18mr19876654ilb.3.1592103678098; Sat, 13 Jun 2020 20:01:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTFVu29soAQKwJchdpgwjpKebLlBpdEM/Z/hVt5TRB+tZ1yqGgKWvSgKXVBGcdcozs35SC4w== X-Received: by 2002:a92:d112:: with SMTP id a18mr19876632ilb.3.1592103677826; Sat, 13 Jun 2020 20:01:17 -0700 (PDT) Received: from qiushi.cs.umn.edu ([2607:ea00:101:3c74:4874:45:bcb4:df60]) by smtp.gmail.com with ESMTPSA id q5sm5656947ile.37.2020.06.13.20.01.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Jun 2020 20:01:17 -0700 (PDT) From: wu000273@umn.edu To: kjlu@umn.edu Subject: [PATCH] media: exynos4-is: Fix a reference count leak Date: Sat, 13 Jun 2020 22:01:11 -0500 Message-Id: <20200614030111.28843-1-wu000273@umn.edu> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200613_200119_596402_50C790D3 X-CRM114-Status: GOOD ( 13.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, wu000273@umn.edu, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kyungmin Park , Kukjin Kim , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Qiushi Wu pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code, causing incorrect ref count if pm_runtime_put_noidle() is not called in error handling paths. Thus call pm_runtime_put_noidle() if pm_runtime_get_sync() fails. Signed-off-by: Qiushi Wu --- drivers/media/platform/exynos4-is/mipi-csis.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index 540151bbf58f..1aac167abb17 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -510,8 +510,10 @@ static int s5pcsis_s_stream(struct v4l2_subdev *sd, int enable) if (enable) { s5pcsis_clear_counters(state); ret = pm_runtime_get_sync(&state->pdev->dev); - if (ret && ret != 1) + if (ret && ret != 1) { + pm_runtime_put_noidle(&state->pdev->dev); return ret; + } } mutex_lock(&state->lock); -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel