All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v1 4/4] gpio: pca953x: disable regmap locking for automatic address incrementing
Date: Mon, 15 Jun 2020 14:20:44 +0200	[thread overview]
Message-ID: <20200615122044.j2vdhpmhbpsw6qkb@taurus.defre.kleine-koenig.org> (raw)
In-Reply-To: <20200605134036.9013-4-andriy.shevchenko@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Fri, Jun 05, 2020 at 04:40:36PM +0300, Andy Shevchenko wrote:
> It's a repetition of the commit aa58a21ae378
>   ("gpio: pca953x: disable regmap locking")
> which states the following:
> 
>   This driver uses its own locking but regmap silently uses
>   a mutex for all operations too. Add the option to disable
>   locking to the regmap config struct.
> 
> Fixes: bcf41dc480b1 ("gpio: pca953x: fix handling of automatic address incrementing")
> Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Ah, good catch. I assume that I didn't have aa58a21ae378 in my tree when
I created the patch that then became bcf41dc480b1.

Looks right

Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Thanks
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2020-06-15 12:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05 13:40 [PATCH v1 1/4] gpio: pca953x: Synchronize interrupt handler properly Andy Shevchenko
2020-06-05 13:40 ` [PATCH v1 2/4] gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2 Andy Shevchenko
2020-06-05 13:40 ` [PATCH v1 3/4] gpio: pca953x: Fix direction setting when configure an IRQ Andy Shevchenko
2020-06-05 13:40 ` [PATCH v1 4/4] gpio: pca953x: disable regmap locking for automatic address incrementing Andy Shevchenko
2020-06-15 12:20   ` Uwe Kleine-König [this message]
2020-06-15 12:53     ` Andy Shevchenko
2020-06-15 13:20       ` Uwe Kleine-König
2020-06-15 13:38         ` Andy Shevchenko
2020-06-15 14:18           ` Uwe Kleine-König
2020-06-15 15:12             ` Andy Shevchenko
2020-06-16  9:24       ` Bartosz Golaszewski
2020-06-16 12:53         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200615122044.j2vdhpmhbpsw6qkb@taurus.defre.kleine-koenig.org \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.