From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3733BC433DF for ; Mon, 15 Jun 2020 14:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 154892071A for ; Mon, 15 Jun 2020 14:56:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592232963; bh=2TC//kCSiqr/n1JFxAXwx0DjT4t5nRNJzXNSfvJPnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VA41BpjCNnIkH8cKGa9hsi66XQcFz3jlxA1+eKWQMLATvD30gWWBDeN/yKFZ8KUK1 58Fp9Ev6DNLKRrTb14lQjNTWC8JayBr3dQIslL5POHg2mmRrhOvbSsdQ/LYC2BPFW9 aUIjAuW17RdOqZrGxp80x4NLuK9zWlTkGdwbR46U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730834AbgFOO4A (ORCPT ); Mon, 15 Jun 2020 10:56:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43552 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730213AbgFOOz7 (ORCPT ); Mon, 15 Jun 2020 10:55:59 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1B7E20644; Mon, 15 Jun 2020 14:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592232958; bh=2TC//kCSiqr/n1JFxAXwx0DjT4t5nRNJzXNSfvJPnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WAzQ4fSL7Ni+8MhSFeK+hvrEhia4ExOvj7gnafrN8h09OzqA8zOjGsggpxgqezOZb /FiV+/68Cwz+OQkYgCZvTdup8NA67tIxQiZtGhIeChI9QUQ1HW4FBBZ+bwiaqevDRJ hcqc3jkKbV2Vqns7sVYJ1qD2BUt+qAK841dWOONM= Date: Mon, 15 Jun 2020 15:55:56 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200615145556.GY4447@sirena.org.uk> References: <20200612101357.GA5396@sirena.org.uk> <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lPJ5i9rX1WvdYcWF" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --lPJ5i9rX1WvdYcWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 02:53:29PM +0000, Robin Gong wrote: > On 2020/06/15 22:36 Mark Brown wrote:=20 > > We could also pass in a flag that could be set separately to the error = code to > > indicate that nothing had happened to the hardware yet. > Do you mean spi-imx.c checking 'ctlr->flags' before return such error cod= e? > Or just like below done in spi.c. No, I mean passing in an additional argument which can provide richer data than trying to smash things into the return value. --lPJ5i9rX1WvdYcWF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7ni/sACgkQJNaLcl1U h9DpXQf9G2jk6fHADMgZvO5cMWF40DK3HTy0XpAr55BZ3EtoJ9SfnWU4hvTmyvn/ 9gWPmaXi84y5Uq1tvrYZXp70urjy0GAgJD6gpSDPq1PPql9PhVdPtOWg0K9KYt1r iGep527JQyKrorlKPIZ1SLN/9qxexF4GMjkyR7Bjx4H9rrSCKyG+TLrNFGQZL0ft Z93yp3K+RJb8TfYwIF50LbTix6pY4mTd6kNG7rd4RLinkGjBWZWnbdwKQkgBeffM qKVL0ySu1Pgd24bOR6aCKQxdKuCAyxj6dy5Hwya7ZgryKH0eVDdS3P0Vx5pqXS1l jXQt7/A7B3EFdjfQTsqDuDAuACaijw== =lGYg -----END PGP SIGNATURE----- --lPJ5i9rX1WvdYcWF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E6FC433DF for ; Mon, 15 Jun 2020 14:56:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D31AA20644 for ; Mon, 15 Jun 2020 14:56:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="r7tRNLc/"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="WAzQ4fSL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D31AA20644 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k73zJoW+kFuc9m8J7XAuYntMkVvne/9npbP961zIRHo=; b=r7tRNLc/bEyV+8Q+yHa6nNCTP jIecHccf9gOCDDhF915rUKASeyo45lvzjH9E9jEZXNr8/9nEQ4yfmWR6hRKJOHZAuvwDW+Gj95J9f ZReZ95nam7yxAn/EIiWt9r6E8Ei2v6yOvyI5UTuJ3yw5wa1WyzeDcArTnGs4jzmSfu9oY1JntiWI6 cqs1U4KuGYgEy+qNjNX22JTf5H7x8/Euw/qhAOMIvv5To70lTLYzCYwp1il0S5bZlnotQ661yN03G ncvnnoVdrzV0Ha/DuRtXvMtkmMAn0jZcO9aAKWDxA2VY9ywP6IJLNWw46abdpKqwk+zoxWYssYIg+ KfdY3rUGw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkqWn-0004e1-UE; Mon, 15 Jun 2020 14:56:01 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkqWk-0004db-LT for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 14:55:59 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1B7E20644; Mon, 15 Jun 2020 14:55:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592232958; bh=2TC//kCSiqr/n1JFxAXwx0DjT4t5nRNJzXNSfvJPnHQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WAzQ4fSL7Ni+8MhSFeK+hvrEhia4ExOvj7gnafrN8h09OzqA8zOjGsggpxgqezOZb /FiV+/68Cwz+OQkYgCZvTdup8NA67tIxQiZtGhIeChI9QUQ1HW4FBBZ+bwiaqevDRJ hcqc3jkKbV2Vqns7sVYJ1qD2BUt+qAK841dWOONM= Date: Mon, 15 Jun 2020 15:55:56 +0100 From: Mark Brown To: Robin Gong Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200615145556.GY4447@sirena.org.uk> References: <20200612101357.GA5396@sirena.org.uk> <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_075558_728240_ED5ECA9D X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "matthias.schiffer@ew.tq-group.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robin.murphy@arm.com" , "linux-spi@vger.kernel.org" , Vinod Koul , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============1350657167312867458==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1350657167312867458== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lPJ5i9rX1WvdYcWF" Content-Disposition: inline --lPJ5i9rX1WvdYcWF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2020 at 02:53:29PM +0000, Robin Gong wrote: > On 2020/06/15 22:36 Mark Brown wrote:=20 > > We could also pass in a flag that could be set separately to the error = code to > > indicate that nothing had happened to the hardware yet. > Do you mean spi-imx.c checking 'ctlr->flags' before return such error cod= e? > Or just like below done in spi.c. No, I mean passing in an additional argument which can provide richer data than trying to smash things into the return value. --lPJ5i9rX1WvdYcWF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7ni/sACgkQJNaLcl1U h9DpXQf9G2jk6fHADMgZvO5cMWF40DK3HTy0XpAr55BZ3EtoJ9SfnWU4hvTmyvn/ 9gWPmaXi84y5Uq1tvrYZXp70urjy0GAgJD6gpSDPq1PPql9PhVdPtOWg0K9KYt1r iGep527JQyKrorlKPIZ1SLN/9qxexF4GMjkyR7Bjx4H9rrSCKyG+TLrNFGQZL0ft Z93yp3K+RJb8TfYwIF50LbTix6pY4mTd6kNG7rd4RLinkGjBWZWnbdwKQkgBeffM qKVL0ySu1Pgd24bOR6aCKQxdKuCAyxj6dy5Hwya7ZgryKH0eVDdS3P0Vx5pqXS1l jXQt7/A7B3EFdjfQTsqDuDAuACaijw== =lGYg -----END PGP SIGNATURE----- --lPJ5i9rX1WvdYcWF-- --===============1350657167312867458== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1350657167312867458==--